perf(studio): defer import history and Nitro scale tools until opened
This commit is contained in:
1 parent
13665e0c3c
commit
afea80708c
5 files changed
+323
-183
No files matched your search
@@ -33,10 +33,28 @@ test("Studio opens and dismisses detail, Nitro editor and import review", async
|
|||||||
const errors: string[] = [];
|
const errors: string[] = [];
|
||||||
const mutations: string[] = [];
|
const mutations: string[] = [];
|
||||||
let metadataRequests = 0;
|
let metadataRequests = 0;
|
||||||
|
let qualityRequests = 0;
|
||||||
page.on("pageerror", (error) => errors.push(error.message));
|
page.on("pageerror", (error) => errors.push(error.message));
|
||||||
await page.route("**/api/**", async (route) => {
|
await page.route("**/api/**", async (route) => {
|
||||||
const request = route.request();
|
const request = route.request();
|
||||||
const url = new URL(request.url());
|
const url = new URL(request.url());
|
||||||
|
if (url.pathname === "/api/admin/studio/nitro-quality") {
|
||||||
|
qualityRequests++;
|
||||||
|
return route.fulfill({
|
||||||
|
json: {
|
||||||
|
report: {
|
||||||
|
scales: [32, 64].map((size) => ({
|
||||||
|
size,
|
||||||
|
state: "missing",
|
||||||
|
assets: [],
|
||||||
|
animations: [],
|
||||||
|
directions: [],
|
||||||
|
issues: [],
|
||||||
|
})),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
}
|
||||||
if (url.pathname === "/api/admin/studio/inspect") {
|
if (url.pathname === "/api/admin/studio/inspect") {
|
||||||
const { classnames } = request.postDataJSON() as { classnames: string[] };
|
const { classnames } = request.postDataJSON() as { classnames: string[] };
|
||||||
return route.fulfill({
|
return route.fulfill({
|
||||||
@@ -113,6 +131,17 @@ test("Studio opens and dismisses detail, Nitro editor and import review", async
|
|||||||
await expect(
|
await expect(
|
||||||
page.getByRole("button", { name: "View Fixture chair", exact: true }),
|
page.getByRole("button", { name: "View Fixture chair", exact: true }),
|
||||||
).toBeVisible();
|
).toBeVisible();
|
||||||
|
const history = page.getByRole("button", {
|
||||||
|
name: "Refresh history",
|
||||||
|
includeHidden: true,
|
||||||
|
});
|
||||||
|
await expect(history).toHaveCount(0);
|
||||||
|
await page.locator("summary").filter({ hasText: "Import history" }).click();
|
||||||
|
await expect(history).toBeVisible();
|
||||||
|
await page.locator("summary").filter({ hasText: "Import history" }).click();
|
||||||
|
await expect(history).toBeHidden();
|
||||||
|
await page.locator("summary").filter({ hasText: "Import history" }).click();
|
||||||
|
await expect(history).toBeVisible();
|
||||||
expect(metadataRequests).toBe(0);
|
expect(metadataRequests).toBe(0);
|
||||||
await page
|
await page
|
||||||
.getByRole("button", { name: "View Fixture chair", exact: true })
|
.getByRole("button", { name: "View Fixture chair", exact: true })
|
||||||
@@ -138,6 +167,20 @@ test("Studio opens and dismisses detail, Nitro editor and import review", async
|
|||||||
editor.getByRole("switch", { name: "Can Sit On", exact: true }),
|
editor.getByRole("switch", { name: "Can Sit On", exact: true }),
|
||||||
).toBeVisible();
|
).toBeVisible();
|
||||||
expect(metadataRequests).toBe(1);
|
expect(metadataRequests).toBe(1);
|
||||||
|
expect(qualityRequests).toBe(0);
|
||||||
|
await editor.getByRole("tab", { name: "32 / 64", exact: true }).click();
|
||||||
|
await expect(
|
||||||
|
editor.getByRole("button", { name: "Preview generation", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
await expect(
|
||||||
|
editor.getByText("Scale 32 · Not included", { exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
expect(qualityRequests).toBe(1);
|
||||||
|
await editor.getByRole("tab", { name: "Visual", exact: true }).click();
|
||||||
|
await expect(
|
||||||
|
editor.getByRole("switch", { name: "Can Sit On", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
|
||||||
await editor.getByRole("button", { name: "Cancel", exact: true }).click();
|
await editor.getByRole("button", { name: "Cancel", exact: true }).click();
|
||||||
await expect(editor).toHaveCount(0);
|
await expect(editor).toHaveCount(0);
|
||||||
await page
|
await page
|
||||||
|
|||||||
@@ -16,10 +16,10 @@ import {
|
|||||||
Save,
|
Save,
|
||||||
Sparkles,
|
Sparkles,
|
||||||
} from "lucide-react";
|
} from "lucide-react";
|
||||||
import { useEffect, useEffectEvent, useState } from "react";
|
import { useTranslations } from "next-intl";
|
||||||
|
import { lazy, Suspense, useEffect, useEffectEvent, useState } from "react";
|
||||||
import { toast } from "sonner";
|
import { toast } from "sonner";
|
||||||
import { NitroQualityPanel } from "@/components/admin/studio/nitro-quality-panel";
|
|
||||||
import { NitroScale32Generator } from "@/components/admin/studio/nitro-scale32-generator";
|
|
||||||
import { Badge } from "@/components/ui/badge";
|
import { Badge } from "@/components/ui/badge";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import {
|
import {
|
||||||
@@ -41,6 +41,17 @@ import {
|
|||||||
nitroAnimationStatesCount,
|
nitroAnimationStatesCount,
|
||||||
} from "@/lib/furni/auto-interaction";
|
} from "@/lib/furni/auto-interaction";
|
||||||
|
|
||||||
|
const NitroQualityPanel = lazy(() =>
|
||||||
|
import("@/components/admin/studio/nitro-quality-panel").then((module) => ({
|
||||||
|
default: module.NitroQualityPanel,
|
||||||
|
})),
|
||||||
|
);
|
||||||
|
const NitroScale32Generator = lazy(() =>
|
||||||
|
import("@/components/admin/studio/nitro-scale32-generator").then(
|
||||||
|
(module) => ({ default: module.NitroScale32Generator }),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
interface NitroEditorDialogProps {
|
interface NitroEditorDialogProps {
|
||||||
classname: string;
|
classname: string;
|
||||||
name?: string;
|
name?: string;
|
||||||
@@ -135,6 +146,7 @@ export function NitroEditorDialog({
|
|||||||
open,
|
open,
|
||||||
onOpenChange,
|
onOpenChange,
|
||||||
}: NitroEditorDialogProps) {
|
}: NitroEditorDialogProps) {
|
||||||
|
const loadingT = useTranslations("pages.admin.housekeeping");
|
||||||
const [metadata, setMetadata] = useState<NitroMetadata | null>(null);
|
const [metadata, setMetadata] = useState<NitroMetadata | null>(null);
|
||||||
const [originalMetadata, setOriginalMetadata] =
|
const [originalMetadata, setOriginalMetadata] =
|
||||||
useState<NitroMetadata | null>(null);
|
useState<NitroMetadata | null>(null);
|
||||||
@@ -448,6 +460,7 @@ export function NitroEditorDialog({
|
|||||||
value="quality"
|
value="quality"
|
||||||
className="min-h-0 overflow-y-auto flex-1 px-4 sm:px-6 py-4"
|
className="min-h-0 overflow-y-auto flex-1 px-4 sm:px-6 py-4"
|
||||||
>
|
>
|
||||||
|
<Suspense fallback={<p role="status">{loadingT("loading")}</p>}>
|
||||||
<NitroScale32Generator
|
<NitroScale32Generator
|
||||||
classname={classname}
|
classname={classname}
|
||||||
disabled={hasChanges || saving}
|
disabled={hasChanges || saving}
|
||||||
@@ -461,6 +474,7 @@ export function NitroEditorDialog({
|
|||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
<NitroQualityPanel key={bundleRevision} classname={classname} />
|
<NitroQualityPanel key={bundleRevision} classname={classname} />
|
||||||
|
</Suspense>
|
||||||
</TabsContent>
|
</TabsContent>
|
||||||
{/* ── Visual Tab ── */}
|
{/* ── Visual Tab ── */}
|
||||||
<TabsContent
|
<TabsContent
|
||||||
|
|||||||
File diff suppressed because it is too large.
Load diff
File diff suppressed because it is too large.
Load diff
@@ -0,0 +1,48 @@
|
|||||||
|
import path from "node:path";
|
||||||
|
import { build } from "esbuild";
|
||||||
|
import { expect, it } from "vitest";
|
||||||
|
|
||||||
|
it("keeps scale preview and generation outside the initial Nitro editor bundle", async () => {
|
||||||
|
const entry = "src/app/admin/import/furni/nitro-editor-dialog.tsx";
|
||||||
|
const result = await build({
|
||||||
|
entryPoints: [entry],
|
||||||
|
bundle: true,
|
||||||
|
splitting: true,
|
||||||
|
format: "esm",
|
||||||
|
write: false,
|
||||||
|
outdir: "storage/bundle-check",
|
||||||
|
metafile: true,
|
||||||
|
packages: "external",
|
||||||
|
alias: { "@": path.resolve("src") },
|
||||||
|
});
|
||||||
|
const outputs = result.metafile.outputs;
|
||||||
|
const start = Object.keys(outputs).find(
|
||||||
|
(key) => outputs[key].entryPoint === entry,
|
||||||
|
);
|
||||||
|
expect(start).toBeDefined();
|
||||||
|
const seen = new Set<string>();
|
||||||
|
function visit(key: string) {
|
||||||
|
if (seen.has(key)) return;
|
||||||
|
seen.add(key);
|
||||||
|
for (const dependency of outputs[key].imports) {
|
||||||
|
if (dependency.kind !== "dynamic-import" && !dependency.external)
|
||||||
|
visit(dependency.path);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (!start) throw new Error("Missing editor entry bundle");
|
||||||
|
visit(start);
|
||||||
|
const initialInputs = new Set(
|
||||||
|
[...seen].flatMap((key) => Object.keys(outputs[key].inputs)),
|
||||||
|
);
|
||||||
|
for (const name of [
|
||||||
|
"nitro-quality-panel.tsx",
|
||||||
|
"nitro-scale32-generator.tsx",
|
||||||
|
]) {
|
||||||
|
expect(
|
||||||
|
Object.keys(result.metafile.inputs).some((input) => input.endsWith(name)),
|
||||||
|
).toBe(true);
|
||||||
|
expect([...initialInputs].some((input) => input.endsWith(name))).toBe(
|
||||||
|
false,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}, 30_000);
|
||||||
Reference in new issue
Block a user