test(ci): deterministic deploy gate + advisory quality suite; sync README versions

The deploy gate ran e2e specs that depend on live content and data, so a missing
upload (the /help article images) or a legacy malformed avatar figure could turn
a safe code deploy red. Split the suites by what they actually guarantee:

- Blocking gate (`pnpm test:e2e`, `playwright.config.ts`): only checks the CMS
  can guarantee itself — anonymous redirects, register form fields, the captcha
  DOM contract and the cache-control headers (deterministic origin-direct).
- Advisory suite (`pnpm test:e2e:quality`, `playwright.quality.config.ts`):
  broken images, layout overflow and warm-page latency, which depend on live
  content/upload state and the host. It runs as a `continue-on-error` CI job
  against the public site so a real content problem stays visible without
  blocking the pipeline.

Also add `scripts/sync-readme-versions.mjs` (+ tests, docs and a CI check) so
the pinned versions in README.md can never drift from package.json / .nvmrc.

.gitea/workflows/ci.yaml

@@ -24,6 +24,9 @@ jobs:
       - name: Toolchain check
         run: node scripts/check-node-toolchain.mjs
 
+      - name: README version sync
+        run: node scripts/sync-readme-versions.mjs --check
+
       - name: Deploy port-selection tests
         run: bash scripts/ci-deploy-ports.test.sh
 
@@ -145,6 +148,46 @@ jobs:
           IMAGING_EDGE: "1"
         run: pnpm test:imaging
 
+  # Advisory live-quality checks: broken uploads/theme assets, legacy malformed
+  # avatar figures and warm-page latency. These depend on live content and data
+  # rather than the code under test, so they are informational only —
+  # `continue-on-error` keeps the pipeline green while still surfacing the
+  # signal in the job log and uploaded report. The deterministic caching contract
+  # is enforced by the blocking deploy gate instead.
+  tests-quality:
+    needs: check
+    if: gitea.event_name == 'push' && (gitea.ref_name == 'main' || gitea.ref_name == 'master')
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          repository: ${{ gitea.repository }}
+          token: ${{ gitea.token }}
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Install quality test browser
+        run: pnpm exec playwright install chromium
+
+      - name: Advisory quality checks
+        continue-on-error: true
+        env:
+          PLAYWRIGHT_BASE_URL: https://epicnabbo.nl
+        run: pnpm test:e2e:quality
+
+      - name: Upload quality results
+        if: always()
+        uses: https://gitea.com/actions/gitea-upload-artifact@62ac910c5d3dfa85c7cb2df15afe2e342b2407c2
+        with:
+          name: quality-results
+          path: |
+            playwright-report/quality/
+            test-results/quality/
+          if-no-files-found: warn
+          retention-days: 14
+
   preflight:
     needs: [tests-unit, tests-integration, tests-ui]
     if: gitea.event_name == 'pull_request' || (gitea.event_name == 'push' && startsWith(gitea.ref, 'refs/heads/codex/'))

README.md

@@ -1065,6 +1065,7 @@ fewer than 1 GB would remain, the script refuses to start.
 | `pnpm test:coverage`  | 8 GB    | Vitest with coverage                    |
 | `pnpm test:ui`        | 8 GB    | Playwright                              |
 | `pnpm test:e2e`       | 8 GB    | Playwright                              |
+| `pnpm test:e2e:quality` | 8 GB  | Playwright (advisory)                   |
 | `pnpm test:integration` | 8 GB  | Vitest integration config               |
 | `pnpm typecheck`      | 6 GB    | `tsc --noEmit`                          |
 
@@ -1132,7 +1133,8 @@ the headroom left for everything else on the machine; the effective ceiling is
 | `pnpm test:coverage`      | Run all tests with coverage thresholds enforced    |
 | `pnpm test:ui`            | Playwright UI tests (`playwright.ui.config.ts`)    |
 | `pnpm test:ui:update`     | Playwright UI tests, updating snapshots            |
-| `pnpm test:e2e`           | Playwright end-to-end tests                        |
+| `pnpm test:e2e`           | Playwright end-to-end tests (blocking deploy gate) |
+| `pnpm test:e2e:quality`   | Advisory content/latency checks (non-blocking)     |
 | `pnpm test:integration`   | Integration tests (own Vitest config)              |
 | `pnpm test:housekeeping`  | Housekeeping feature tests                         |
 | `pnpm lint`               | Lint and format check (Biome)                      |
@@ -1295,6 +1297,25 @@ pnpm analyze      # Build and report per-route bundle sizes
 pnpm biome:check  # Lint and format
 ```
 
+### End-to-end tests
+
+`pnpm test:e2e` is the **blocking deploy gate**. It only contains checks the CMS
+can guarantee on its own (anonymous redirects, the register form fields and the
+captcha DOM contract, cache-control headers), so a green run means a code deploy
+is safe.
+
+Checks that depend on **live content or data** — a missing upload or theme asset
+(`/help` article images), a legacy malformed avatar figure, warm-page latency —
+live in a separate advisory suite:
+
+```bash
+pnpm test:e2e:quality   # playwright.quality.config.ts, never blocks a deploy
+```
+
+It is run against the public site as a `continue-on-error` CI job, so it still
+surfaces a real content problem without turning the pipeline red. Point either
+suite at any running CMS with `PLAYWRIGHT_BASE_URL`.
+
 ### Contributing
 
 1. Ensure typecheck and tests pass: `pnpm typecheck && pnpm test`

e2e/performance.spec.ts

@@ -1,28 +1,11 @@
 import { expect, test } from "@playwright/test";
 
-// Latency + caching contract for the anonymous pages. The perf work relies on
+// Caching contract for the anonymous pages. This is deterministic and stays in
-// the edge/shared cache (`src/proxy.ts`): public content pages advertise a
+// the blocking deploy gate: the perf work relies on the edge/shared cache
-// short `s-maxage`, while session-dependent pages (login, register, settings)
+// (`src/proxy.ts`) — public content pages advertise a short `s-maxage`, while
-// must stay `private, no-store`. Budgets are deliberately loose so a cold
+// session-dependent pages (login, register, settings) must stay
-// cache or a slow CI hop does not flap the gate.
+// `private, no-store`. Timing budgets are advisory and live in
-const BUDGET_MS = Number(process.env.E2E_LOAD_BUDGET_MS || 4000);
+// `e2e/quality/performance.spec.ts`.
-
-const WARM_ROUTES = ["/", "/news", "/staff", "/shop", "/login", "/register"];
-
-for (const route of WARM_ROUTES) {
-	test(`${route} responds within the warm budget`, async ({ request }) => {
-		await request.get(route); // warm the render + data caches
-		const started = Date.now();
-		const response = await request.get(route);
-		const elapsed = Date.now() - started;
-		expect([200, 304]).toContain(response.status());
-		expect(
-			elapsed,
-			`GET ${route} took ${elapsed}ms (budget ${BUDGET_MS}ms)`,
-		).toBeLessThan(BUDGET_MS);
-	});
-}
-
 test("anonymous content pages advertise a shared cache", async ({
 	request,
 }) => {

e2e/quality/content-health.spec.ts

@@ -3,13 +3,16 @@ import {
 	expectNoApplicationError,
 	expectNoBrokenImages,
 	expectNoHorizontalOverflow,
+	isMaintenanceRedirect,
 	scrollThroughPage,
-} from "./helpers";
+} from "../helpers";
 
-// Read-only smoke coverage for the anonymous-facing pages: each must return a
+// ADVISORY suite — run with `pnpm test:e2e:quality`, not part of the deploy
-// real document, render without an error boundary, and load every image. This
+// gate. These checks depend on live content/upload state and user data (a
-// is where a missing upload, a bad avatar figure or a broken theme asset shows
+// missing upload, a legacy malformed avatar figure, a bad theme asset), so
-// up — none of which the unit suite can catch.
+// they are informational: they tell you the site has a real content problem,
+// but they must never block a code deploy. Every assertion the CMS can
+// guarantee on its own lives in the blocking specs instead.
 const PUBLIC_ROUTES = [
 	"/",
 	"/news",
@@ -22,9 +25,7 @@ const PUBLIC_ROUTES = [
 ] as const;
 
 for (const route of PUBLIC_ROUTES) {
-	test(`${route} renders, loads its images and does not overflow`, async ({
+	test(`${route} loads every image and does not overflow`, async ({ page }) => {
-		page,
-	}) => {
 		const response = await page.goto(route);
 		expect(response?.ok(), `GET ${route} -> ${response?.status()}`).toBe(true);
 
@@ -37,6 +38,17 @@ for (const route of PUBLIC_ROUTES) {
 	});
 }
 
+test("the register page loads its theme/avatar images", async ({ page }) => {
+	const response = await page.goto("/register");
+	test.skip(
+		isMaintenanceRedirect(page.url()) || response?.status() === 404,
+		"register is not reachable on this deploy",
+	);
+	await scrollThroughPage(page);
+	await expectNoBrokenImages(page);
+	await expectNoHorizontalOverflow(page);
+});
+
 test("the homepage stays usable on a narrow viewport", async ({ page }) => {
 	await page.setViewportSize({ width: 390, height: 844 });
 	const response = await page.goto("/");

e2e/quality/performance.spec.ts

@@ -0,0 +1,24 @@
+import { expect, test } from "@playwright/test";
+
+// ADVISORY suite — run with `pnpm test:e2e:quality`. Warm-page latency depends
+// on the host, the edge and the shared data caches, so a slow CI hop can trip
+// these budgets without anything being wrong. The cache-control *contract*
+// (deterministic) lives in the blocking `e2e/performance.spec.ts`; only the
+// timing budgets are advisory.
+const BUDGET_MS = Number(process.env.E2E_LOAD_BUDGET_MS || 4000);
+
+const WARM_ROUTES = ["/", "/news", "/staff", "/shop", "/login", "/register"];
+
+for (const route of WARM_ROUTES) {
+	test(`${route} responds within the warm budget`, async ({ request }) => {
+		await request.get(route); // warm the render + data caches
+		const started = Date.now();
+		const response = await request.get(route);
+		const elapsed = Date.now() - started;
+		expect([200, 304]).toContain(response.status());
+		expect(
+			elapsed,
+			`GET ${route} took ${elapsed}ms (budget ${BUDGET_MS}ms)`,
+		).toBeLessThan(BUDGET_MS);
+	});
+}

e2e/register.spec.ts

@@ -1,11 +1,5 @@
 import { expect, test } from "@playwright/test";
-import {
+import { expectNoApplicationError, isMaintenanceRedirect } from "./helpers";
-	expectNoApplicationError,
-	expectNoBrokenImages,
-	expectNoHorizontalOverflow,
-	isMaintenanceRedirect,
-	scrollThroughPage,
-} from "./helpers";
 
 // The register form is the gate for every new player, so it gets a deeper
 // read-only pass than the generic public-page spec. It also pins the captcha
@@ -39,14 +33,6 @@ test.describe("register", () => {
 		await expectNoApplicationError(page);
 	});
 
-	test("loads its theme/avatar images and fits the viewport", async ({
-		page,
-	}) => {
-		await scrollThroughPage(page);
-		await expectNoBrokenImages(page);
-		await expectNoHorizontalOverflow(page);
-	});
-
 	test("exposes exactly one captcha widget with a site key", async ({
 		page,
 	}) => {

package.json

@@ -11,6 +11,8 @@
 		"build": "pnpm assets:editor && bash scripts/with-memory-cap.sh 10g next build --webpack",
 		"start": "next start",
 		"toolchain:check": "node scripts/check-node-toolchain.mjs",
+		"readme:versions": "node scripts/sync-readme-versions.mjs",
+		"readme:versions:check": "node scripts/sync-readme-versions.mjs --check",
 		"lint": "biome check .",
 		"biome:lint": "biome check .",
 		"format": "biome format --write .",
@@ -42,6 +44,7 @@
 		"test:ui:update": "bash scripts/with-memory-cap.sh 8g playwright test --config playwright.ui.config.ts --update-snapshots",
 		"test:imaging": "bash scripts/with-memory-cap.sh 8g playwright test --config playwright.imaging.config.ts",
 		"test:imaging:update": "bash scripts/with-memory-cap.sh 8g playwright test --config playwright.imaging.config.ts --update-snapshots",
+		"test:e2e:quality": "bash scripts/with-memory-cap.sh 8g playwright test --config playwright.quality.config.ts",
 		"performance:report": "node scripts/performance-report.mjs",
 		"test:integration": "bash scripts/with-memory-cap.sh 8g vitest run --config vitest.integration.config.ts"
 	},

playwright.config.ts

@@ -1,7 +1,7 @@
 import { defineConfig, devices } from "@playwright/test";
 export default defineConfig({
 	testDir: "./e2e",
-	testIgnore: ["**/ui/**", "**/news-real/**"],
+	testIgnore: ["**/ui/**", "**/news-real/**", "**/quality/**"],
 	fullyParallel: false,
 	workers: 1,
 	retries: 1,

playwright.quality.config.ts

@@ -0,0 +1,29 @@
+import { defineConfig, devices } from "@playwright/test";
+
+// Advisory quality suite. Unlike the main e2e config (the blocking deploy
+// gate), this checks things that depend on live content and data — broken
+// uploads, legacy malformed avatar figures, warm-page latency. Those are real
+// signals but they are not something a code change can guarantee, so they must
+// never block a deploy. Point it at a running CMS with PLAYWRIGHT_BASE_URL
+// (defaults to the local host port).
+const baseURL = process.env.PLAYWRIGHT_BASE_URL || "http://127.0.0.1:3002";
+
+export default defineConfig({
+	testDir: "./e2e/quality",
+	fullyParallel: false,
+	workers: 1,
+	retries: 1,
+	timeout: 60000,
+	expect: { timeout: 15000 },
+	reporter: [
+		["list"],
+		["html", { outputFolder: "playwright-report/quality", open: "never" }],
+	],
+	outputDir: "test-results/quality",
+	use: {
+		baseURL,
+		trace: "retain-on-failure",
+		screenshot: "only-on-failure",
+	},
+	projects: [{ name: "chromium", use: { ...devices["Desktop Chrome"] } }],
+});

scripts/README.md

@@ -20,6 +20,7 @@ This directory contains utility scripts for managing the EpicNext-Cms project.
 | `perf-report.sh` | Runs performance profiling. |
 | `setup-dev.sh` | Configures development environment. |
 | `check-updates.sh` | Checks for package and image updates. |
+| `sync-readme-versions.mjs` | Syncs the versions in `README.md` with `package.json` / `.nvmrc`. |
 | `maintenance.sh` | Toggles maintenance mode flag. |
 | `doctor.sh` | Runs a system diagnostic report. |
 | `setup-cron.sh` | Configures automated cron jobs. |
@@ -30,3 +31,18 @@ Run any script directly, or use the dashboard:
 ```bash
 ./scripts/dashboard.sh
 ```
+
+### Keeping the README versions in sync
+
+Bumping a dependency (or the pinned Node.js version) leaves `README.md` stale.
+Rather than editing it by hand, run:
+
+```bash
+pnpm readme:versions        # rewrite README.md to match package.json / .nvmrc
+pnpm readme:versions:check  # verify only; exits 1 when out of date (used in CI)
+```
+
+It manages the `pnpm` and `Node.js` rows of the System Requirements table and
+the "Core stack" line. The CI `check` job runs the `--check` variant, so a
+version change cannot reach `main` with a stale README — the pipeline fails
+until you run `pnpm readme:versions`.