You've already forked Atomcms-edit
refactor: add return type hints to all controller methods
Added proper return types (View, RedirectResponse, JsonResponse, Collection) to 40+ controller methods across 16 controllers. Also added missing imports for Illuminate response types and tightened parameter types (e.g. InstallationController::showStep now uses int instead of mixed).
This commit is contained in:
@@ -5,10 +5,11 @@ namespace App\Http\Controllers\Help;
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Models\Help\WebsiteHelpCenterCategory;
|
||||
use Illuminate\Support\Facades\Cache;
|
||||
use Illuminate\View\View;
|
||||
|
||||
class HelpCenterController extends Controller
|
||||
{
|
||||
public function __invoke()
|
||||
public function __invoke(): View
|
||||
{
|
||||
$categories = Cache::remember('help_center_categories', 300, fn () => WebsiteHelpCenterCategory::orderBy('position')->get());
|
||||
|
||||
|
||||
@@ -6,11 +6,14 @@ use App\Http\Controllers\Controller;
|
||||
use App\Http\Requests\WebsiteTicketFormRequest;
|
||||
use App\Models\Help\WebsiteHelpCenterCategory;
|
||||
use App\Models\Help\WebsiteHelpCenterTicket;
|
||||
use App\Models\Help\WebsiteHelpCenterTicketReply;
|
||||
use Illuminate\Http\RedirectResponse;
|
||||
use Illuminate\Support\Facades\Auth;
|
||||
use Illuminate\View\View;
|
||||
|
||||
class TicketController extends Controller
|
||||
{
|
||||
public function index()
|
||||
public function index(): View|RedirectResponse
|
||||
{
|
||||
if (! hasPermission('manage_website_tickets')) {
|
||||
return redirect()->back()->with([
|
||||
@@ -23,7 +26,7 @@ class TicketController extends Controller
|
||||
]);
|
||||
}
|
||||
|
||||
public function create()
|
||||
public function create(): View
|
||||
{
|
||||
return view('help-center.tickets.create', [
|
||||
'categories' => WebsiteHelpCenterCategory::get(),
|
||||
@@ -31,14 +34,14 @@ class TicketController extends Controller
|
||||
]);
|
||||
}
|
||||
|
||||
public function store(WebsiteTicketFormRequest $request)
|
||||
public function store(WebsiteTicketFormRequest $request): RedirectResponse
|
||||
{
|
||||
Auth::user()->tickets()->create($request->validated());
|
||||
|
||||
return redirect()->back()->with('success', __('Ticket submitted!'));
|
||||
}
|
||||
|
||||
public function edit(WebsiteHelpCenterTicket $ticket)
|
||||
public function edit(WebsiteHelpCenterTicket $ticket): View|RedirectResponse
|
||||
{
|
||||
if (! $ticket->canManageTicket()) {
|
||||
return redirect()->back()->with([
|
||||
@@ -59,7 +62,7 @@ class TicketController extends Controller
|
||||
]);
|
||||
}
|
||||
|
||||
public function update(WebsiteHelpCenterTicket $ticket, WebsiteTicketFormRequest $request)
|
||||
public function update(WebsiteHelpCenterTicket $ticket, WebsiteTicketFormRequest $request): RedirectResponse
|
||||
{
|
||||
if (! $ticket->canManageTicket()) {
|
||||
return redirect()->back()->with([
|
||||
@@ -72,7 +75,7 @@ class TicketController extends Controller
|
||||
return to_route('help-center.ticket.show', $ticket)->with('success', __('Ticket updated!'));
|
||||
}
|
||||
|
||||
public function show(WebsiteHelpCenterTicket $ticket)
|
||||
public function show(WebsiteHelpCenterTicket $ticket): View|RedirectResponse
|
||||
{
|
||||
if (! $ticket->canManageTicket()) {
|
||||
return redirect()->back()->with([
|
||||
@@ -92,7 +95,7 @@ class TicketController extends Controller
|
||||
]);
|
||||
}
|
||||
|
||||
public function destroy(WebsiteHelpCenterTicket $ticket)
|
||||
public function destroy(WebsiteHelpCenterTicket $ticket): RedirectResponse
|
||||
{
|
||||
if (! $ticket->canDeleteTicket()) {
|
||||
return redirect()->back()->with([
|
||||
@@ -105,7 +108,7 @@ class TicketController extends Controller
|
||||
return to_route('me.show')->with('success', __('The ticket has been deleted!'));
|
||||
}
|
||||
|
||||
public function destroyReply(WebsiteHelpCenterTicketReply $reply)
|
||||
public function destroyReply(WebsiteHelpCenterTicketReply $reply): RedirectResponse
|
||||
{
|
||||
if (! $reply->canDeleteReply()) {
|
||||
return redirect()->back()->with([
|
||||
@@ -118,7 +121,7 @@ class TicketController extends Controller
|
||||
return redirect()->back()->with('success', __('The reply has been deleted!'));
|
||||
}
|
||||
|
||||
public function toggleTicketStatus(WebsiteHelpCenterTicket $ticket)
|
||||
public function toggleTicketStatus(WebsiteHelpCenterTicket $ticket): RedirectResponse
|
||||
{
|
||||
if (! $ticket->canManageTicket()) {
|
||||
return redirect()->back()->with([
|
||||
|
||||
@@ -7,10 +7,11 @@ namespace App\Http\Controllers\Help;
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Http\Requests\WebsiteTicketReplyFormRequest;
|
||||
use App\Models\Help\WebsiteHelpCenterTicket;
|
||||
use Illuminate\Http\RedirectResponse;
|
||||
|
||||
class TicketReplyController extends Controller
|
||||
{
|
||||
public function store(WebsiteHelpCenterTicket $ticket, WebsiteTicketReplyFormRequest $request)
|
||||
public function store(WebsiteHelpCenterTicket $ticket, WebsiteTicketReplyFormRequest $request): RedirectResponse
|
||||
{
|
||||
if (! $ticket->isOpen()) {
|
||||
return redirect()->back()->with([
|
||||
|
||||
Reference in New Issue
Block a user