You've already forked Atomcms-edit
Optimize queries: fix N+1, SELECT *, and missing eager loading
N+1 fixes:
- Add withCount('furniture') to rare categories sidebar (prevents N queries)
- Add tags and user.permission eager load in ArticleController
- Add rooms and photos.user eager load in ProfileController
- Add user eager load in MediaApiController (API was returning null user data)
SELECT * fixes:
- Replace WebsitePermission::all()->pluck() with direct pluck()
- Replace WebsiteHousekeepingPermission::all()->pluck() with direct pluck()
- Add select(['id', 'public_name']) to ItemBase query in furniItems()
- Add select(['id', 'name']) to help categories query
- Add select(['id', 'name', 'code']) to languages query
Memory/performance:
- Replace full collection load with aggregate queries in getRareStatistics()
- Add limit(50) to open tickets query in TicketController
This commit is contained in:
@@ -17,6 +17,7 @@ class MediaApiController extends Controller
|
||||
$photos = CameraWeb::query()
|
||||
->where('visible', true)
|
||||
->latest('id')
|
||||
->with('user:id,username,look')
|
||||
->paginate(12);
|
||||
|
||||
return response()->json([
|
||||
|
||||
@@ -29,7 +29,7 @@ class ArticleController extends Controller
|
||||
|
||||
public function show(WebsiteArticle $article): View
|
||||
{
|
||||
$article->load(['user:id,username,look', 'comments.user:id,username,look']);
|
||||
$article->load(['user:id,username,look', 'user.permission:id,rank_name', 'comments.user:id,username,look', 'tags']);
|
||||
|
||||
$reactions = $article->reactions()
|
||||
->with('user:id,username')
|
||||
|
||||
@@ -29,14 +29,14 @@ class TicketController extends Controller
|
||||
|
||||
private function getCachedCategories(): \Illuminate\Database\Eloquent\Collection
|
||||
{
|
||||
return Cache::remember('help_categories', 3600, fn () => WebsiteHelpCenterCategory::get());
|
||||
return Cache::remember('help_categories', 3600, fn () => WebsiteHelpCenterCategory::get(['id', 'name']));
|
||||
}
|
||||
|
||||
public function create(): View
|
||||
{
|
||||
return view('help-center.tickets.create', [
|
||||
'categories' => $this->getCachedCategories(),
|
||||
'openTickets' => WebsiteHelpCenterTicket::where('open', true)->where('user_id', Auth::id())->get(),
|
||||
'openTickets' => WebsiteHelpCenterTicket::where('open', true)->where('user_id', Auth::id())->limit(50)->get(),
|
||||
]);
|
||||
}
|
||||
|
||||
|
||||
@@ -16,7 +16,8 @@ class ProfileController extends Controller
|
||||
'friends.friend:id,username,look',
|
||||
'guilds.guild:id,name,badge',
|
||||
'profileGuestbook.user:id,username,look',
|
||||
'photos',
|
||||
'photos.user:id,username,look',
|
||||
'rooms',
|
||||
'badges',
|
||||
]);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user