Medium priority fixes: CORS from env, shared HasRadioSettings trait, lazy RconService, validated() fixes, LogoGenerator hardening, DB indexes, user profile consistency, radio rank N+1 fix

2026-06-04 20:05:36 +02:00
parent 4b6872e5e0
commit b2bb1811d0
11 changed files with 140 additions and 56 deletions
@@ -227,15 +227,21 @@ class HotelApiController extends Controller
    public function userProfile(string $username): JsonResponse
    {
        $user = User::where('username', $username)
-            ->firstOrFail();
+            ->first();
+
+        if (! $user) {
+            return response()->json(['data' => null], 404);
+        }

        return response()->json([
-            'id' => $user->id,
-            'username' => $user->username,
-            'look' => $user->look,
-            'motto' => $user->motto,
-            'account_created' => $user->account_created,
-            'online' => false,
+            'data' => [
+                'id' => $user->id,
+                'username' => $user->username,
+                'look' => $user->look,
+                'motto' => $user->motto,
+                'account_created' => $user->account_created,
+                'online' => false,
+            ],
        ]);
    }

@@ -290,9 +296,11 @@ class HotelApiController extends Controller
            ->where('user_id', $request->user()->id)
            ->firstOrFail();

+        $validated = $request->validated();
+
        $reply = $ticket->replies()->create([
            'user_id' => $request->user()->id,
-            'message' => $request->input('message'),
+            'message' => $validated['message'],
        ]);

        return response()->json(['data' => $reply->load('user:id,username,look')], 201);