Fix security, performance, and code quality issues across CMS

Security:
- Replace unescaped {!! !!} with Purify::clean() in 15+ Blade templates (XSS)
- Add rate limiting to register (3/hr), upload (10/min), SSE (6/min)
- Add max:5000 validation on article comments
- Remove duplicate exception handler callback

Hardcoded paths:
- Replace ~44 /var/www/ hardcoded paths with env() configs
- CatalogService (13), AutoDetectService (18), Commandocentrum (11), AppServiceProvider (2)

Performance:
- Add 10 missing database indexes (radio_song_requests, help_center_tickets, etc.)
- Replace Cache::flush() with targeted Cache::forget() in RadioSettings
- Cache getCachedCategories() in TicketController (N+1 fix)
- Remove redundant top-3 leaderboard query

Bug fixes:
- Fix undefined $enabled variable → $isOnline in radio index view
- Add getAvatarAttribute() accessor for non-existent avatar column
- Fix User::guilds() from wrong HasMany to HasManyThrough

Code quality:
- Replace file_get_contents with Http::timeout(10) in TraxService
- Remove commented Echo/Pusher boilerplate in bootstrap.js
- Remove TODO/FIXME comments from logo-generator templates
- Replace hardcoded Turnstile CDN URL with config()
- Restore QUEUE_CONNECTION=redis in .env.example files
This commit is contained in:
root
2026-06-29 18:28:19 +02:00
parent ef0aec4301
commit f29ba72591
30 changed files with 407 additions and 159 deletions
+8 -2
View File
@@ -62,12 +62,15 @@ class RouteServiceProvider extends ServiceProvider
return Limit::perMinute($maxAttempts)->by($key);
});
// Strict rate limit for login attempts (security) - increased for usability
RateLimiter::for('login', fn (Request $request) => Limit::perMinute(20)->by($request->ip()));
// Strict rate limit for registration (prevent spam)
RateLimiter::for('register', fn (Request $request) => Limit::perHour(3)->by($request->ip()));
// Two-factor authentication rate limit
RateLimiter::for('two-factor', fn (Request $request) => Limit::perMinute(15)->by($request->ip()));
// Strict photo upload rate limit
RateLimiter::for('upload', fn (Request $request) => Limit::perMinute(10)->by($request->user()?->id ?? $request->ip()));
// Rate limit for radio endpoints (high traffic)
RateLimiter::for('radio', function (Request $request) {
$key = $request->get('radio_api_key_id')
@@ -76,5 +79,8 @@ class RouteServiceProvider extends ServiceProvider
return Limit::perMinute(120)->by((string) $key);
});
// Rate limit for SSE (long-lived connections - low rate)
RateLimiter::for('sse', fn (Request $request) => Limit::perMinute(6)->by($request->ip()));
}
}