Files
Atomcms-edit/app/Services/SettingsService.php
T
root 1acd96b78a Optimize queries: fix N+1, SELECT *, and missing eager loading
N+1 fixes:
- Add withCount('furniture') to rare categories sidebar (prevents N queries)
- Add tags and user.permission eager load in ArticleController
- Add rooms and photos.user eager load in ProfileController
- Add user eager load in MediaApiController (API was returning null user data)

SELECT * fixes:
- Replace WebsitePermission::all()->pluck() with direct pluck()
- Replace WebsiteHousekeepingPermission::all()->pluck() with direct pluck()
- Add select(['id', 'public_name']) to ItemBase query in furniItems()
- Add select(['id', 'name']) to help categories query
- Add select(['id', 'name', 'code']) to languages query

Memory/performance:
- Replace full collection load with aggregate queries in getRareStatistics()
- Add limit(50) to open tickets query in TicketController
2026-06-29 18:50:32 +02:00

105 lines
2.7 KiB
PHP
Executable File

<?php
declare(strict_types=1);
namespace App\Services;
use App\Models\Miscellaneous\WebsiteLanguage;
use App\Models\Miscellaneous\WebsiteSetting;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Schema;
use Throwable;
class SettingsService
{
private const string CACHE_KEY = 'website_settings';
private const string LANGUAGES_CACHE_KEY = 'website_languages';
private ?Collection $cachedSettings = null;
public function __construct(
private readonly InstallationService $installationService,
) {}
public function getOrDefault(string $key, mixed $default = null): mixed
{
$settings = $this->settings();
return $settings->get($key, $default);
}
public function getLanguages(): Collection
{
return Cache::remember(self::LANGUAGES_CACHE_KEY, 86400, function (): Collection {
try {
if (! Schema::hasTable('website_languages')) {
return collect();
}
return WebsiteLanguage::get(['id', 'name', 'code']);
} catch (Throwable) {
return collect();
}
});
}
public static function clearCache(): void
{
Cache::forget(self::CACHE_KEY);
Cache::forget(self::LANGUAGES_CACHE_KEY);
}
public function clearInstanceCache(): void
{
$this->cachedSettings = null;
Cache::forget(self::CACHE_KEY);
Cache::forget(self::LANGUAGES_CACHE_KEY);
}
public function set(string $key, mixed $value): void
{
WebsiteSetting::updateOrCreate(
['key' => $key],
['value' => is_bool($value) ? ($value ? '1' : '0') : (string) $value],
);
// Clear cache to ensure fresh values are fetched
self::clearCache();
}
private function settings(): Collection
{
if ($this->isInstallationIncomplete()) {
return $this->fetchSettings();
}
$this->cachedSettings = collect(Cache::remember(self::CACHE_KEY, 86400, fn () => $this->fetchSettings()->toArray()));
return $this->cachedSettings;
}
private function isInstallationIncomplete(): bool
{
try {
return ! $this->installationService->isComplete();
} catch (Throwable) {
return true;
}
}
private function fetchSettings(): Collection
{
try {
if (! Schema::hasTable('website_settings')) {
return collect();
}
return WebsiteSetting::query()->pluck('value', 'key');
} catch (Throwable) {
return collect();
}
}
}