fix(housekeeping): make route matching deterministic
This commit is contained in:
1 parent
e5c230ba35
commit
0117b45d74
4 files changed
+256
-45
No files matched your search
@@ -138,3 +138,97 @@ src/features/housekeeping/route-handlers.ts
|
||||
- Mutation check: dynamic-name normalization removal, regex-style static matching, static-priority removal, decoded-separator acceptance, domain mismatch acceptance, skipped route ACL, context reload inside the handler, missing handler lookup, placeholder handler addition, and empty-domain redirect each break a focused test.
|
||||
- The catch-all route imports only housekeeping foundation/manifests/handlers and retains the existing forbidden database/auth/permissions/actions/legacy-page boundary audit.
|
||||
- `apply_patch` created all new files, but the Windows sandbox helper repeatedly failed to read existing files with `apply deny-read ACLs`. Existing-file edits therefore used controller-approved exact-anchor/full-file fallbacks only after resolving absolute paths and validating every target under `E:\Users\simol\Desktop\EpicNext-cms`.
|
||||
|
||||
## Fix Round 1 — deterministic encoded route matching
|
||||
|
||||
### Status and scope
|
||||
|
||||
- Fix base: `e5c230ba35aec2b4c471608d32b8a16ecc1ee382`.
|
||||
- Only the two Important matcher blockers were addressed.
|
||||
- The three parked Minor findings remain unchanged; no changed line required an adjustment to them.
|
||||
- Commit message: `fix(housekeeping): make route matching deterministic`.
|
||||
- `.remember/` remained untouched. No worktree, push, PR/MR, database operation, deployment, or Task 10 work was performed.
|
||||
|
||||
### Root-cause evidence
|
||||
|
||||
1. The catch-all receives decoded Next segments and re-encodes them with `encodeURIComponent`. The matcher decoded the request path into `decodedSegments` but compared static route text against `rawSegments`. Therefore literal `a+b[1]` did not equal `a%2Bb%5B1%5D`; the competing `:id` route captured the request and could change the selected capability/handler.
|
||||
2. Candidate sorting used only total dynamic-segment count. Intersecting patterns `/:kind/settings` and `/users/:id` have the same count, so stable sort preserved manifest order and allowed registration order to decide dispatch.
|
||||
|
||||
### RED
|
||||
|
||||
Exact command after test setup was validated:
|
||||
|
||||
```text
|
||||
pnpm exec vitest run --coverage.enabled=false src/features/housekeeping/foundation/routing/match-route.test.ts src/features/housekeeping/foundation/registry.test.ts src/features/housekeeping/route-handlers.test.ts src/features/housekeeping/foundation/preview-route-contract.test.ts
|
||||
```
|
||||
|
||||
Observed exit 1:
|
||||
|
||||
```text
|
||||
Test Files 2 failed | 2 passed (4)
|
||||
Tests 2 failed | 95 passed (97)
|
||||
|
||||
catch-all encoded literal:
|
||||
Expected routeId people.literal-tool with params {}
|
||||
Received routeId people.tool-detail with params { id: "a+b[1]" }
|
||||
|
||||
equal-count specificity:
|
||||
Expected routeId people.user-detail with params { id: "settings" }
|
||||
Received routeId people.kind-settings with params { kind: "users" }
|
||||
```
|
||||
|
||||
The registration-order table exercises both orders. Before production changes the general-first order failed while the reverse order passed, proving that order was the deciding variable.
|
||||
|
||||
An earlier RED attempt exposed a test-table setup error (`manifest.routes is not iterable`); the table was changed from spread array rows to named `{ routes }` rows, then rerun to obtain the behavioral RED above before any production edit.
|
||||
|
||||
### Fix
|
||||
|
||||
- A single `decodeCanonicalSegment` boundary now normalizes request segments and static route-pattern segments exactly once.
|
||||
- Invalid percent encoding, empty values, decoded `/` or `\`, and decoded `.` / `..` remain fail closed.
|
||||
- Dynamic markers retain their parameter names and receive the already-decoded request segment.
|
||||
- Candidate specificity is compared left-to-right. At the earliest static/dynamic difference, the static segment wins; manifest order no longer selects among intersecting patterns.
|
||||
- Existing static-over-dynamic behavior and registry duplicate-shape rejection remain unchanged.
|
||||
|
||||
### GREEN and pre-commit verification
|
||||
|
||||
Targeted command above, exit 0:
|
||||
|
||||
```text
|
||||
Test Files 4 passed (4)
|
||||
Tests 97 passed (97)
|
||||
```
|
||||
|
||||
Full housekeeping suite, exit 0:
|
||||
|
||||
```text
|
||||
pnpm test:housekeeping
|
||||
Test Files 38 passed (38)
|
||||
Tests 352 passed (352)
|
||||
```
|
||||
|
||||
TypeScript, exit 0:
|
||||
|
||||
```text
|
||||
pnpm typecheck
|
||||
$ tsc --noEmit
|
||||
```
|
||||
|
||||
The only output note remained the existing Node warning: local `26.7.0`, package request `>=26.8.1 <27`.
|
||||
|
||||
Exact changed-file Biome, exit 0:
|
||||
|
||||
```text
|
||||
pnpm exec biome check --formatter-enabled=false src/features/housekeeping/foundation/routing/match-route.ts src/features/housekeeping/foundation/routing/match-route.test.ts src/features/housekeeping/foundation/preview-route-contract.test.ts
|
||||
Checked 3 files in 25ms. No fixes applied.
|
||||
```
|
||||
|
||||
`git diff --check` exited 0 before the report update. Cached and committed-tree checks are final staging/commit gates.
|
||||
|
||||
### Exact fix files
|
||||
|
||||
```text
|
||||
src/features/housekeeping/foundation/routing/match-route.ts
|
||||
src/features/housekeeping/foundation/routing/match-route.test.ts
|
||||
src/features/housekeeping/foundation/preview-route-contract.test.ts
|
||||
.superpowers/sdd/2026-08-26-housekeeping-completion/task-9-report.md
|
||||
```
|
||||
Reference in new issue
Block a user