fix: close housekeeping foundation review findings
CI / check (pull_request) Successful in 28s
CI / release (pull_request) Skipped
CI / deploy (pull_request) Skipped

This commit is contained in:
Simo committed 2026-08-26 19:16:34 +02:00
1 parent ebc263da35
commit 08f8d54888
21 files changed
+593 -46

No files matched your search

@@ -265,6 +265,8 @@ function scanModuleAccesses(source: string): ModuleAccessScan {
}
} else if (value.type === "ImportExpression") {
recordArgument(value.source, "import");
} else if (value.type === "TSImportType") {
recordArgument(value.argument, "import");
} else if (
value.type === "CallExpression" ||
value.type === "OptionalCallExpression"
@@ -445,6 +447,12 @@ describe("housekeeping runtime import boundary", () => {
'import workflow from "../domains/people/workflow";',
"src/features/housekeeping/domains/people/workflow",
],
[
"TypeScript import type database access",
"src/features/housekeeping/foundation/registry.ts",
'type PrismaClient = import("@prisma/client").PrismaClient;',
"@prisma/client",
],
] as const)("detects %s", (_name, sourceFile, source, expectedPath) => {
expect(
findHousekeepingImportBoundaryViolations(source, sourceFile),
@@ -510,7 +518,7 @@ describe("housekeeping runtime import boundary", () => {
'import database from "@/lib/database";',
'import authentication from "@/lib/authentication";',
'import commandKit from "cmdkit";',
'import manifest from "../domains/people/manifest";',
'import manifest from "./domains/people/manifest";',
"const documentation = \"import db from '@/lib/db'\";",
'// import action from "@/actions/users";',
].join("\n");