refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage
Deploy / release (push) Skipped
Deploy / deploy (push) Failing after 8s

- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params)
- Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger)
- Replaced console.warn/error with pino logger in 9 server-side modules
- Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections)
- Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date
- Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries
- Added getMany()/getAll() helpers to SiteSettings service
- Removed 88 dead Prisma model definitions (schema 2763→1846 lines)
- Created admin action-helper.ts with wrapAction() for standardized error handling
- Fixed useEffect dependency arrays in 4 data-heavy components
- Replaced raw btn CSS classes with shadcn Button component across admin pages
- Stripped dead i18n namespaces (common, pages.client) from all 22 translation files
- Removed 2 dead scripts (create-release.sh, check-local-imports.ts)
- Fixed knip.json configuration
- Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking
- All 358 tests passing across 72 test files
- TypeScript: 0 errors
This commit is contained in:
openhands committed 2026-07-25 17:33:06 +02:00
1 parent 12e4a07e48
commit 1acace49d0
150 files changed
+10210 -12272

No files matched your search

+3 -2
View File
@@ -3,6 +3,7 @@ import Link from "next/link";
import { notFound, redirect } from "next/navigation";
import { getTranslations } from "next-intl/server";
import { updateAd } from "@/actions/admin-ads";
import { Button } from "@/components/ui/button";
import { prisma } from "@/lib/prisma";
import { canAccess, getAdminContext, PERMS } from "@/lib/permissions";
import { EditAdDeleteButton } from "../ads-table";
@@ -54,9 +55,9 @@ export default async function EditAd({
required
maxLength={255}
/>
<button type="submit" className="btn btn-primary">
<Button type="submit" variant="default">
{t("form.save")}
</button>
</Button>
</form>
<div style={{ marginTop: "1rem" }}>
<EditAdDeleteButton id={String(ad.id)} />
+8 -6
View File
@@ -4,6 +4,7 @@ import { Trash2 } from "lucide-react";
import Link from "next/link";
import { useTranslations } from "next-intl";
import { deleteAd } from "@/actions/admin-ads";
import { Button } from "@/components/ui/button";
import { useConfirmDialog } from "@/components/admin/confirm-dialog";
import { useServerAction } from "@/hooks/use-server-action";
@@ -64,15 +65,16 @@ export function AdsTable({ ads }: { ads: AdRow[] }) {
<td>
<div className="flex items-center gap-2">
<Link href={`/admin/ads/${ad.id}`}>{t("edit")}</Link>
<button
<Button
type="button"
className="btn btn-danger btn-sm inline-flex items-center gap-1"
variant="destructive"
size="sm"
disabled={isPending}
onClick={() => handleDelete(ad)}
>
<Trash2 className="h-3.5 w-3.5" />
{t("delete")}
</button>
</Button>
</div>
</td>
</tr>
@@ -106,14 +108,14 @@ export function EditAdDeleteButton({ id }: { id: string }) {
return (
<>
{confirmDialog}
<button
<Button
type="button"
className="btn btn-danger"
variant="destructive"
disabled={isPending}
onClick={handleDelete}
>
{t("form.deleteAd")}
</button>
</Button>
</>
);
}
+3 -2
View File
@@ -2,6 +2,7 @@ import { Megaphone } from "lucide-react";
import Link from "next/link";
import { redirect } from "next/navigation";
import { createAd } from "@/actions/admin-ads";
import { Button } from "@/components/ui/button";
import { canAccess, getAdminContext, PERMS } from "@/lib/permissions";
export default async function NewAd() {
@@ -27,9 +28,9 @@ export default async function NewAd() {
</div>
<form action={createAd} className="admin-card">
<input name="image" placeholder="Image URL" required maxLength={255} />
<button type="submit" className="btn btn-primary">
<Button type="submit" variant="default">
Create
</button>
</Button>
</form>
</main>
);
+9 -5
View File
@@ -1,6 +1,8 @@
import Link from "next/link";
import { getTranslations } from "next-intl/server";
import { StatusCard } from "@/components/admin/dashboard";
import { Button } from "@/components/ui/button";
import { formatDate } from "@/lib/format-date";
import { prisma } from "@/lib/prisma";
import { redirect } from "next/navigation";
import { canAccess, getAdminContext, PERMS } from "@/lib/permissions";
@@ -26,15 +28,17 @@ export default async function AdminAds() {
}
const latest = ads[0]?.createdAt
? ads[0].createdAt.toISOString().slice(0, 10)
? formatDate(ads[0].createdAt, "date")
: "—";
return (
<main>
<div className="flex justify-end mb-6">
<Link href="/admin/ads/new" className="btn btn-primary">
+ {t("newAd")}
</Link>
<Button variant="default" asChild>
<Link href="/admin/ads/new">
+ {t("newAd")}
</Link>
</Button>
</div>
<div className="grid grid-cols-[repeat(auto-fit,minmax(180px,1fr))] gap-3.5 mb-6">
@@ -57,7 +61,7 @@ export default async function AdminAds() {
id: String(ad.id),
image: ad.image,
createdAt: ad.createdAt
? ad.createdAt.toISOString().slice(0, 10)
? formatDate(ad.createdAt, "date")
: null,
}))}
/>