refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage
Deploy / release (push) Skipped
Deploy / deploy (push) Failing after 8s

- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params)
- Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger)
- Replaced console.warn/error with pino logger in 9 server-side modules
- Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections)
- Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date
- Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries
- Added getMany()/getAll() helpers to SiteSettings service
- Removed 88 dead Prisma model definitions (schema 2763→1846 lines)
- Created admin action-helper.ts with wrapAction() for standardized error handling
- Fixed useEffect dependency arrays in 4 data-heavy components
- Replaced raw btn CSS classes with shadcn Button component across admin pages
- Stripped dead i18n namespaces (common, pages.client) from all 22 translation files
- Removed 2 dead scripts (create-release.sh, check-local-imports.ts)
- Fixed knip.json configuration
- Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking
- All 358 tests passing across 72 test files
- TypeScript: 0 errors
This commit is contained in:
openhands committed 2026-07-25 17:33:06 +02:00
1 parent 12e4a07e48
commit 1acace49d0
150 files changed
+10210 -12272

No files matched your search

@@ -19,6 +19,7 @@ import {
updateNavigator,
updateWordFilter,
} from "@/actions/commandocentrum";
import { Button } from "@/components/ui/button";
import { useServerAction } from "@/hooks/use-server-action";
const RCON_ERROR = "RCON command failed. Is the emulator running?";
@@ -56,9 +57,9 @@ export function CommandocentrumControls() {
<p className="text-xs text-[var(--admin-text-muted)] mb-4">
{t("updateCatalogDesc")}
</p>
<button
<Button
type="button"
className="btn btn-primary"
variant="default"
disabled={isPending}
onClick={() =>
run(() => updateCatalog(), {
@@ -68,7 +69,7 @@ export function CommandocentrumControls() {
}
>
{t("updateCatalog")}
</button>
</Button>
</div>
<div className="admin-card">
@@ -78,9 +79,9 @@ export function CommandocentrumControls() {
<p className="text-xs text-[var(--admin-text-muted)] mb-4">
{t("updateWordFilterDesc")}
</p>
<button
<Button
type="button"
className="btn btn-primary"
variant="default"
disabled={isPending}
onClick={() =>
run(() => updateWordFilter(), {
@@ -90,7 +91,7 @@ export function CommandocentrumControls() {
}
>
{t("updateWordFilter")}
</button>
</Button>
</div>
<div className="admin-card">
@@ -100,9 +101,9 @@ export function CommandocentrumControls() {
<p className="text-xs text-[var(--admin-text-muted)] mb-4">
{t("updateNavigatorDesc")}
</p>
<button
<Button
type="button"
className="btn btn-primary"
variant="default"
disabled={isPending}
onClick={() =>
run(() => updateNavigator(), {
@@ -112,7 +113,7 @@ export function CommandocentrumControls() {
}
>
{t("updateNavigator")}
</button>
</Button>
</div>
</div>
@@ -133,9 +134,9 @@ export function CommandocentrumControls() {
className="flex-1 min-w-[220px]"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-danger"
variant="destructive"
disabled={isPending || !hotelMessage.trim()}
onClick={() =>
run(() => hotelAlert({ message: hotelMessage }), {
@@ -146,7 +147,7 @@ export function CommandocentrumControls() {
}
>
{t("sendAlert")}
</button>
</Button>
</div>
</div>
</section>
@@ -187,9 +188,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-danger w-full"
variant="destructive" className="w-full"
disabled={
isPending ||
!disconnect.userId ||
@@ -212,7 +213,7 @@ export function CommandocentrumControls() {
}
>
{t("actions.disconnect")}
</button>
</Button>
</div>
</div>
@@ -246,9 +247,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={
isPending || !alert.userId || !alert.message.trim()
}
@@ -268,7 +269,7 @@ export function CommandocentrumControls() {
}
>
{t("actions.alert")}
</button>
</Button>
</div>
</div>
@@ -302,9 +303,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !forward.userId || !forward.roomId}
onClick={() =>
run(
@@ -323,7 +324,7 @@ export function CommandocentrumControls() {
}
>
{t("forwardUser")}
</button>
</Button>
</div>
</div>
</div>
@@ -359,9 +360,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !credits.userId || !credits.credits}
onClick={() =>
run(
@@ -380,7 +381,7 @@ export function CommandocentrumControls() {
}
>
{t("giveCredits")}
</button>
</Button>
</div>
</div>
@@ -414,9 +415,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !duckets.userId || !duckets.amount}
onClick={() =>
run(
@@ -435,7 +436,7 @@ export function CommandocentrumControls() {
}
>
{t("giveDuckets")}
</button>
</Button>
</div>
</div>
@@ -469,9 +470,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !diamonds.userId || !diamonds.amount}
onClick={() =>
run(
@@ -490,7 +491,7 @@ export function CommandocentrumControls() {
}
>
{t("giveDiamonds")}
</button>
</Button>
</div>
</div>
</div>
@@ -526,9 +527,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !badge.userId || !badge.badge.trim()}
onClick={() =>
run(
@@ -546,7 +547,7 @@ export function CommandocentrumControls() {
}
>
{t("giveBadge")}
</button>
</Button>
</div>
</div>
@@ -580,9 +581,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !motto.userId || !motto.motto.trim()}
onClick={() =>
run(
@@ -601,7 +602,7 @@ export function CommandocentrumControls() {
}
>
{t("setMotto")}
</button>
</Button>
</div>
</div>
@@ -636,9 +637,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !rank.userId || rank.rank === ""}
onClick={() =>
run(
@@ -656,7 +657,7 @@ export function CommandocentrumControls() {
}
>
{t("setRank")}
</button>
</Button>
</div>
</div>
</div>
@@ -692,9 +693,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={
isPending || !command.userId || !command.command.trim()
}
@@ -715,7 +716,7 @@ export function CommandocentrumControls() {
}
>
{t("execute")}
</button>
</Button>
</div>
</div>
@@ -760,9 +761,9 @@ export function CommandocentrumControls() {
className="w-full"
disabled={isPending}
/>
<button
<Button
type="button"
className="btn btn-primary w-full"
variant="default" className="w-full"
disabled={isPending || !gift.userId || !gift.itemId}
onClick={() =>
run(
@@ -786,7 +787,7 @@ export function CommandocentrumControls() {
}
>
{t("sendGift")}
</button>
</Button>
</div>
</div>
</div>
+3 -11
View File
@@ -9,21 +9,13 @@ import {
} from "@/components/admin/dashboard";
import { canAccess, getAdminContext, PERMS } from "@/lib/permissions";
import { prisma } from "@/lib/prisma";
import { formatDate } from "@/lib/format-date";
import { rcon } from "@/lib/services/rcon";
import { siteSettings } from "@/lib/services/site-settings";
import { CommandocentrumControls } from "./commandocentrum-controls";
export const dynamic = "force-dynamic";
function formatTimestamp(ts: number | null | undefined): string {
if (!ts) return "";
return new Date(ts * 1000).toISOString().slice(0, 19).replace("T", " ");
}
function fromDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 19).replace("T", " ") : "—";
}
function decodeStacktrace(raw: unknown): string {
if (raw == null) return "";
try {
@@ -229,7 +221,7 @@ export default async function CommandoCentrum() {
{activity.map((a) => (
<tr key={String(a.id)}>
<td className="text-sm theme-text-muted dark:theme-text-muted whitespace-nowrap">
{fromDate(a.createdAt)}
{formatDate(a.createdAt, "datetime-seconds")}
</td>
<td>{nameById.get(Number(a.userId)) ?? `#${a.userId}`}</td>
<td>
@@ -276,7 +268,7 @@ export default async function CommandoCentrum() {
return (
<tr key={e.id}>
<td className="text-sm theme-text-muted dark:theme-text-muted whitespace-nowrap">
{formatTimestamp(e.timestamp)}
{formatDate(e.timestamp ? new Date(e.timestamp * 1000) : null, "datetime-seconds")}
</td>
<td>{e.type}</td>
<td className="text-sm theme-text-muted dark:theme-text-muted whitespace-nowrap">