refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage

- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params)
- Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger)
- Replaced console.warn/error with pino logger in 9 server-side modules
- Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections)
- Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date
- Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries
- Added getMany()/getAll() helpers to SiteSettings service
- Removed 88 dead Prisma model definitions (schema 2763→1846 lines)
- Created admin action-helper.ts with wrapAction() for standardized error handling
- Fixed useEffect dependency arrays in 4 data-heavy components
- Replaced raw btn CSS classes with shadcn Button component across admin pages
- Stripped dead i18n namespaces (common, pages.client) from all 22 translation files
- Removed 2 dead scripts (create-release.sh, check-local-imports.ts)
- Fixed knip.json configuration
- Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking
- All 358 tests passing across 72 test files
- TypeScript: 0 errors

src/app/api/radio/auto-play/route.ts

@@ -3,36 +3,22 @@
 // writes), falling back to the legacy radio_autoplay alias if present. Booleans
 // are stored as the strings '1' / '0'. Returns { autoplay: boolean }.
 import { apiJson } from "@/lib/api";
-import { prisma } from "@/lib/prisma";
+import { siteSettings } from "@/lib/services/site-settings";
 
 export const dynamic = "force-dynamic";
 
-const AUTOPLAY_KEYS = ["radio_auto_play", "radio_autoplay"];
-
-function truthy(value: string | undefined): boolean {
-	if (value === undefined) return false;
+function truthy(value: string | null | undefined): boolean {
+	if (value === undefined || value === null) return false;
 	const s = value.trim().toLowerCase();
 	return s === "1" || s === "true";
 }
 
 export async function GET(_req: Request) {
 	try {
-		const rows = await prisma.websiteSetting.findMany({
-			where: { key: { in: AUTOPLAY_KEYS } },
-			select: { key: true, value: true },
-		});
-
-		const map: Record<string, string> = {};
-		for (const row of rows) {
-			map[row.key] = row.value;
-		}
-
-		// Prefer the canonical key the settings page uses; fall back to the alias.
-		const autoplay = truthy(map.radio_auto_play ?? map.radio_autoplay);
-
+		const values = await siteSettings.getMany(["radio_auto_play", "radio_autoplay"]);
+		const autoplay = truthy(values.radio_auto_play ?? values.radio_autoplay);
 		return apiJson({ autoplay });
 	} catch {
-		// DB unavailable — default to no autoplay rather than a 500.
 		return apiJson({ autoplay: false }, { status: 200 });
 	}
 }

src/app/api/radio/config/route.ts

@@ -1,15 +1,12 @@
 import { apiJson } from "@/lib/api";
-import { prisma } from "@/lib/prisma";
-import { redisCache, apiCacheKey } from "@/lib/redis-cache";
+import { siteSettings } from "@/lib/services/site-settings";
 
 // Radio player config: the subset of radio_* website_settings the front-end
 // player needs (stream URL, name, autoplay, enabled, widget visibility) as a
 // flat { key: value } map. No secrets live among these keys.
 export const dynamic = "force-dynamic";
 
-// radio_* keys relevant to the public player widget. Mirrors what the AtomCMS
-// radio-player blade requests from /api/radio/config.
-const CONFIG_KEYS = new Set([
+const CONFIG_KEYS = [
 	"radio_enabled",
 	"radio_name",
 	"radio_stream_url",
@@ -24,25 +21,15 @@ const CONFIG_KEYS = new Set([
 	"radio_widget_enabled",
 	"radio_widget_show_globally",
 	"radio_widget_position",
-]);
+];
 
 export async function GET(_req: Request) {
 	try {
-		const config = await redisCache(
-			apiCacheKey("radio:config"),
-			30,
-			async () => {
-				const rows = await prisma.websiteSetting.findMany({
-					where: { key: { in: Array.from(CONFIG_KEYS) } },
-					select: { key: true, value: true },
-				});
-				const result: Record<string, string> = {};
-				for (const row of rows) {
-					result[row.key] = row.value;
-				}
-				return result;
-			},
-		);
+		const values = await siteSettings.getMany(CONFIG_KEYS);
+		const config: Record<string, string> = {};
+		for (const [key, val] of Object.entries(values)) {
+			if (val !== null) config[key] = val;
+		}
 		return apiJson(config);
 	} catch {
 		return apiJson({}, { status: 200 });

src/app/api/radio/embed-config/route.ts

@@ -1,5 +1,5 @@
 import { apiJson } from "@/lib/api";
-import { prisma } from "@/lib/prisma";
+import { siteSettings } from "@/lib/services/site-settings";
 
 // Minimal radio_* settings an external page needs to embed the player: stream
 // URL, display name, whether the radio is enabled, and autoplay. Returned as a
@@ -15,19 +15,13 @@ const EMBED_KEYS = [
 
 export async function GET(_req: Request) {
 	try {
-		const rows = await prisma.websiteSetting.findMany({
-			where: { key: { in: EMBED_KEYS } },
-			select: { key: true, value: true },
-		});
-
+		const values = await siteSettings.getMany(EMBED_KEYS);
 		const config: Record<string, string> = {};
-		for (const row of rows) {
-			config[row.key] = row.value;
+		for (const [key, val] of Object.entries(values)) {
+			if (val !== null) config[key] = val;
 		}
-
 		return apiJson(config);
 	} catch {
-		// DB unavailable — serve an empty config rather than a 500.
 		return apiJson({}, { status: 200 });
 	}
 }

src/app/api/settings/route.ts

@@ -1,5 +1,5 @@
 import { apiJson } from "@/lib/api";
-import { prisma } from "@/lib/prisma";
+import { siteSettings } from "@/lib/services/site-settings";
 
 // Public website settings as a flat { key: value } map. Secrets are stripped so
 // this can be served to the game client / external integrations.
@@ -16,19 +16,13 @@ function isSensitive(key: string): boolean {
 
 export async function GET(_req: Request) {
 	try {
-		const rows = await prisma.websiteSetting.findMany({
-			select: { key: true, value: true },
-		});
-
+		const map = await siteSettings.getAll();
 		const settings: Record<string, string> = {};
-		for (const row of rows) {
-			if (isSensitive(row.key)) continue;
-			settings[row.key] = row.value;
+		for (const [key, value] of map) {
+			if (!isSensitive(key)) settings[key] = value;
 		}
-
 		return apiJson(settings);
 	} catch {
-		// DB unavailable — serve an empty settings map rather than a 500.
 		return apiJson({}, { status: 200 });
 	}
 }