refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage
Deploy / release (push) Skipped
Deploy / deploy (push) Failing after 8s

- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params)
- Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger)
- Replaced console.warn/error with pino logger in 9 server-side modules
- Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections)
- Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date
- Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries
- Added getMany()/getAll() helpers to SiteSettings service
- Removed 88 dead Prisma model definitions (schema 2763→1846 lines)
- Created admin action-helper.ts with wrapAction() for standardized error handling
- Fixed useEffect dependency arrays in 4 data-heavy components
- Replaced raw btn CSS classes with shadcn Button component across admin pages
- Stripped dead i18n namespaces (common, pages.client) from all 22 translation files
- Removed 2 dead scripts (create-release.sh, check-local-imports.ts)
- Fixed knip.json configuration
- Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking
- All 358 tests passing across 72 test files
- TypeScript: 0 errors
This commit is contained in:
openhands committed 2026-07-25 17:33:06 +02:00
1 parent 12e4a07e48
commit 1acace49d0
150 files changed
+10210 -12272

No files matched your search

@@ -144,7 +144,7 @@ export function InlineEditor({ pageId, onSaved }: InlineEditorProps) {
}
document.addEventListener("keydown", onKeyDown);
return () => document.removeEventListener("keydown", onKeyDown);
}); // eslint-disable-line react-hooks/exhaustive-deps
}, [canEdit, isDirty, saving, page, handleSave]);
const loadPage = useCallback(
async (id: number) => {
@@ -177,7 +177,6 @@ export function SortableTree({
const loadFullTree = loadTabTree;
// Load tab children when active root changes (same as Catalog Structure expand)
// biome-ignore lint/correctness/useExhaustiveDependencies: explicitly chosen here, see surrounding code
useEffect(() => {
if (activeTabId === null) return;
setSearchQuery("");
@@ -185,7 +184,7 @@ export function SortableTree({
setFilter("all");
dispatch({ type: "COLLAPSE_ALL" });
void loadTabTree();
}, [activeTabId]); // eslint-disable-line react-hooks/exhaustive-deps
}, [activeTabId, loadTabTree]);
// Debounced search
useEffect(() => {
@@ -314,7 +313,6 @@ export function SortableTree({
});
// Auto-scroll to selected page
// biome-ignore lint/correctness/useExhaustiveDependencies: explicitly chosen here, see surrounding code
useEffect(() => {
if (!selectedPageId) return;
const idx = flatIds.indexOf(selectedPageId);
@@ -324,9 +322,10 @@ export function SortableTree({
virtualizer.scrollToIndex(idx, { align: "center" }),
);
}
}, [selectedPageId]); // eslint-disable-line react-hooks/exhaustive-deps
}, [selectedPageId, flatIds, virtualizer]);
// ── Keyboard navigation ─────────────────────────────────────
const handleDeleteRef = useRef<(id: number) => Promise<void>>(async () => {});
// biome-ignore lint/correctness/useExhaustiveDependencies: explicitly chosen here, see surrounding code
useEffect(() => {
function onKeyDown(e: KeyboardEvent) {
@@ -388,7 +387,7 @@ export function SortableTree({
dispatch({ type: "TOGGLE_MULTI_SELECT", id: focusedId });
} else if (e.key === "Delete" && focusedId) {
e.preventDefault();
handleDelete(focusedId);
handleDeleteRef.current(focusedId);
}
}
document.addEventListener("keydown", onKeyDown);
@@ -403,7 +402,7 @@ export function SortableTree({
dispatch,
onSelectPage,
handleToggleExpand,
]); // eslint-disable-line react-hooks/exhaustive-deps
]);
// ── Selection with Ctrl/Shift ───────────────────────────────
const handleSelect = useCallback(
@@ -587,6 +586,7 @@ export function SortableTree({
toast.error("Failed to delete page");
}
};
handleDeleteRef.current = handleDelete;
const handleDuplicate = async (id: number) => {
if (!canEdit) return;