refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage

- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params)
- Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger)
- Replaced console.warn/error with pino logger in 9 server-side modules
- Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections)
- Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date
- Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries
- Added getMany()/getAll() helpers to SiteSettings service
- Removed 88 dead Prisma model definitions (schema 2763→1846 lines)
- Created admin action-helper.ts with wrapAction() for standardized error handling
- Fixed useEffect dependency arrays in 4 data-heavy components
- Replaced raw btn CSS classes with shadcn Button component across admin pages
- Stripped dead i18n namespaces (common, pages.client) from all 22 translation files
- Removed 2 dead scripts (create-release.sh, check-local-imports.ts)
- Fixed knip.json configuration
- Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking
- All 358 tests passing across 72 test files
- TypeScript: 0 errors

src/components/admin/catalog-tree.tsx

@@ -229,7 +229,7 @@ export function CatalogTree({
 		return () => {
 			if (searchTimeout.current) clearTimeout(searchTimeout.current);
 		};
-	}, [searchQuery]);
+	}, [searchQuery, catalogType]);
 
 	// Quick actions from context menu
 	const catParam = catalogType === "bc" ? "&catalog=bc" : "";
@@ -540,33 +540,6 @@ function TreeItem({
 	const [loaded, setLoaded] = useState(false);
 	const hasChildren = node.childCount > 0;
 
-	// Auto-expand root level on mount
-	// biome-ignore lint/correctness/useExhaustiveDependencies: explicitly chosen here, see surrounding code
-	useEffect(() => {
-		if (defaultExpanded && level === 0 && hasChildren && !loaded) {
-			loadChildren().then(() => setExpanded(true));
-		}
-	}, []);
-
-	// Expand all signal
-	// biome-ignore lint/correctness/useExhaustiveDependencies: explicitly chosen here, see surrounding code
-	useEffect(() => {
-		if (expandSignal > 0 && hasChildren) {
-			if (!loaded) {
-				loadChildren().then(() => setExpanded(true));
-			} else {
-				setExpanded(true);
-			}
-		}
-	}, [expandSignal]);
-
-	// Collapse all signal
-	useEffect(() => {
-		if (collapseSignal > 0) {
-			setExpanded(false);
-		}
-	}, [collapseSignal]);
-
 	const loadChildren = useCallback(async () => {
 		if (loaded || !hasChildren) return;
 		setLoading(true);
@@ -587,6 +560,31 @@ function TreeItem({
 		}
 	}, [node.id, loaded, hasChildren, catalogType]);
 
+	// Auto-expand root level on mount
+	useEffect(() => {
+		if (defaultExpanded && level === 0 && hasChildren && !loaded) {
+			loadChildren().then(() => setExpanded(true));
+		}
+	}, [defaultExpanded, level, hasChildren, loaded, loadChildren]);
+
+	// Expand all signal
+	useEffect(() => {
+		if (expandSignal > 0 && hasChildren) {
+			if (!loaded) {
+				loadChildren().then(() => setExpanded(true));
+			} else {
+				setExpanded(true);
+			}
+		}
+	}, [expandSignal, hasChildren, loaded, loadChildren]);
+
+	// Collapse all signal
+	useEffect(() => {
+		if (collapseSignal > 0) {
+			setExpanded(false);
+		}
+	}, [collapseSignal]);
+
 	const handleToggle = () => {
 		if (!expanded && !loaded) {
 			loadChildren().then(() => setExpanded(true));