refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage
- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params) - Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger) - Replaced console.warn/error with pino logger in 9 server-side modules - Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections) - Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date - Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries - Added getMany()/getAll() helpers to SiteSettings service - Removed 88 dead Prisma model definitions (schema 2763→1846 lines) - Created admin action-helper.ts with wrapAction() for standardized error handling - Fixed useEffect dependency arrays in 4 data-heavy components - Replaced raw btn CSS classes with shadcn Button component across admin pages - Stripped dead i18n namespaces (common, pages.client) from all 22 translation files - Removed 2 dead scripts (create-release.sh, check-local-imports.ts) - Fixed knip.json configuration - Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking - All 358 tests passing across 72 test files - TypeScript: 0 errors
This commit is contained in:
1 parent
12e4a07e48
commit
1acace49d0
150 files changed
+10210
-12272
No files matched your search
@@ -0,0 +1,42 @@
|
||||
import { describe, expect, it, vi, beforeEach } from "vitest";
|
||||
|
||||
const mockError = vi.hoisted(() => vi.fn());
|
||||
|
||||
vi.mock("@/lib/logger", () => ({
|
||||
logger: { error: mockError },
|
||||
}));
|
||||
|
||||
import { wrapAction, actionError } from "./action-helper";
|
||||
|
||||
beforeEach(() => {
|
||||
mockError.mockReset();
|
||||
});
|
||||
|
||||
describe("wrapAction", () => {
|
||||
it("returns success with data when fn resolves", async () => {
|
||||
const result = await wrapAction(async () => "hello", "testAction");
|
||||
expect(result).toEqual({ success: true, data: "hello" });
|
||||
});
|
||||
|
||||
it("returns failure and logs when fn throws", async () => {
|
||||
const result = await wrapAction(async () => {
|
||||
throw new Error("boom");
|
||||
}, "testAction");
|
||||
expect(result).toEqual({ success: false, error: "boom" });
|
||||
expect(mockError).toHaveBeenCalledWith("Action failed: testAction", {
|
||||
action: "testAction",
|
||||
error: "boom",
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe("actionError", () => {
|
||||
it("returns failure result and logs", () => {
|
||||
const result = actionError("myAction", "something went wrong");
|
||||
expect(result).toEqual({ success: false, error: "something went wrong" });
|
||||
expect(mockError).toHaveBeenCalledWith("Action failed: myAction", {
|
||||
action: "myAction",
|
||||
error: "something went wrong",
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user