refactor: full codebase overhaul — dead code removal, env validation, logger migration, date consolidation, Prisma schema cleanup, button consistency, useEffect deps, test coverage
- env.ts: added 10 missing Zod-validated env vars (imager, paypal currency, argon2/bcrypt params) - Migrated 6 modules from process.env to validated env.* (auth, proxy-auth, paypal, password, redis, imager, moderation, alert, logger) - Replaced console.warn/error with pino logger in 9 server-side modules - Removed 50+ dead exports (SWF wrappers, coalesceHotelName, signIn, isStaff re-export, formatTimestamp, Skeleton/SkeletonCard, 4 unused housekeeping sections) - Consolidated date formatting: 28 files migrated to shared formatDate() from @/lib/format-date - Wired 4 radio/settings API routes through cached siteSettings service instead of raw Prisma queries - Added getMany()/getAll() helpers to SiteSettings service - Removed 88 dead Prisma model definitions (schema 2763→1846 lines) - Created admin action-helper.ts with wrapAction() for standardized error handling - Fixed useEffect dependency arrays in 4 data-heavy components - Replaced raw btn CSS classes with shadcn Button component across admin pages - Stripped dead i18n namespaces (common, pages.client) from all 22 translation files - Removed 2 dead scripts (create-release.sh, check-local-imports.ts) - Fixed knip.json configuration - Added 7 new test suites: format-date, paypal, moderation, alert, webhook, action-helper, and fixed password.test.ts for env mocking - All 358 tests passing across 72 test files - TypeScript: 0 errors
This commit is contained in:
1 parent
12e4a07e48
commit
1acace49d0
150 files changed
+10210
-12272
No files matched your search
@@ -1,5 +1,6 @@
|
||||
import { promises as fs } from "node:fs";
|
||||
import path from "node:path";
|
||||
import { logger } from "@/lib/logger";
|
||||
import { prisma } from "@/lib/prisma";
|
||||
import { extractFurniIconPng } from "@/lib/services/clone-icon";
|
||||
import type { CloneSource } from "@/lib/services/clone-sources";
|
||||
@@ -175,7 +176,7 @@ export async function cloneSingleFurni(params: {
|
||||
},
|
||||
);
|
||||
if (!dl.ok) {
|
||||
console.warn("[clone-import] nitro download failed for", classname);
|
||||
logger.warn("[clone-import] nitro download failed for", { classname });
|
||||
return { ok: false, classname, warnings, error: "nitro download failed" };
|
||||
}
|
||||
// Validate it is a real Nitro bundle.
|
||||
@@ -183,7 +184,7 @@ export async function cloneSingleFurni(params: {
|
||||
parseNitroBundle(await fs.readFile(/*turbopackIgnore: true*/ nitroPath));
|
||||
} catch {
|
||||
await fs.unlink(/*turbopackIgnore: true*/ nitroPath).catch(() => {});
|
||||
console.warn("[clone-import] invalid .nitro bundle for", classname);
|
||||
logger.warn("[clone-import] invalid .nitro bundle for", { classname });
|
||||
return { ok: false, classname, warnings, error: "invalid .nitro bundle" };
|
||||
}
|
||||
const iconDl = await downloadFile(
|
||||
@@ -233,10 +234,9 @@ export async function cloneSingleFurni(params: {
|
||||
// Rollback: remove both downloaded files so we don't leave orphaned assets.
|
||||
await fs.unlink(/*turbopackIgnore: true*/ nitroPath).catch(() => {});
|
||||
await fs.unlink(/*turbopackIgnore: true*/ iconPath).catch(() => {});
|
||||
console.warn(
|
||||
logger.warn(
|
||||
"[clone-import] items_base insert failed for",
|
||||
classname,
|
||||
(err as Error).message,
|
||||
{ classname, error: (err as Error).message },
|
||||
);
|
||||
return {
|
||||
ok: false,
|
||||
@@ -254,10 +254,9 @@ export async function cloneSingleFurni(params: {
|
||||
itemType,
|
||||
);
|
||||
} catch (err) {
|
||||
console.warn(
|
||||
logger.warn(
|
||||
"[clone-import] FurnitureData append failed for",
|
||||
classname,
|
||||
(err as Error).message,
|
||||
{ classname, error: (err as Error).message },
|
||||
);
|
||||
warnings.push(`FurnitureData append failed: ${(err as Error).message}`);
|
||||
}
|
||||
@@ -273,10 +272,9 @@ export async function cloneSingleFurni(params: {
|
||||
return nextCatalogId;
|
||||
});
|
||||
} catch (err) {
|
||||
console.warn(
|
||||
logger.warn(
|
||||
"[clone-import] catalog entry failed for",
|
||||
classname,
|
||||
(err as Error).message,
|
||||
{ classname, error: (err as Error).message },
|
||||
);
|
||||
warnings.push(`catalog entry failed: ${(err as Error).message}`);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user