feat(housekeeping): complete people moderation parity

src/actions/admin-bans.test.ts

@@ -1,84 +1,69 @@
-// @ts-nocheck
 import { revalidatePath } from "next/cache";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import { requirePermissionRateLimited } from "@/lib/admin/guard";
-import { rcon } from "@/lib/services/rcon";
-import { createBan, liftBan } from "./admin-bans";
 
-const { selectLimit, insertValues, deleteWhere } = vi.hoisted(() => {
-	const selectLimit = vi.fn();
-	const insertValues = vi.fn().mockResolvedValue([{ insertId: 1 }]);
-	const deleteWhere = vi.fn().mockResolvedValue([{ affectedRows: 1 }]);
-	return { selectLimit, insertValues, deleteWhere };
-});
+const { execute } = vi.hoisted(() => ({ execute: vi.fn() }));
 
+vi.mock("@/features/housekeeping/domains/people/services/mutations", () => ({
+	createPeopleMutationInvocation: vi.fn((staff, correlationId) => ({
+		expectedActorId: staff.id,
+		correlationId,
+		legacy: true,
+	})),
+	peopleMutationService: { execute },
+}));
 vi.mock("@/lib/admin/guard", () => ({ requirePermissionRateLimited: vi.fn() }));
 vi.mock("@/lib/permissions", () => ({ PERMS: { USERS_BAN: "users.ban" } }));
-vi.mock("@/lib/db", () => ({
-	db: {
-		select: vi.fn(() => ({
-			from: vi.fn(() => ({
-				where: vi.fn(() => ({
-					limit: selectLimit,
-				})),
-			})),
-		})),
-		insert: vi.fn(() => ({ values: insertValues })),
-		delete: vi.fn(() => ({ where: deleteWhere })),
-	},
-	Ban: { id: "id", userId: "userId" },
-	User: { id: "id", username: "username" },
-}));
-vi.mock("@/lib/services/rcon", () => ({ rcon: { disconnectUser: vi.fn() } }));
-vi.mock("@/lib/services/staff-activity", () => ({ logStaffActivity: vi.fn() }));
 vi.mock("next/cache", () => ({ revalidatePath: vi.fn() }));
 
+import { createBan, liftBan } from "./admin-bans";
+
 const staff = { id: 1, rank: 7, username: "admin" };
-const fakeForm = (data: Record<string, string>) => ({
-	get: (key: string) => data[key] ?? null,
-});
+const fakeForm = (data: Record<string, string>) =>
+	({ get: (key: string) => data[key] ?? null }) as unknown as FormData;
 
 beforeEach(() => {
 	vi.clearAllMocks();
 	vi.mocked(requirePermissionRateLimited).mockResolvedValue(staff as never);
-	selectLimit.mockResolvedValue([{ username: "baduser" }]);
-	insertValues.mockResolvedValue([{ insertId: 1 }]);
-	deleteWhere.mockResolvedValue([{ affectedRows: 1 }]);
+	execute.mockImplementation(async (invocation) => ({
+		ok: true,
+		data: { before: null, after: {} },
+		correlationId: invocation.correlationId,
+	}));
 });
 
-describe("createBan", () => {
-	it("creates a ban for valid inputs", async () => {
+describe("legacy admin ban wrappers", () => {
+	it("preserves parsed create input, service delegation, and revalidation", async () => {
 		await createBan(
 			fakeForm({
 				userId: "42",
 				reason: "Spam",
 				hours: "24",
 				type: "account",
-			}) as unknown as FormData,
+			}),
 		);
-		expect(insertValues).toHaveBeenCalledWith(
-			expect.objectContaining({ userId: 42, type: "account" }),
+		expect(execute).toHaveBeenCalledWith(
+			expect.objectContaining({ expectedActorId: 1, legacy: true }),
+			"ban.create",
+			{ userId: 42, reason: "Spam", hours: 24, type: "account" },
 		);
-		expect(rcon.disconnectUser).toHaveBeenCalledWith(42, "baduser");
 		expect(revalidatePath).toHaveBeenCalledWith("/admin/bans");
 	});
 
 	it("returns early when userId is invalid", async () => {
 		await createBan(
-			fakeForm({
-				userId: "0",
-				hours: "1",
-				type: "account",
-			}) as unknown as FormData,
+			fakeForm({ userId: "0", hours: "1", type: "account" }),
 		);
-		expect(insertValues).not.toHaveBeenCalled();
+		expect(execute).not.toHaveBeenCalled();
 	});
-});
 
-describe("liftBan", () => {
-	it("deletes ban and revalidates", async () => {
-		await liftBan(fakeForm({ id: "42" }) as unknown as FormData);
-		expect(deleteWhere).toHaveBeenCalled();
+	it("delegates lift by exact ban id and preserves revalidation", async () => {
+		await liftBan(fakeForm({ id: "42" }));
+		expect(execute).toHaveBeenCalledWith(
+			expect.objectContaining({ expectedActorId: 1, legacy: true }),
+			"ban.lift",
+			{ id: 42 },
+		);
 		expect(revalidatePath).toHaveBeenCalledWith("/admin/bans");
 	});
 });