Harden CMS security and theme contrast

src/actions/admin-permissions.ts

@@ -1,9 +1,12 @@
 "use server";
 
 import { revalidatePath } from "next/cache";
+import { redirect } from "next/navigation";
 import { requireStaff } from "@/lib/admin/guard";
 import { prisma } from "@/lib/prisma";
 import { logStaffActivity } from "@/lib/services/staff-activity";
+import { formPositiveBigInt } from "@/lib/form-data";
+import { logServerError } from "@/lib/server-log";
 
 // website_permissions (model WebsitePermissions) is the CMS-owned permission ->
 // minimum-rank mapping. Editable columns are exactly: permission (unique name),
@@ -37,10 +40,13 @@ export async function createPermission(formData: FormData): Promise<void> {
       description: `Saved permission "${permission}" (min rank ${minRank})`,
       targetType: "permission",
     });
-  } catch {
+  } catch (error) {
+    logServerError("admin.permission_create_failed", error, { staffId: staff.id, permission });
+    redirect("/admin/permissions?error=save");
     // ignore (e.g. constraint failure) — page re-renders current state
   }
   revalidatePath("/admin/permissions");
+  redirect("/admin/permissions?saved=1");
 }
 
 export async function updatePermission(formData: FormData): Promise<void> {
@@ -63,33 +69,45 @@ export async function updatePermission(formData: FormData): Promise<void> {
     await logStaffActivity({
       staffId: staff.id,
       action: "permission_update",
-      description: `Updated permission #${raw} ("${permission}" min rank ${minRank})`,
+      description: `Updated permission #${id} ("${permission}" min rank ${minRank})`,
       targetType: "permission",
     });
-  } catch {
+  } catch (error) {
+    logServerError("admin.permission_update_failed", error, {
+      staffId: staff.id,
+      permissionId: String(id),
+    });
+    redirect("/admin/permissions?error=save");
     // ignore (e.g. duplicate) — page re-renders current state
   }
   revalidatePath("/admin/permissions");
+  redirect("/admin/permissions?saved=1");
 }
 
 export async function deletePermission(formData: FormData): Promise<void> {
   const staff = await requireStaff();
-  const raw = String(formData.get("id") ?? "");
-  if (!raw) return;
+  const id = formPositiveBigInt(formData, "id");
+  if (!id) return;
 
   try {
     const deleted = await prisma.websitePermissions.delete({
-      where: { id: BigInt(raw) },
+      where: { id },
       select: { permission: true },
     });
     await logStaffActivity({
       staffId: staff.id,
       action: "permission_delete",
-      description: `Deleted permission #${raw} ("${deleted.permission}")`,
+      description: `Deleted permission #${id} ("${deleted.permission}")`,
       targetType: "permission",
     });
-  } catch {
+  } catch (error) {
+    logServerError("admin.permission_delete_failed", error, {
+      staffId: staff.id,
+      permissionId: String(id),
+    });
+    redirect("/admin/permissions?error=delete");
     // ignore (e.g. already removed)
   }
   revalidatePath("/admin/permissions");
+  redirect("/admin/permissions?saved=1");
 }