feat: harden atoms-nexst against review findings (37 items)
Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
This commit is contained in:
1 parent
3933214953
commit
6cc45d7413
150 files changed
+2137
-759
No files matched your search
@@ -785,7 +785,8 @@
|
||||
"confirm": "Confirmar",
|
||||
"enableIntro": "Añade una segunda capa de seguridad con una aplicación de autenticación.",
|
||||
"enable": "Activar 2FA",
|
||||
"rateLimit": "Too many attempts. Please wait before trying again."
|
||||
"rateLimit": "Too many attempts. Please wait before trying again.",
|
||||
"alreadyEnabled": "La verificación en dos pasos ya está activa. Desactívala primero si quieres configurarla otra vez."
|
||||
},
|
||||
"title": "Cuentas vinculadas",
|
||||
"subtitle": "Vincula una cuenta social para iniciar sesión con un clic",
|
||||
@@ -819,7 +820,8 @@
|
||||
"showPassword": "Mostrar",
|
||||
"hidePassword": "Ocultar",
|
||||
"registeredSuccess": "Cuenta creada: revisa tu bandeja de entrada para el enlace de verificación e inicia sesión.",
|
||||
"verifyEmailCta": "Solicitar un nuevo enlace de verificación"
|
||||
"verifyEmailCta": "Solicitar un nuevo enlace de verificación",
|
||||
"passwordChanged": "Tu contraseña se ha cambiado. Inicia sesión con la nueva."
|
||||
},
|
||||
"register": {
|
||||
"title": "Crear cuenta",
|
||||
@@ -894,7 +896,8 @@
|
||||
"emailPlaceholder": "Tu correo electrónico",
|
||||
"sendResetLink": "Enviar enlace de restablecimiento",
|
||||
"backToLogin": "Volver al inicio de sesión",
|
||||
"errorCaptcha": "Captcha verification failed. Please try again."
|
||||
"errorCaptcha": "Captcha verification failed. Please try again.",
|
||||
"sendAnotherLink": "Enviar otro enlace"
|
||||
},
|
||||
"reset": {
|
||||
"title": "Establecer una nueva contraseña",
|
||||
@@ -903,7 +906,9 @@
|
||||
"resetPassword": "Restablecer contraseña",
|
||||
"backToLogin": "Volver al inicio de sesión",
|
||||
"passwordMinLength": "La contraseña debe tener al menos 12 caracteres",
|
||||
"tooManyAttempts": "Demasiados intentos — inténtalo más tarde"
|
||||
"tooManyAttempts": "Demasiados intentos — inténtalo más tarde",
|
||||
"invalidLink": "Este enlace de restablecimiento no es válido o ha caducado. Solicita uno nuevo.",
|
||||
"failed": "No se pudo restablecer la contraseña. Vuelve a intentarlo."
|
||||
},
|
||||
"verify": {
|
||||
"verifiedTitle": "Todo está listo",
|
||||
|
||||
Reference in new issue
Block a user