P1-P3 admin cleanup: rank guard, SSRF guard, count caching, dead code removal, pagination rewrite

- P1: new src/lib/admin/rank-guard.ts with tryGuardRank/guardRank + RankGuardTarget/Result; extracted from users.ts; applied to admin-bans (create/lift + rank redirect) and admin-badges (caps + rank guard + error surfacing); import-url-safety.ts SSRF guard wired into clone save+icon fetch; logAudit await in help-tickets; antiddos mutations SETTINGS_EDIT; markAllAlertsRead NOTIFICATIONS_EDIT; rankError/saveError in all 25 message files; tests rew/new for bans/badges/rank-guard/import-url-safety

- P2: ticket-inbox merged pagination reworked to single UNION ALL SQL with LIMIT/OFFSET (avoids O(offset) materialization); getCachedAdminCount with cacheFiltered option applied to devops/errors/photos/items/guilds/help-tickets/moderation pages; admin-theme catches→?error=1+banner+25 locales; logger in silent catches (rare-values/writeable-boxes); catalog-items-loader CAST→plain equality; count caching helper extended with opt-in cacheFiltered

- P3: removed dead modules is-staff/notice/recent-furni-resync/log-filters plus load-user-sanctions/user-sanction-timeline; removed orphaned CATALOG_PAGE_COLUMNS re-export; removed getFurniIconUrl from studio-furni-icons

Build: lint 0, typecheck 0, 3480 tests pass, i18n:check exit 0, colors exit 0. Circular chunk warning (9452/10535/66463) is webpack code-splitting artifact; build succeeds.

src/actions/admin-theme.test.ts

@@ -141,13 +141,13 @@ describe("saveTheme", () => {
 		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?saved=1");
 	});
 
-	it("fails soft when a write fails and still redirects", async () => {
+	it("redirects with an error when a write fails", async () => {
 		fakeDbConfig.fail = (kind: string) => kind === "insert";
 		await saveTheme(form({ color_primary: "#123456" }));
 		expect(mockReload).not.toHaveBeenCalled();
 		expect(mockLogStaffActivity).not.toHaveBeenCalled();
 		expect(mockRevalidatePath).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?saved=1");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });
 
@@ -182,12 +182,12 @@ describe("applyPreset", () => {
 		expect(mockLogStaffActivity).not.toHaveBeenCalled();
 	});
 
-	it("fails soft on write errors", async () => {
+	it("redirects with an error on write errors", async () => {
 		fakeDbConfig.fail = (kind: string) => kind === "insert";
 		await applyPreset(form({ preset: "Ocean" }));
 		expect(mockReload).not.toHaveBeenCalled();
 		expect(mockLogStaffActivity).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?preset=Ocean");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });
 
@@ -218,12 +218,12 @@ describe("saveCustomTheme", () => {
 		expect(mockSnapshotCurrentTheme).not.toHaveBeenCalled();
 	});
 
-	it("fails soft on persist errors", async () => {
+	it("redirects with an error on persist errors", async () => {
 		mockUpsertCustomTheme.mockRejectedValueOnce(new Error("store down"));
 		await saveCustomTheme(form({ name: "My Theme" }));
 		expect(mockLogStaffActivity).not.toHaveBeenCalled();
 		expect(mockRevalidatePath).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?savedTheme=1");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });
 
@@ -284,7 +284,7 @@ describe("applyCustomTheme", () => {
 		);
 	});
 
-	it("fails soft on write errors", async () => {
+	it("redirects with an error on write errors", async () => {
 		mockGetCustomTheme.mockResolvedValue({
 			id: "t1",
 			name: "Studio",
@@ -296,7 +296,7 @@ describe("applyCustomTheme", () => {
 		expect(mockReload).not.toHaveBeenCalled();
 		expect(mockLogStaffActivity).not.toHaveBeenCalled();
 		expect(mockRevalidatePath).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?theme=Studio");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });
 
@@ -324,11 +324,11 @@ describe("renameCustomTheme", () => {
 		expect(mockSnapshotCurrentTheme).not.toHaveBeenCalled();
 	});
 
-	it("fails soft on upsert errors", async () => {
+	it("redirects with an error on upsert errors", async () => {
 		mockUpsertCustomTheme.mockRejectedValueOnce(new Error("store down"));
 		await renameCustomTheme(form({ id: "t1", name: "Renamed" }));
 		expect(mockRevalidatePath).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?renamed=1");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });
 
@@ -350,10 +350,10 @@ describe("deleteCustomTheme", () => {
 		expect(mockDeleteCustomThemeStore).not.toHaveBeenCalled();
 	});
 
-	it("fails soft on store errors", async () => {
+	it("redirects with an error on store errors", async () => {
 		mockDeleteCustomThemeStore.mockRejectedValueOnce(new Error("store down"));
 		await deleteCustomTheme(form({ id: "t1" }));
 		expect(mockRevalidatePath).not.toHaveBeenCalled();
-		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?deletedTheme=1");
+		expect(mockRedirect).toHaveBeenCalledWith("/admin/theme?error=1");
 	});
 });