P1-P3 admin cleanup: rank guard, SSRF guard, count caching, dead code removal, pagination rewrite
CI / check (push) Canceled after 0s
CI / tests-unit (push) Canceled after 0s
CI / tests-integration (push) Canceled after 0s
CI / tests-ui (push) Canceled after 0s
CI / preflight (push) Canceled after 0s
CI / deploy (push) Canceled after 0s
Gitea Runner Clean Test / test-job (push) Canceled after 0s
Gitea Actions Runner Test / test-job (push) Canceled after 0s

- P1: new src/lib/admin/rank-guard.ts with tryGuardRank/guardRank + RankGuardTarget/Result; extracted from users.ts; applied to admin-bans (create/lift + rank redirect) and admin-badges (caps + rank guard + error surfacing); import-url-safety.ts SSRF guard wired into clone save+icon fetch; logAudit await in help-tickets; antiddos mutations SETTINGS_EDIT; markAllAlertsRead NOTIFICATIONS_EDIT; rankError/saveError in all 25 message files; tests rew/new for bans/badges/rank-guard/import-url-safety

- P2: ticket-inbox merged pagination reworked to single UNION ALL SQL with LIMIT/OFFSET (avoids O(offset) materialization); getCachedAdminCount with cacheFiltered option applied to devops/errors/photos/items/guilds/help-tickets/moderation pages; admin-theme catches→?error=1+banner+25 locales; logger in silent catches (rare-values/writeable-boxes); catalog-items-loader CAST→plain equality; count caching helper extended with opt-in cacheFiltered

- P3: removed dead modules is-staff/notice/recent-furni-resync/log-filters plus load-user-sanctions/user-sanction-timeline; removed orphaned CATALOG_PAGE_COLUMNS re-export; removed getFurniIconUrl from studio-furni-icons

Build: lint 0, typecheck 0, 3480 tests pass, i18n:check exit 0, colors exit 0. Circular chunk warning (9452/10535/66463) is webpack code-splitting artifact; build succeeds.
This commit is contained in:
openhands committed 2026-10-12 17:42:19 +02:00
1 parent 57529fd1ea
commit 7b249a7222
71 files changed
+1031 -1078

No files matched your search

+6 -6
View File
@@ -104,7 +104,7 @@ export async function saveTheme(formData: FormData): Promise<void> {
});
revalidatePath("/", "layout");
} catch {
// ignore — page re-renders current state
return redirect("/admin/theme?error=1");
}
redirect("/admin/theme?saved=1");
}
@@ -128,7 +128,7 @@ export async function applyPreset(formData: FormData): Promise<void> {
});
revalidatePath("/", "layout");
} catch {
// ignore
return redirect("/admin/theme?error=1");
}
redirect(`/admin/theme?preset=${encodeURIComponent(name)}`);
}
@@ -149,7 +149,7 @@ export async function saveCustomTheme(formData: FormData): Promise<void> {
});
revalidatePath("/admin/theme");
} catch {
// ignore
return redirect("/admin/theme?error=1");
}
redirect("/admin/theme?savedTheme=1");
}
@@ -175,7 +175,7 @@ export async function applyCustomTheme(formData: FormData): Promise<void> {
});
revalidatePath("/", "layout");
} catch {
// ignore
return redirect("/admin/theme?error=1");
}
redirect(`/admin/theme?theme=${encodeURIComponent(theme.name)}`);
}
@@ -194,7 +194,7 @@ export async function renameCustomTheme(formData: FormData): Promise<void> {
await upsertCustomTheme(name, snapshot, id);
revalidatePath("/admin/theme");
} catch {
// ignore
return redirect("/admin/theme?error=1");
}
redirect("/admin/theme?renamed=1");
}
@@ -209,7 +209,7 @@ export async function deleteCustomTheme(formData: FormData): Promise<void> {
await deleteCustomThemeStore(id);
revalidatePath("/admin/theme");
} catch {
// ignore
return redirect("/admin/theme?error=1");
}
redirect("/admin/theme?deletedTheme=1");
}