fix(imaging): make avatar and badge images resilient to upstream outages
CI / check (push) Successful in 4m11s
CI / preflight (push) Skipped
CI / deploy (push) Successful in 1m51s

- Add persistent disk cache for rendered avatars/badges (storage/imaging)
  so repeats never touch the flaky local renderer and cached renders
  survive upstream downtime
- Serve cache-first with stale-on-error; cut primary/fallback timeouts
  from 10s/6s to 4s/4s so failing images cannot stall pages
- Avatar proxy now returns a graceful 200 silhouette instead of 502 when
  no renderer can produce a figure, so no broken-image glyphs appear
- Badge endpoint becomes a caching proxy trying configured CDN, public
  Habbo CDN and local /swf copy in order, and drops the fragile IP rate
  limit that could blank badge streams
- Route all site badge images (profile, me, badges, apply pages) through
  the cached proxy instead of hot-linking images.habbo.com
This commit is contained in:
openhands committed 2026-09-20 12:58:55 +02:00
1 parent c3ff497050
commit 8a66db4ed7
12 files changed
+458 -58

No files matched your search

+3 -3
View File
@@ -28,8 +28,8 @@ export async function generateMetadata(): Promise<Metadata> {
}; };
} }
// Canonical Habbo badge image CDN (same base used by the profile page). // Badge codes map to a .gif served through the cached proxy.
const BADGE_IMG_BASE = "https://images.habbo.com/c_images/album1584"; const BADGE_IMG_BASE = "/api/imaging/badge?code";
function feedbackStyle(tone: "success" | "error"): CSSProperties { function feedbackStyle(tone: "success" | "error"): CSSProperties {
const accent = const accent =
@@ -144,7 +144,7 @@ export default async function ApplyStaffPage({
{team?.badge ? ( {team?.badge ? (
/* eslint-disable-next-line @next/next/no-img-element */ /* eslint-disable-next-line @next/next/no-img-element */
<img <img
src={`${BADGE_IMG_BASE}/${team.badge}.gif`} src={`${BADGE_IMG_BASE}=${encodeURIComponent(team.badge)}`}
alt={rankName} alt={rankName}
width={40} width={40}
height={40} height={40}
+3 -3
View File
@@ -22,8 +22,8 @@ export async function generateMetadata(): Promise<Metadata> {
}; };
} }
// Canonical Habbo badge image CDN (same base used by the profile page). // Badge codes map to a .gif served through the cached proxy.
const BADGE_IMG_BASE = "https://images.habbo.com/c_images/album1584"; const BADGE_IMG_BASE = "/api/imaging/badge?code";
function feedbackStyle(tone: "success" | "error"): CSSProperties { function feedbackStyle(tone: "success" | "error"): CSSProperties {
const accent = const accent =
@@ -122,7 +122,7 @@ export default async function ApplyTeamPage({
{team.badge ? ( {team.badge ? (
/* eslint-disable-next-line @next/next/no-img-element */ /* eslint-disable-next-line @next/next/no-img-element */
<img <img
src={`${BADGE_IMG_BASE}/${team.badge}.gif`} src={`${BADGE_IMG_BASE}=${encodeURIComponent(team.badge)}`}
alt={team.rankName} alt={team.rankName}
width={40} width={40}
height={40} height={40}
+3 -3
View File
@@ -17,8 +17,8 @@ export async function generateMetadata(): Promise<Metadata> {
}; };
} }
// Canonical Habbo badge image CDN. A badge_key (e.g. "ADM") maps to a .gif here. // A badge_key (e.g. "ADM") maps to a .gif served through the cached proxy.
const BADGE_IMG_BASE = "https://images.habbo.com/c_images/album1584"; const BADGE_IMG_BASE = "/api/imaging/badge?code";
export default async function BadgesPage() { export default async function BadgesPage() {
const t = await getTranslations("pages.badges"); const t = await getTranslations("pages.badges");
@@ -50,7 +50,7 @@ export default async function BadgesPage() {
> >
{/* eslint-disable-next-line @next/next/no-img-element */} {/* eslint-disable-next-line @next/next/no-img-element */}
<img <img
src={`${BADGE_IMG_BASE}/${badge.badgeKey}.gif`} src={`${BADGE_IMG_BASE}=${encodeURIComponent(badge.badgeKey)}`}
alt={badge.badgeName} alt={badge.badgeName}
title={badge.badgeKey} title={badge.badgeKey}
width={40} width={40}
+2 -2
View File
@@ -10,7 +10,7 @@ import { ProfileImage } from "@/components/shared/profile-image";
import { UserAvatarThumbnail } from "@/components/shared/user-avatar-thumbnail"; import { UserAvatarThumbnail } from "@/components/shared/user-avatar-thumbnail";
import { SurfaceCard } from "@/components/surface-card"; import { SurfaceCard } from "@/components/surface-card";
import { auth } from "@/lib/auth"; import { auth } from "@/lib/auth";
import { avatarImageUrl, slugify } from "@/lib/format"; import { avatarImageUrl, badgeImageUrl, slugify } from "@/lib/format";
import { withPublicPagePerformance } from "@/lib/public-page-performance"; import { withPublicPagePerformance } from "@/lib/public-page-performance";
import { loadDailyRewardState } from "@/lib/services/daily-rewards"; import { loadDailyRewardState } from "@/lib/services/daily-rewards";
import { loadUserDashboard } from "@/lib/services/user-dashboard"; import { loadUserDashboard } from "@/lib/services/user-dashboard";
@@ -456,7 +456,7 @@ async function MePage({
{badges.map((badge) => ( {badges.map((badge) => (
<img <img
key={badge.badgeCode} key={badge.badgeCode}
src={`https://images.habbo.com/c_images/album1584/${encodeURIComponent(badge.badgeCode)}.gif`} src={badgeImageUrl(badge.badgeCode)}
alt={badge.badgeCode} alt={badge.badgeCode}
title={badge.badgeCode} title={badge.badgeCode}
width={40} width={40}
+3 -8
View File
@@ -71,8 +71,8 @@ export async function generateMetadata({
}; };
} }
// Canonical Habbo badge image CDN. Badge codes (e.g. "ADM") map to a .gif here. // Badge codes (e.g. "ADM") map to a .gif served through the cached proxy.
const BADGE_IMG_BASE = "https://images.habbo.com/c_images/album1584"; const BADGE_IMG_BASE = "/api/imaging/badge?code";
// Emulator currency type ids (see UsersCurrency model): Duckets=0, Diamonds=5. // Emulator currency type ids (see UsersCurrency model): Duckets=0, Diamonds=5.
const CURRENCY_DUCKETS = 0; const CURRENCY_DUCKETS = 0;
@@ -514,12 +514,7 @@ async function ProfilePage({
<details key={b.id} className={styles.badge}> <details key={b.id} className={styles.badge}>
<summary title={name}> <summary title={name}>
<img <img
src={ src={`${BADGE_IMG_BASE}=${encodeURIComponent(b.badgeCode)}`}
BADGE_IMG_BASE +
"/" +
encodeURIComponent(b.badgeCode) +
".gif"
}
alt={name} alt={name}
width={40} width={40}
height={40} height={40}
+43 -8
View File
@@ -1,5 +1,33 @@
import { type NextRequest, NextResponse } from "next/server"; import { type NextRequest, NextResponse } from "next/server";
import { fetchAvatarImage, parseAvatarQuery } from "@/lib/imager-upstream"; import { AVATAR_FALLBACK_SRC } from "@/lib/imager";
import {
fetchAvatarImage,
ImagerUnavailableError,
parseAvatarQuery,
} from "@/lib/imager-upstream";
// The same neutral silhouette the client fallback uses, served as a real 200
// response when no upstream can render the figure. Images on server-rendered
// pages therefore never show a broken-image glyph; browsers revalidate quickly
// (`no-cache`) and pick up real renders as soon as an upstream recovers.
const PLACEHOLDER_SVG_BYTES = new TextEncoder().encode(
decodeURIComponent(
AVATAR_FALLBACK_SRC.slice("data:image/svg+xml;utf8,".length),
),
);
function cacheControlFor(source: string): string {
switch (source) {
case "fallback":
case "cache-stale":
// Reuse the render briefly but revalidate the upstream soon.
return "public, max-age=300";
case "unavailable":
return "no-cache, max-age=0";
default:
return "public, max-age=3600";
}
}
export async function GET(request: NextRequest) { export async function GET(request: NextRequest) {
const { searchParams } = new URL(request.url); const { searchParams } = new URL(request.url);
@@ -20,17 +48,24 @@ export async function GET(request: NextRequest) {
headers: { headers: {
"Content-Type": contentType, "Content-Type": contentType,
"Content-Length": String(body.length), "Content-Length": String(body.length),
// Fallback renders are served with a short TTL so the configured "Cache-Control": cacheControlFor(source),
// imager is retried soon instead of being masked for hours.
"Cache-Control":
source === "fallback"
? "public, max-age=300"
: "public, max-age=3600",
"X-Imager-Source": source, "X-Imager-Source": source,
"Access-Control-Allow-Origin": "*", "Access-Control-Allow-Origin": "*",
}, },
}); });
} catch { } catch (error) {
if (error instanceof ImagerUnavailableError) {
return new NextResponse(PLACEHOLDER_SVG_BYTES as unknown as BodyInit, {
status: 200,
headers: {
"Content-Type": "image/svg+xml",
"Content-Length": String(PLACEHOLDER_SVG_BYTES.length),
"Cache-Control": cacheControlFor("unavailable"),
"X-Imager-Source": "unavailable",
"Access-Control-Allow-Origin": "*",
},
});
}
return NextResponse.json( return NextResponse.json(
{ error: "Failed to fetch avatar from upstream" }, { error: "Failed to fetch avatar from upstream" },
{ status: 502 }, { status: 502 },
+124 -25
View File
@@ -1,28 +1,38 @@
import { readFile } from "node:fs/promises";
import { join } from "node:path";
import { type NextRequest, NextResponse } from "next/server"; import { type NextRequest, NextResponse } from "next/server";
import { clientIp, rateLimit } from "@/lib/rate-limit"; import {
badgeCacheDir,
imagingCacheKey,
readImagingCache,
writeImagingCache,
} from "@/lib/imager-cache";
import { resolveBadgeBase } from "@/lib/runtime-asset-config"; import { resolveBadgeBase } from "@/lib/runtime-asset-config";
import { siteSettings } from "@/lib/services/site-settings"; import { siteSettings } from "@/lib/services/site-settings";
/** /**
* GET /api/imaging/badge?code=ADM * GET /api/imaging/badge?code=ADM[&source=local]
* *
* Resolves a Habbo badge code to its image URL and redirects there. * Resolves a Habbo badge code to its image and serves it through a local
* caching proxy. Candidates are tried in order (configured CDN, public Habbo
* CDN, local `/swf` copy), so a flaky images.habbo.com never blanks a badge
* and every badge renders exactly once anywhere on the site.
*/ */
const CODE_RE = /^[A-Za-z0-9_+.-]+$/; const CODE_RE = /^[A-Za-z0-9_+.-]+$/;
const CODE_MAX_LEN = 50; const CODE_MAX_LEN = 50;
const DEFAULT_BASE = "https://images.habbo.com/c_images/album1584"; const DEFAULT_BASE = "https://images.habbo.com/c_images/album1584";
const LOCAL_SWF_BASE = "/swf/c_images/album1584";
const FETCH_TIMEOUT_MS = 5_000;
// Neutral placeholder (grey rounded square) served as a 200 so broken badge
// glyphs can never appear, even when every candidate is unavailable.
const BADGE_PLACEHOLDER_SVG =
"<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 40 25'><rect width='40' height='25' rx='4' fill='%23e2e2e2'/></svg>";
type BadgeSource = "upstream" | "local" | "cache" | "unavailable";
export async function GET(request: NextRequest) { export async function GET(request: NextRequest) {
const ip = await clientIp();
const limited = await rateLimit(`badge-imaging:${ip}`, 60, 60_000);
if (!limited.ok) {
return new NextResponse(null, {
status: 429,
headers: { "Retry-After": String(limited.retryAfter) },
});
}
const code = request.nextUrl.searchParams.get("code")?.trim(); const code = request.nextUrl.searchParams.get("code")?.trim();
if (!code || code.length > CODE_MAX_LEN || !CODE_RE.test(code)) { if (!code || code.length > CODE_MAX_LEN || !CODE_RE.test(code)) {
return NextResponse.json({ error: "Invalid badge code" }, { status: 400 }); return NextResponse.json({ error: "Invalid badge code" }, { status: 400 });
@@ -32,21 +42,110 @@ export async function GET(request: NextRequest) {
(resolveBadgeBase() || (await siteSettings.get("badge_base_url", ""))) ?? (resolveBadgeBase() || (await siteSettings.get("badge_base_url", ""))) ??
"" ""
).trim(); ).trim();
const fallback = const sourceLocal = request.nextUrl.searchParams.get("source") === "local";
request.nextUrl.searchParams.get("source") === "local"
? "/swf/c_images/album1584"
: DEFAULT_BASE;
const base = (configured || fallback).replace(/\/+$/, "");
const isAbsolute = /^https?:\/\//i.test(base);
const target = `${base}/${code}.gif`;
const absoluteTarget = isAbsolute
? target
: new URL(target, request.nextUrl.origin).toString();
return NextResponse.redirect(absoluteTarget, { const candidates: string[] = sourceLocal
status: 302, ? [LOCAL_SWF_BASE, DEFAULT_BASE]
: [
...((configured && [configured]) as string[]),
DEFAULT_BASE,
LOCAL_SWF_BASE,
];
const cacheKey = imagingCacheKey(`${code}\n${candidates.join("\n")}`);
const cached = await readImagingCache(badgeCacheDir(), cacheKey);
if (cached) return badgeResponse(cached.body, cached.contentType, "cache");
for (const base of candidates) {
const result = await fetchCandidate(base, code);
if (result) {
await writeImagingCache(
badgeCacheDir(),
cacheKey,
result.body,
result.contentType,
);
return badgeResponse(result.body, result.contentType, result.source);
}
}
return badgeResponse(
new TextEncoder().encode(BADGE_PLACEHOLDER_SVG),
"image/svg+xml",
"unavailable",
);
}
async function fetchCandidate(
base: string,
code: string,
): Promise<{
body: Uint8Array;
contentType: string;
source: BadgeSource;
} | null> {
const normalized = base.replace(/\/+$/, "");
if (/^https?:\/\//i.test(normalized)) {
try {
const res = await fetch(`${normalized}/${encodeURIComponent(code)}.gif`, {
signal: AbortSignal.timeout(FETCH_TIMEOUT_MS),
cache: "no-store",
});
if (!res.ok) return null;
const contentType = res.headers.get("content-type") ?? "image/gif";
if (!contentType.startsWith("image/")) return null;
return {
body: new Uint8Array(await res.arrayBuffer()),
contentType,
source: "upstream",
};
} catch {
return null;
}
}
// Local `/swf/...` path — read straight from the deployed public folder.
try {
const file = join(
process.cwd(),
"public",
normalized.replace(/^\//, ""),
`${code}.gif`,
);
const body = new Uint8Array(await readFile(file));
return { body, contentType: "image/gif", source: "local" };
} catch {
return null;
}
}
function badgeResponse(
body: Uint8Array,
contentType: string,
source: BadgeSource,
) {
return new NextResponse(body as unknown as BodyInit, {
status: 200,
headers: { headers: {
"Cache-Control": "public, max-age=300", "Content-Type": contentType,
"Content-Length": String(body.length),
"Cache-Control":
source === "unavailable"
? "no-cache, max-age=0"
: "public, max-age=3600",
"X-Imager-Source": source,
"Access-Control-Allow-Origin": "*",
},
});
}
export async function OPTIONS() {
return new NextResponse(null, {
status: 204,
headers: {
"Access-Control-Allow-Origin": "*",
"Access-Control-Allow-Methods": "GET, OPTIONS",
"Access-Control-Allow-Headers": "Content-Type, If-None-Match",
}, },
}); });
} }
+5
View File
@@ -6,6 +6,11 @@ export function avatarImageUrl(look: string, opts: AvatarOptions = {}): string {
return getAvatarUrl(look, opts); return getAvatarUrl(look, opts);
} }
/** Build a proxied, cached badge image URL for a badge code. */
export function badgeImageUrl(code: string): string {
return `/api/imaging/badge?code=${encodeURIComponent(code)}`;
}
/** URL-safe slug from a title (lowercase, ascii, hyphenated). */ /** URL-safe slug from a title (lowercase, ascii, hyphenated). */
export function slugify(input: string): string { export function slugify(input: string): string {
// NFKD splits accented letters into base + combining mark; the combining // NFKD splits accented letters into base + combining mark; the combining
+57
View File
@@ -0,0 +1,57 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import {
avatarCacheDir,
imagingCacheKey,
readImagingCache,
writeImagingCache,
} from "./imager-cache";
const TEST_KEY = imagingCacheKey("test-render");
const TEST_DIR = () => `${avatarCacheDir()}/unit`;
beforeEach(() => {
// Isolate every run from the runtime cache and from prior runs.
vi.stubEnv(
"IMAGING_CACHE_ROOT",
`${process.cwd()}/storage/imaging/test-unit-${process.pid}-${Date.now()}`,
);
});
describe("imagingCacheKey", () => {
it("is stable and deterministic", () => {
expect(imagingCacheKey("figure-a")).toBe(imagingCacheKey("figure-a"));
expect(imagingCacheKey("figure-a")).not.toBe(imagingCacheKey("figure-b"));
});
});
describe("readImagingCache / writeImagingCache", () => {
it("round-trips a render", async () => {
await writeImagingCache(
TEST_DIR(),
TEST_KEY,
new Uint8Array([1, 2, 3]),
"image/png",
);
const record = await readImagingCache(TEST_DIR(), TEST_KEY);
expect(record).not.toBeNull();
expect(record?.contentType).toBe("image/png");
expect([...(record?.body ?? [])]).toEqual([1, 2, 3]);
});
it("returns null for a missing entry", async () => {
expect(
await readImagingCache(TEST_DIR(), imagingCacheKey("does-not-exist")),
).toBeNull();
});
it("tolerates a torn write as a cache miss", async () => {
const key = imagingCacheKey("torn-write");
await writeImagingCache(
TEST_DIR(),
key,
new Uint8Array([7, 7, 7]),
"image/gif",
);
expect(await readImagingCache(TEST_DIR(), key)).not.toBeNull();
});
});
+118
View File
@@ -0,0 +1,118 @@
import "server-only";
import { createHash } from "node:crypto";
import {
mkdir,
readdir,
readFile,
rename,
stat,
unlink,
writeFile,
} from "node:fs/promises";
import { join } from "node:path";
/**
* Persistent disk cache for imaging renders (avatars, badges).
*
* Renders are immutable per URL, so a successful render is served again and
* again without touching the upstream renderer. This is what makes imaging
* resilient: repeated figure requests never exhaust the local imager, and an
* upstream outage cannot blank images that have rendered once.
*
* The tree lives under `storage/` (gitignored) so it survives restarts and
* stays out of the repository. Old entries are pruned opportunistically so
* the directory cannot grow without bound.
*/
const MAX_ENTRIES = 20_000;
const MAX_AGE_MS = 30 * 24 * 60 * 60 * 1000;
const IMG_ROOT_DEFAULT = join(process.cwd(), "storage", "imaging");
function imagingCacheDir(kind: "avatars" | "badges"): string {
// Unit tests point this at a scratch root so they never read or pollute
// the runtime cache.
const root = (process.env.IMAGING_CACHE_ROOT || "").trim();
return root ? join(root, kind) : join(IMG_ROOT_DEFAULT, kind);
}
export function avatarCacheDir(): string {
return imagingCacheDir("avatars");
}
export function badgeCacheDir(): string {
return imagingCacheDir("badges");
}
export interface ImagingCacheRecord {
body: Uint8Array;
contentType: string;
}
export function imagingCacheKey(input: string): string {
return createHash("sha256").update(input).digest("hex");
}
export async function readImagingCache(
directory: string,
key: string,
): Promise<ImagingCacheRecord | null> {
try {
const [img, meta] = await Promise.all([
readFile(join(directory, `${key}.img`)),
readFile(join(directory, `${key}.json`), "utf8"),
]);
const parsed = JSON.parse(meta) as { contentType?: unknown };
const contentType =
typeof parsed.contentType === "string" ? parsed.contentType : "image/png";
return { body: new Uint8Array(img), contentType };
} catch {
// A torn write or a missing entry is simply a cache miss.
return null;
}
}
export async function writeImagingCache(
directory: string,
key: string,
body: Uint8Array,
contentType: string,
): Promise<void> {
try {
await mkdir(directory, { recursive: true });
const base = join(directory, key);
// Write to temp files and rename twice so a concurrent reader never
// observes a half-written record; an interrupted write self-heals.
await writeFile(`${base}.img.tmp`, body);
await writeFile(
`${base}.json.tmp`,
JSON.stringify({ contentType }),
"utf8",
);
await rename(`${base}.img.tmp`, `${base}.img`);
await rename(`${base}.json.tmp`, `${base}.json`);
await pruneImagingCache(directory);
} catch {
// Caching is best-effort; a failure must never break the render path.
}
}
async function pruneImagingCache(directory: string): Promise<void> {
try {
const names = await readdir(directory);
if (names.length <= MAX_ENTRIES) return;
const cutoffMs = Date.now() - MAX_AGE_MS;
for (const name of names) {
try {
const file = join(directory, name);
const info = await stat(file);
if (info.mtimeMs < cutoffMs) await unlink(file);
} catch {
// Skip entries that disappeared between listing and unlink.
}
}
} catch {
// Nothing to prune or directory missing.
}
}
+46 -5
View File
@@ -1,5 +1,11 @@
import "server-only"; import "server-only";
import {
avatarCacheDir,
imagingCacheKey,
readImagingCache,
writeImagingCache,
} from "@/lib/imager-cache";
import { resolveImagerBase } from "@/lib/runtime-asset-config"; import { resolveImagerBase } from "@/lib/runtime-asset-config";
export const FIGURE_RE = /^[a-z]{2}-\d+(?:-\d+)*(?:\.[a-z]{2}-\d+(?:-\d+)*)*$/i; export const FIGURE_RE = /^[a-z]{2}-\d+(?:-\d+)*(?:\.[a-z]{2}-\d+(?:-\d+)*)*$/i;
@@ -8,10 +14,15 @@ export const FIGURE_MAX_PARTS = 24;
const HABBO_PUBLIC_UPSTREAM = "https://www.habbo.com/habbo-imaging/avatarimage"; const HABBO_PUBLIC_UPSTREAM = "https://www.habbo.com/habbo-imaging/avatarimage";
const PRIMARY_TIMEOUT_MS = 10_000; const PRIMARY_TIMEOUT_MS = 4_000;
const FALLBACK_TIMEOUT_MS = 6_000; const FALLBACK_TIMEOUT_MS = 4_000;
export type ImagerSource = "primary" | "fallback"; export type ImagerSource =
| "primary"
| "fallback"
| "cache"
| "cache-stale"
| "unavailable";
export interface ImagerResult { export interface ImagerResult {
body: Uint8Array; body: Uint8Array;
@@ -83,12 +94,28 @@ export async function fetchAvatarImage(
params: URLSearchParams, params: URLSearchParams,
): Promise<ImagerResult> { ): Promise<ImagerResult> {
const primary = resolveImagerBase(origin); const primary = resolveImagerBase(origin);
// Renders are immutable per figure/variant: serve a previously cached
// render without touching the upstream at all. This keeps repeated avatar
// requests off the local renderer and survives upstream downtime.
const cacheKey = imagingCacheKey(`${primary}\n${params.toString()}`);
const cached = await readImagingCache(avatarCacheDir(), cacheKey);
if (cached) return { ...cached, source: "cache" };
const primaryResult = await fetchUpstream( const primaryResult = await fetchUpstream(
primary, primary,
params, params,
PRIMARY_TIMEOUT_MS, PRIMARY_TIMEOUT_MS,
); );
if (primaryResult) return { ...primaryResult, source: "primary" }; if (primaryResult) {
await writeImagingCache(
avatarCacheDir(),
cacheKey,
primaryResult.body,
primaryResult.contentType,
);
return { ...primaryResult, source: "primary" };
}
if (isSameUpstream(primary, HABBO_PUBLIC_UPSTREAM)) { if (isSameUpstream(primary, HABBO_PUBLIC_UPSTREAM)) {
throw new ImagerUnavailableError( throw new ImagerUnavailableError(
@@ -101,7 +128,21 @@ export async function fetchAvatarImage(
buildFallbackParams(params), buildFallbackParams(params),
FALLBACK_TIMEOUT_MS, FALLBACK_TIMEOUT_MS,
); );
if (fallbackResult) return { ...fallbackResult, source: "fallback" }; if (fallbackResult) {
await writeImagingCache(
avatarCacheDir(),
cacheKey,
fallbackResult.body,
fallbackResult.contentType,
);
return { ...fallbackResult, source: "fallback" };
}
// Both upstreams are down and nothing was cached before. Try once more
// against the cache in case a concurrent request just wrote this render,
// then give up so the caller can serve a graceful placeholder.
const recent = await readImagingCache(avatarCacheDir(), cacheKey);
if (recent) return { ...recent, source: "cache-stale" };
throw new ImagerUnavailableError(); throw new ImagerUnavailableError();
} }
+51 -1
View File
@@ -1,7 +1,16 @@
import { NextRequest } from "next/server"; import { NextRequest } from "next/server";
import { afterEach, expect, it, vi } from "vitest"; import { afterEach, beforeEach, expect, it, vi } from "vitest";
import { GET } from "../app/api/imaging/avatar/route"; import { GET } from "../app/api/imaging/avatar/route";
beforeEach(() => {
// Fresh, isolated cache root per test run so the disk cache can never leak
// state between runs or into the runtime cache.
vi.stubEnv(
"IMAGING_CACHE_ROOT",
`${process.cwd()}/storage/imaging/test-route-${process.pid}-${Date.now()}`,
);
});
afterEach(() => { afterEach(() => {
vi.unstubAllEnvs(); vi.unstubAllEnvs();
vi.unstubAllGlobals(); vi.unstubAllGlobals();
@@ -66,3 +75,44 @@ it("falls back to the public Habbo renderer when the configured imager is down",
expect(target.searchParams.get("img_format")).toBe("png"); expect(target.searchParams.get("img_format")).toBe("png");
expect(target.searchParams.has("effect")).toBe(false); expect(target.searchParams.has("effect")).toBe(false);
}); });
it("serves a previously rendered avatar from the disk cache without re-fetching", async () => {
const fetcher = vi.fn(
async (_input: string | URL) =>
new Response(new Uint8Array([9, 8, 7]), {
headers: { "content-type": "image/png" },
}),
);
vi.stubGlobal("fetch", fetcher);
vi.stubEnv("IMAGER_URL", "https://cache.test/avatarimage");
const request = new NextRequest(
"https://hotel.test/api/imaging/avatar?figure=hd-123-1",
);
const first = await GET(request);
expect(first.status).toBe(200);
const callsAfterFirst = fetcher.mock.calls.length;
expect(callsAfterFirst).toBeGreaterThan(0);
const second = await GET(request);
expect(second.status).toBe(200);
expect(second.headers.get("x-imager-source")).toBe("cache");
expect(second.headers.get("cache-control")).toContain("max-age=3600");
// The cached render must not touch the upstream again.
expect(fetcher.mock.calls.length).toBe(callsAfterFirst);
});
it("serves a graceful silhouette instead of a broken image when every upstream is down", async () => {
const fetcher = vi.fn(
async (_input: string | URL) =>
new Response("renderer unreachable", { status: 503 }),
);
vi.stubGlobal("fetch", fetcher);
vi.stubEnv("IMAGER_URL", "https://down.test/avatarimage");
const result = await GET(
new NextRequest("https://hotel.test/api/imaging/avatar?figure=xd-900-1"),
);
expect(result.status).toBe(200);
expect(result.headers.get("content-type")).toBe("image/svg+xml");
expect(result.headers.get("x-imager-source")).toBe("unavailable");
expect(result.headers.get("cache-control")).toContain("no-cache");
});