From 990ebdb15826b69b67d6a9ef0ec1f744fbbb914a Mon Sep 17 00:00:00 2001 From: openhands Date: Sun, 11 Oct 2026 17:31:15 +0200 Subject: [PATCH] fix(pwa): retire the service worker instead of just fixing it The previous commit stopped the worker from caching build output, which removed the cause of the blank Catalog Studio but left the worker itself serving a purpose worth one offline fallback: three public endpoints (/api/home, /api/online, /api/radio/config). Behind Cloudflare, for a site whose visitors are online, that fallback rarely fires and goes stale exactly where it is most likely to matter. So the worker goes away rather than staying as a mostly-inert layer that every future release still has to keep correct. public/sw.js is not deleted, because deleting it would leave every existing registration alive and still in control of the page, caching as it did before. It becomes the opposite of what it was: on activate it deletes every cache, unregisters itself and reloads open clients so they stop being controlled. Browsers that already installed a worker therefore uninstall it on their next visit; browsers that never had one are unaffected. src/components/pwa-register.tsx is removed and unmounted from the root layout, so nothing registers a worker any more and the kill switch only ever runs for the visitors who need it. The manifest is deliberately untouched. src/app/manifest.ts is an ordinary Next.js route, independent of any worker, and Chrome installs from a manifest alone, so the site stays installable on a phone. Verified nothing depended on it: no other navigator.serviceWorker or caches.* reference exists in the app, the theme runs from the plain /scripts/ theme-init.js script, and no Studio, catalog or import module touches a worker. Typecheck and lint clean, 2326 unit tests and 72 UI tests green, including every Studio and catalog spec. --- public/sw.js | 95 +++++++++++---------------------- src/app/layout.tsx | 2 - src/components/pwa-register.tsx | 28 ---------- 3 files changed, 30 insertions(+), 95 deletions(-) delete mode 100644 src/components/pwa-register.tsx diff --git a/public/sw.js b/public/sw.js index d27bb301..0b2d3e09 100644 --- a/public/sw.js +++ b/public/sw.js @@ -1,10 +1,26 @@ -// Bumped to v4. The v3 worker cached /_next/static/ and /assets/ cache-first -// under a hardcoded cache name that was not tied to the build, so a release -// left the browser replaying the previous release's chunks against the new -// HTML. That combination renders a blank page. The cache name is the version, -// so it must move whenever this behaviour changes. -const CACHE = "atom-v4"; -const API_CACHE = "atom-api-v4"; +// Retired service worker — this file no longer serves anything. +// +// The app used to register a worker that cached /_next/static/ and /assets/ +// cache-first under a cache name with no build id. A release could not +// invalidate it, so browsers replayed the previous release's chunks against +// the new HTML and React never hydrated, which is what left the Catalog +// Studio on a blank white page. It also bought nothing: nginx already sends +// those two prefixes as `max-age=31536000, immutable` and their filenames are +// content-hashed, so the HTTP cache already handles them correctly. +// +// This file must stay at /sw.js and keep its install/activate handlers. +// Simply deleting it would leave every existing registration alive and in +// control of the page, with the old caching still running. Instead this +// worker does the opposite of what it used to: it deletes every cache and +// unregisters itself, then reloads open clients so they stop being +// controlled by it. +// +// Nothing registers it any more (see src/app/layout.tsx), so this only ever +// runs for browsers that already have a worker installed. Once a visitor +// loads the site again it uninstalls itself and never comes back. +// +// The manifest is unrelated and untouched — it is generated by +// src/app/manifest.ts and keeps the site installable without a worker. self.addEventListener("install", () => self.skipWaiting()); @@ -12,64 +28,13 @@ self.addEventListener("activate", (event) => { event.waitUntil( caches .keys() - .then((keys) => - Promise.all( - keys - .filter((k) => k !== CACHE && k !== API_CACHE) - .map((k) => caches.delete(k)), - ), + .then((keys) => Promise.all(keys.map((key) => caches.delete(key)))) + .then(() => self.registration.unregister()) + .then(() => + self.clients.matchAll({ type: "window", includeUncontrolled: true }), ) - .then(() => self.clients.claim()), + .then((clients) => { + for (const client of clients) client.navigate(client.url); + }), ); }); - -// Static build output is NOT cached here on purpose. -// -// nginx already sends `/_next/static/` and `/assets/` with -// `max-age=31536000, immutable`. Those filenames are content-hashed, so the -// HTTP cache is both sufficient and safe: a changed file gets a new name. -// Wrapping them in a Cache Storage entry bought nothing and introduced a -// staleness bug the HTTP cache cannot have — the cache name had no build id, -// so a release kept serving the previous release's chunks. -// -// Letting these requests fall through also means a failed fetch surfaces as a -// normal network error the browser can retry, instead of a rejected -// respondWith() that silently drops the