fix(housekeeping): restore people partial compatibility

src/actions/bulk-users.ts

@@ -52,6 +52,35 @@ function failedIds(value: unknown): Array<{ userId: number; reason: string }> {
 		: [];
 }
 
+function legacyBulkOutcome(
+	after: Readonly<Record<string, unknown>> | null,
+	userIds: readonly number[],
+): {
+	readonly completed: number;
+	readonly total: number;
+	readonly failedIds: Array<{ userId: number; reason: string }>;
+} {
+	const databaseFailures = failedIds(after?.failedIds);
+	const externalSyncFailures = failedIds(after?.externalSyncFailures).map(
+		({ userId }) => ({ userId, reason: "Database error" }),
+	);
+	const pendingFailures = [...databaseFailures, ...externalSyncFailures];
+	const orderedFailures = userIds.flatMap((userId) => {
+		const index = pendingFailures.findIndex(
+			(failure) => failure.userId === userId,
+		);
+		return index === -1 ? [] : pendingFailures.splice(index, 1);
+	});
+	return {
+		completed: Math.max(
+			0,
+			numberValue(after?.completed) - externalSyncFailures.length,
+		),
+		total: numberValue(after?.total),
+		failedIds: [...orderedFailures, ...pendingFailures],
+	};
+}
+
 export async function bulkUnban({
 	userIds,
 }: {
@@ -113,12 +142,13 @@ export async function bulkGiveCurrency({
 		type,
 	});
 	if (!result.ok) return { ok: false, error: "Bulk currency failed" };
+	const outcome = legacyBulkOutcome(result.data.after, userIds);
 	return {
 		ok: true,
 		data: {
-			given: numberValue(result.data.after?.completed),
-			total: numberValue(result.data.after?.total),
-			failedIds: failedIds(result.data.after?.failedIds),
+			given: outcome.completed,
+			total: outcome.total,
+			failedIds: outcome.failedIds,
 		},
 	};
 }
@@ -142,12 +172,13 @@ export async function bulkGiveBadge({
 		badgeCode,
 	});
 	if (!result.ok) return { ok: false, error: "Bulk badge failed" };
+	const outcome = legacyBulkOutcome(result.data.after, userIds);
 	return {
 		ok: true,
 		data: {
-			given: numberValue(result.data.after?.completed),
-			total: numberValue(result.data.after?.total),
-			failedIds: failedIds(result.data.after?.failedIds),
+			given: outcome.completed,
+			total: outcome.total,
+			failedIds: outcome.failedIds,
 		},
 	};
 }
@@ -178,12 +209,13 @@ export async function bulkAdjustCurrency({
 			type,
 		});
 		if (!result.ok) return { ok: false, error: "Currency adjustment failed" };
+		const outcome = legacyBulkOutcome(result.data.after, userIds);
 		return {
 			ok: true,
 			data: {
-				adjusted: numberValue(result.data.after?.completed),
-				total: numberValue(result.data.after?.total),
-				failedIds: failedIds(result.data.after?.failedIds),
+				adjusted: outcome.completed,
+				total: outcome.total,
+				failedIds: outcome.failedIds,
 			},
 		};
 	}