Revert "Merge pull request 'Complete Housekeeping migration and /ase cutover' (#52) from codex/housekeeping-complete into main"

This reverts commit 488b6e57c4, reversing
changes made to b506b4499a.

src/actions/admin-teams.test.ts

@@ -1,69 +1,59 @@
+// @ts-nocheck
 import { revalidatePath } from "next/cache";
-import { beforeEach, expect, it, vi } from "vitest";
+import { beforeEach, describe, expect, it, vi } from "vitest";
 import { requirePermission } from "@/lib/admin/guard";
 import { createTeam, deleteTeam } from "./admin-teams";
 
-const { execute } = vi.hoisted(() => ({ execute: vi.fn() }));
-vi.mock("@/features/housekeeping/domains/people/services/mutations", () => ({
-	createPeopleMutationInvocation: vi.fn((staff, correlationId) => ({
-		expectedActorId: staff.id,
-		correlationId,
-		legacy: true,
-	})),
-	peopleMutationService: { execute },
-}));
+const { insertValues, deleteWhere } = vi.hoisted(() => {
+	const insertValues = vi.fn().mockResolvedValue([{ insertId: 1 }]);
+	const deleteWhere = vi.fn().mockResolvedValue([{ affectedRows: 1 }]);
+	return { insertValues, deleteWhere };
+});
+
 vi.mock("@/lib/admin/guard", () => ({ requirePermission: vi.fn() }));
-vi.mock("@/lib/permissions", () => ({
-	PERMS: { USERS_EDIT: "admin.users.edit" },
+vi.mock("@/lib/permissions", () => ({ PERMS: { USERS_EDIT: "users.edit" } }));
+vi.mock("@/lib/db", () => ({
+	db: {
+		insert: vi.fn(() => ({ values: insertValues })),
+		delete: vi.fn(() => ({ where: deleteWhere })),
+	},
+	WebsiteTeams: { id: "id" },
 }));
 vi.mock("next/cache", () => ({ revalidatePath: vi.fn() }));
 
-const form = (data: Record<string, string>) =>
-	({ get: (key: string) => data[key] ?? null }) as FormData;
+const staff = { id: 1, rank: 7, username: "admin" };
+const fakeForm = (data: Record<string, string | null>) => ({
+	get: (key: string) => (key in data ? data[key] : null),
+});
 
 beforeEach(() => {
 	vi.clearAllMocks();
-	vi.mocked(requirePermission).mockResolvedValue({
-		id: 1,
-		rank: 7,
-		username: "admin",
+	vi.mocked(requirePermission).mockResolvedValue(staff as never);
+	insertValues.mockResolvedValue([{ insertId: 1 }]);
+	deleteWhere.mockResolvedValue([{ affectedRows: 1 }]);
+});
+
+describe("createTeam", () => {
+	it("creates a team entry", async () => {
+		await createTeam(
+			fakeForm({ rankName: "Moderator" }) as unknown as FormData,
+		);
+		expect(insertValues).toHaveBeenCalledWith(
+			expect.objectContaining({ rankName: "Moderator" }),
+		);
+		expect(revalidatePath).toHaveBeenCalledWith("/admin/teams");
 	});
-	execute.mockResolvedValue({
-		ok: true,
-		data: { before: null, after: {} },
-		correlationId: "team",
+
+	it("returns early when rankName is empty", async () => {
+		await createTeam(fakeForm({ rankName: "" }) as unknown as FormData);
+		expect(insertValues).not.toHaveBeenCalled();
 	});
 });
 
-it("preserves create and delete team payloads plus /admin revalidation", async () => {
-	await createTeam(form({ rankName: "Moderator" }));
-	await deleteTeam(form({ id: "42" }));
-	expect(execute.mock.calls.map((call) => [call[1], call[2]])).toEqual([
-		[
-			"team.change",
-			{
-				action: "create",
-				rankName: "Moderator",
-				badge: "",
-				jobDescription: "",
-				staffColor: "#327fa8",
-				hiddenRank: false,
-			},
-		],
-		["team.change", { action: "delete", teamId: "42" }],
-	]);
-	expect(revalidatePath).toHaveBeenCalledTimes(2);
-});
-
-it("preserves empty rank name as a no-op", async () => {
-	await createTeam(form({ rankName: "" }));
-	expect(execute).not.toHaveBeenCalled();
-});
-
-it("preserves a team ID above Number.MAX_SAFE_INTEGER", async () => {
-	await deleteTeam(form({ id: "9007199254740993" }));
-	expect(execute).toHaveBeenCalledWith(expect.anything(), "team.change", {
-		action: "delete",
-		teamId: "9007199254740993",
+describe("deleteTeam", () => {
+	it("deletes a team entry", async () => {
+		await deleteTeam(fakeForm({ id: "42" }) as unknown as FormData);
+		expect(deleteWhere).toHaveBeenCalled();
+		expect(revalidatePath).toHaveBeenCalledWith("/admin/teams");
 	});
 });