refactor: centralize duplicated formatDate helper
Local Build and Deploy / deploy (push) Successful in 1m7s

21 files defined their own local formatDate (with three different output
formats: date, datetime, datetime-seconds, and varying null fallbacks).
Replace them with a single shared helper at src/lib/format-date.ts that
takes a variant + optional fallback, preserving the exact previous output
per call site (verified identical string results).

Removes ~21 copies of the same logic. photos.tsx and media-grid.tsx keep
their epoch-ms based formatters since those are a different input shape.

Verified: tsc --noEmit clean, full test suite green (301/301).
This commit is contained in:
openhands committed 2026-07-18 19:17:17 +02:00
1 parent 3c9c1311ec
commit b9c6001f08
20 files changed
+84 -86

No files matched your search

+2 -4
View File
@@ -1,4 +1,5 @@
import { redirect } from "next/navigation";
import { formatDate } from "@/lib/format-date";
import { getTranslations } from "next-intl/server";
import { createTicket } from "@/actions/help-tickets";
import { ContentCard, EmptyState, StatBlock } from "@/components/public/ui";
@@ -7,9 +8,6 @@ import { prisma } from "@/lib/prisma";
export const dynamic = "force-dynamic";
function formatDate(d: Date | null): string {
return d ? d.toISOString().slice(0, 16).replace("T", " ") : "";
}
export default async function HelpTicketsPage() {
const session = await auth();
@@ -101,7 +99,7 @@ export default async function HelpTicketsPage() {
{t2.open ? t("statusOpen") : t("statusClosed")}
</span>
</td>
<td className="muted">{formatDate(t2.createdAt)}</td>
<td className="muted">{formatDate(t2.createdAt, "datetime", "")}</td>
</tr>
))}
</tbody>
+2 -4
View File
@@ -1,4 +1,5 @@
import type { Metadata } from "next";
import { formatDate } from "@/lib/format-date";
import Link from "next/link";
import { notFound } from "next/navigation";
import { getTranslations } from "next-intl/server";
@@ -45,9 +46,6 @@ const REACTIONS: { key: string; emoji: string }[] = [
{ key: "wow", emoji: "😮" },
];
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 10) : "";
}
export default async function ArticlePage({
params,
@@ -262,7 +260,7 @@ export default async function ArticlePage({
<span>{t("userNumber", { id: c.userId })}</span>
)}
{c.createdAt ? (
<span> · {formatDate(c.createdAt)}</span>
<span> · {formatDate(c.createdAt, "date", "")}</span>
) : null}
</p>
<p style={{ margin: 0, whiteSpace: "pre-wrap" }}>
+2 -4
View File
@@ -1,4 +1,5 @@
import Image from "next/image";
import { formatDate } from "@/lib/format-date";
import Link from "next/link";
import { getTranslations } from "next-intl/server";
import { ContentCard, EmptyState } from "@/components/public/ui";
@@ -9,9 +10,6 @@ export const revalidate = 300;
export const metadata = { title: "News" };
function formatDate(d: Date | null): string {
return d ? d.toISOString().slice(0, 10) : "";
}
export default async function NewsPage() {
const t = await getTranslations("pages.news");
@@ -99,7 +97,7 @@ export default async function NewsPage() {
className="muted"
style={{ margin: "0.35rem 0 0.6rem", fontSize: "0.78rem" }}
>
{formatDate(a.createdAt)}
{formatDate(a.createdAt, "date", "")}
</p>
<p
style={{
+5 -7
View File
@@ -1,4 +1,5 @@
import Link from "next/link";
import { formatDate } from "@/lib/format-date";
import { notFound } from "next/navigation";
import { getTranslations } from "next-intl/server";
import { ContentCard } from "@/components/public/ui";
@@ -6,9 +7,6 @@ import { prisma } from "@/lib/prisma";
export const revalidate = 300;
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 19).replace("T", " ") : "";
}
export default async function RadioContestDetailPage({
params,
@@ -63,15 +61,15 @@ export default async function RadioContestDetailPage({
<tr>
<th>Period</th>
<td>
{contest.startDate ? formatDate(contest.startDate) : "—"}
{contest.startDate ? formatDate(contest.startDate, "datetime-seconds", "") : "—"}
{" — "}
{contest.endDate ? formatDate(contest.endDate) : "ongoing"}
{contest.endDate ? formatDate(contest.endDate, "datetime-seconds", "") : "ongoing"}
</td>
</tr>
<tr>
<th>Created</th>
<td>
{formatDate(contest.createdAt) || (
{formatDate(contest.createdAt, "datetime-seconds", "") || (
<span className="muted">—</span>
)}
</td>
@@ -79,7 +77,7 @@ export default async function RadioContestDetailPage({
<tr>
<th>Updated</th>
<td>
{formatDate(contest.updatedAt) || (
{formatDate(contest.updatedAt, "datetime-seconds", "") || (
<span className="muted">—</span>
)}
</td>
+2 -4
View File
@@ -1,13 +1,11 @@
import Link from "next/link";
import { formatDate } from "@/lib/format-date";
import { getTranslations } from "next-intl/server";
import { ContentCard, EmptyState } from "@/components/public/ui";
import { prisma } from "@/lib/prisma";
export const revalidate = 300;
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 10) : "";
}
export default async function RadioContestsPage() {
const t = await getTranslations("pages.radioContests");
@@ -67,7 +65,7 @@ export default async function RadioContestsPage() {
style={{ margin: 0, fontSize: "0.85rem" }}
>
{c.startDate
? `${formatDate(c.startDate)} — ${c.endDate ? formatDate(c.endDate) : "ongoing"}`
? `${formatDate(c.startDate, "date", "")} — ${c.endDate ? formatDate(c.endDate, "date", "") : "ongoing"}`
: t("dateUnknown")}
</p>
</Link>
+5 -7
View File
@@ -1,4 +1,5 @@
import Link from "next/link";
import { formatDate } from "@/lib/format-date";
import { notFound } from "next/navigation";
import { getTranslations } from "next-intl/server";
import { ContentCard } from "@/components/public/ui";
@@ -6,9 +7,6 @@ import { prisma } from "@/lib/prisma";
export const revalidate = 300;
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 19).replace("T", " ") : "";
}
export default async function RadioGiveawayDetailPage({
params,
@@ -68,15 +66,15 @@ export default async function RadioGiveawayDetailPage({
<tr>
<th>Period</th>
<td>
{giveaway.startDate ? formatDate(giveaway.startDate) : "—"}
{giveaway.startDate ? formatDate(giveaway.startDate, "datetime-seconds", "") : "—"}
{" — "}
{giveaway.endDate ? formatDate(giveaway.endDate) : "ongoing"}
{giveaway.endDate ? formatDate(giveaway.endDate, "datetime-seconds", "") : "ongoing"}
</td>
</tr>
<tr>
<th>Created</th>
<td>
{formatDate(giveaway.createdAt) || (
{formatDate(giveaway.createdAt, "datetime-seconds", "") || (
<span className="muted">—</span>
)}
</td>
@@ -84,7 +82,7 @@ export default async function RadioGiveawayDetailPage({
<tr>
<th>Updated</th>
<td>
{formatDate(giveaway.updatedAt) || (
{formatDate(giveaway.updatedAt, "datetime-seconds", "") || (
<span className="muted">—</span>
)}
</td>
+2 -4
View File
@@ -1,13 +1,11 @@
import Link from "next/link";
import { formatDate } from "@/lib/format-date";
import { getTranslations } from "next-intl/server";
import { ContentCard, EmptyState } from "@/components/public/ui";
import { prisma } from "@/lib/prisma";
export const revalidate = 300;
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 10) : "";
}
export default async function RadioGiveawaysPage() {
const t = await getTranslations("pages.radioGiveaways");
@@ -74,7 +72,7 @@ export default async function RadioGiveawaysPage() {
style={{ margin: 0, fontSize: "0.85rem" }}
>
{g.startDate
? `${formatDate(g.startDate)} — ${g.endDate ? formatDate(g.endDate) : "ongoing"}`
? `${formatDate(g.startDate, "date", "")} — ${g.endDate ? formatDate(g.endDate, "date", "") : "ongoing"}`
: t("dateUnknown")}
</p>
</Link>
+2 -4
View File
@@ -1,4 +1,5 @@
import { getTranslations } from "next-intl/server";
import { formatDate } from "@/lib/format-date";
import { submitRequest } from "@/actions/radio-requests";
import { ContentCard, EmptyState } from "@/components/public/ui";
import { auth } from "@/lib/auth";
@@ -6,9 +7,6 @@ import { prisma } from "@/lib/prisma";
export const dynamic = "force-dynamic";
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 16).replace("T", " ") : "";
}
export default async function RadioRequestsPage() {
const t = await getTranslations("pages.radioRequests");
@@ -136,7 +134,7 @@ export default async function RadioRequestsPage() {
)}
</td>
<td className="muted">
{r.submittedAt ? formatDate(r.submittedAt) : "—"}
{r.submittedAt ? formatDate(r.submittedAt, "datetime", "") : "—"}
</td>
<td>{status}</td>
</tr>
+2 -4
View File
@@ -1,4 +1,5 @@
import { getTranslations } from "next-intl/server";
import { formatDate } from "@/lib/format-date";
import { postShout } from "@/actions/radio-shouts";
import { ContentCard, EmptyState } from "@/components/public/ui";
import { auth } from "@/lib/auth";
@@ -8,9 +9,6 @@ import { siteSettings } from "@/lib/services/site-settings";
export const dynamic = "force-dynamic";
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 16).replace("T", " ") : "";
}
export default async function RadioShoutsPage() {
const t = await getTranslations("pages.radioShouts");
@@ -124,7 +122,7 @@ export default async function RadioShoutsPage() {
<div style={{ flex: 1, minWidth: 0 }}>
<p style={{ margin: "0 0 0.25rem" }}>
<strong>{author?.username ?? `User #${s.userId}`}</strong>{" "}
<span className="muted">{formatDate(s.createdAt)}</span>
<span className="muted">{formatDate(s.createdAt, "datetime", "")}</span>
</p>
<p style={{ margin: 0 }}>{s.message}</p>
</div>
+2 -4
View File
@@ -1,4 +1,5 @@
import type { Metadata } from "next";
import { formatDate } from "@/lib/format-date";
import Link from "next/link";
import { notFound } from "next/navigation";
import { getTranslations } from "next-intl/server";
@@ -47,9 +48,6 @@ function formatTimestamp(ts: number | null | undefined): string {
return new Date(ts * 1000).toISOString().slice(0, 10);
}
function formatDate(d: Date | null | undefined): string {
return d ? d.toISOString().slice(0, 10) : "";
}
export default async function ProfilePage({
params,
@@ -565,7 +563,7 @@ export default async function ProfilePage({
<strong>
{author?.username ?? t("unknownUser", { id: g.userId })}
</strong>{" "}
<span className="muted">{formatDate(g.createdAt)}</span>
<span className="muted">{formatDate(g.createdAt, "date", "")}</span>
</p>
<p style={{ margin: 0 }}>{g.message}</p>
</div>