fix(housekeeping): address task 14 review round 1

src/features/housekeeping/domains/content/pages/content-command-form.tsx

@@ -37,12 +37,19 @@ interface ContentCommandFormProps extends ContentCommandSubmission {
 	readonly buttonLabel: string;
 }
 
+const OMIT_FIELD = Symbol("omit optional Content command field");
+
 function parseField(field: ContentCommandField, formData: FormData): unknown {
 	const rawValue = formData.get(field.name);
+	if (rawValue === null && !field.required) return OMIT_FIELD;
 	if (field.type === "checkbox") return rawValue === "on";
 	if (field.type === "file") return rawValue instanceof File ? rawValue : null;
-	const raw = String(rawValue ?? "").normalize("NFC").trim();
+	const raw = String(rawValue ?? "")
+		.normalize("NFC")
+		.trim();
+	if (!raw && !field.required) return OMIT_FIELD;
 	if (field.type === "number") {
+		if (!raw) return raw;
 		const value = Number(raw);
 		if (!Number.isSafeInteger(value)) return 0;
 		return Math.min(field.max ?? value, Math.max(field.min ?? value, value));
@@ -60,7 +67,10 @@ function parseField(field: ContentCommandField, formData: FormData): unknown {
 			return null;
 		}
 	}
-	return raw.slice(0, field.maxLength ?? (field.type === "textarea" ? 20_000 : 500));
+	return raw.slice(
+		0,
+		field.maxLength ?? (field.type === "textarea" ? 20_000 : 500),
+	);
 }
 
 const initialState: HousekeepingResult<unknown> | null = null;
@@ -70,14 +80,13 @@ export async function submitContentCommandForm(
 	_previous: HousekeepingResult<unknown> | null,
 	formData: FormData,
 ): Promise<HousekeepingResult<unknown>> {
+	const submittedFields = (configuration.fields ?? []).flatMap((field) => {
+		const value = parseField(field, formData);
+		return value === OMIT_FIELD ? [] : [[field.name, value] as const];
+	});
 	const input = {
 		...configuration.input,
-		...Object.fromEntries(
-			(configuration.fields ?? []).map((field) => [
-				field.name,
-				parseField(field, formData),
-			]),
-		),
+		...Object.fromEntries(submittedFields),
 	};
 	const reason = String(formData.get("reason") ?? "")
 		.normalize("NFC")
@@ -127,7 +136,8 @@ export function ContentCommandForm({
 								id={`${commandId}-${field.name}`}
 								name={field.name}
 								type="checkbox"
-							/> {field.label}
+							/>{" "}
+							{field.label}
 						</>
 					) : field.type === "select" ? (
 						<>
@@ -139,6 +149,7 @@ export function ContentCommandForm({
 								required={field.required}
 								className="mt-1 block w-full"
 							>
+								{field.required ? null : <option value="">No change</option>}
 								{field.options?.map((option) => (
 									<option key={option.value} value={option.value}>
 										{option.label}