2 Commits

Include renames

Author	SHA1	Message	Date
openhands	48291ab641	fix: correct the ACL revoke migration and update the login redirect e2e ... The deploy gate found two defects in the previous commits, both mine. 0034_acl_midrank_revoke.sql never applied: it joined `acl_roles` on `ar.model_type`, a column that table does not have (only `acl_model_permissions` does). It now joins on the id and keeps the `model_type` check where it belongs. That hid a second, worse bug. The rank was extracted with `SUBSTRING(slug, 7)`, but MySQL's SUBSTRING is 1-based and the digits start at position 6, right after `rank_`. rank_10 therefore parsed as 0 and rank_7 as an empty string, so every rank >= 7 would have lost exactly the grants the migration exists to preserve — the ACL repair would have made things worse, not better. Now reads from position 6. Verified against a real MariaDB with a fixture covering rank_1, rank_6, rank_7, rank_9, rank_10 and a non-rank slug: only the sub-7 roles lose their non-view admin.* grants, the multi-digit and higher ranks keep everything, and the non-rank slug is untouched. The mail index was checked the same way — it applies idempotently and EXPLAIN confirms `users_mail_index` with rows: 1. news.spec.ts expected to land on /me after signing in. That expectation predates the `?from=` honouring added in 39332149, which lands a bounced admin back where they were heading. The same step navigates to /admin/articles/new explicitly a few lines later, so nothing depended on it; the assertion now covers the redirect target instead.	2026-10-09 18:21:09 +02:00
openhands	6cc45d7413	feat: harden atoms-nexst against review findings (37 items) ... Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.	2026-10-09 16:19:48 +02:00