Files
EpicNext-Cms/src/app/(site)/news/page.tsx
T
openhands 6cc45d7413
Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
feat: harden atoms-nexst against review findings (37 items)
Second review pass covering security, performance, admin tooling and the
public/room flows. All HIGH and MEDIUM findings from the audit are resolved;
nothing in this commit changes the visible feature set.

Authentication & session security
- CSP is now set on the request headers in the proxy, which is what Next.js
  uses to derive the render nonce, so the nonce is effective.
- 2FA: an already-enabled user cannot re-enroll, the setup endpoint is
  rate-limited per account, and confirmed codes are persisted so the second
  secret no longer silently never applies.
- Password reset revokes the ticket, authTicket and all personal access
  tokens, and bumps the token version so existing sessions die. The same
  revocation is now wired into the staff-side password reset.
- /reset and /verify return a stable error code instead of raw text; the
  mail lookups are ordered by id so duplicates cannot vary between runs.
- Resending the verification mail gets a per-address cooldown on top of the
  per-user limit.
- Issue API tokens with the narrower radio/ticket ability set instead of "*".

Authorization & input handling
- Mid-rank staff can no longer keep dynamically granted non-view admin.*
  permissions: existing grants are revoked by migration and the grant lookup
  is restricted to "%.view". Rank guards use the dynamic super-admin check.
- Alerting a user is permission-checked and audited like the other tools.
- Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user
  actions route, bulk user actions) are capped and rank-guarded, and bulk
  ids are bounded.
- updateRoom / updateRoomItem write through a field allowlist, and items
  may only be edited through their own room.
- Classnames reaching the filesystem are validated before use so a crafted
  value cannot escape the asset directories.
- The word filter now also covers offline mails, guild forum threads and
  replies, and user mottos.
- Media uploads are validated by magic bytes, /api/media requires the page
  edit permission, APP_URL must be configured once mail is enabled, and the
  diagnostics error route checks the fetch site header.

Admin tooling
- Secret settings render masked and cannot be overwritten with a blank or
  an arbitrary raw key; radio credentials are new password inputs.
- Commandocentrum balance changes are audited.
- Admin list pagination reads the caller's per-page instead of the max, and
  the log exporter caps offset and search length.

Performance
- Catalog translations are cached per module, with a cheap revision hash;
  the public online count uses a stale window instead of hammering the DB.
- The cache warmup now primes the payload the home route actually reads.
- TopHeader batches its queries into one round trip, and LCP avatars load
  eagerly.
- motion/react and sonner are no longer part of the root layout; the nav
  dropdown and mobile nav panels are lazy client chunks. Anonymous visitors
  again get the navigation chrome, and public pages get an edge cacheable
  response.

Accessibility
- Nested <main> elements in phase pages became <section>; the page entrance
  and route progress animations are pure CSS that respect reduced motion.
2026-10-09 16:19:48 +02:00

194 lines
4.9 KiB
TypeScript

import Image from "next/image";
import { getTranslations } from "next-intl/server";
import Link from "@/components/link";
import { ContentCard, EmptyState } from "@/components/public/ui";
import { excerpt } from "@/lib/format";
import { formatDate } from "@/lib/format-date";
import { logger } from "@/lib/logger";
import { withPublicPagePerformance } from "@/lib/public-page-performance";
import { loadNewsArchive } from "@/lib/services/news-archive";
export const metadata = { title: "News" };
async function NewsPage({
searchParams,
}: {
searchParams: Promise<{ q?: string; page?: string; order?: string }>;
}) {
const t = await getTranslations("pages.news");
const params = await searchParams;
const result = await loadNewsArchive({
search: params.q,
page: Number(params.page ?? 1),
order: params.order,
}).catch((error) => {
logger.error("Public news archive failed", { module: "news", error });
return null;
});
const articles = result?.rows ?? [];
const href = (page: number) =>
`/news?${new URLSearchParams({ q: result?.search ?? params.q ?? "", order: result?.order ?? "newest", page: String(page) })}`;
return (
<section className="page-grid">
<ContentCard icon="📰" title={t("title")} subtitle={t("subtitle")} />
<ContentCard>
<form
action="/news"
method="GET"
className="flex flex-wrap items-end gap-3"
>
<label className="flex min-w-0 flex-1 flex-col gap-1">
{t("searchLabel")}
<input
name="q"
defaultValue={params.q}
maxLength={191}
className="input w-full"
/>
</label>
<label className="flex flex-col gap-1">
{t("orderLabel")}
<select
name="order"
defaultValue={params.order === "oldest" ? "oldest" : "newest"}
className="input"
>
<option value="newest">{t("newest")}</option>
<option value="oldest">{t("oldest")}</option>
</select>
</label>
<button type="submit" className="btn btn-primary">
{t("apply")}
</button>
</form>
</ContentCard>
<ContentCard padded={articles.length === 0}>
{!result ? (
<p role="alert">{t("loadError")}</p>
) : articles.length === 0 ? (
<EmptyState icon="📰">{t("noArticles")}</EmptyState>
) : (
<div className="card-grid sm-2 lg-3" style={{ padding: "1rem" }}>
{articles.map((a) => (
<Link
key={a.slug}
href={`/news/${a.slug}`}
className="card hover"
style={{
display: "flex",
flexDirection: "column",
textDecoration: "none",
padding: 0,
overflow: "hidden",
}}
>
{a.image ? (
<div
style={{
position: "relative",
width: "100%",
aspectRatio: "16/9",
}}
>
<Image
src={a.image}
alt=""
fill
sizes="(max-width: 1024px) 50vw, 300px"
style={{ objectFit: "cover" }}
/>
</div>
) : (
<div
style={{
width: "100%",
aspectRatio: "16/9",
backgroundColor:
"color-mix(in srgb, var(--color-primary) 10%, var(--color-navbar))",
}}
/>
)}
<div
style={{
padding: "1rem 1.1rem",
flex: 1,
display: "flex",
flexDirection: "column",
}}
>
<h3
style={{
margin: 0,
fontSize: "1.05rem",
color:
"var(--color-navbar-text-readable, var(--color-navbar-text))",
lineHeight: 1.4,
}}
>
{a.title}
</h3>
<p
className="muted"
style={{
margin: "0.35rem 0 0.6rem",
fontSize: "0.78rem",
}}
>
{formatDate(a.createdAt, "date", "")}
</p>
<p
style={{
margin: 0,
color:
"var(--color-navbar-text-readable, var(--color-navbar-text))",
fontSize: "0.88rem",
lineHeight: 1.55,
}}
>
{excerpt(a.shortStory, 150)}
</p>
</div>
</Link>
))}
</div>
)}
</ContentCard>
{result && (
<ContentCard>
<nav
aria-label={t("pagination")}
className="flex flex-wrap items-center justify-between gap-3"
>
{result.page > 1 ? (
<Link href={href(result.page - 1)} className="btn">
{t("previous")}
</Link>
) : (
<span />
)}
<span>
{t("pageSummary", {
page: result.page,
pages: result.lastPage,
total: result.total,
})}
</span>
{result.page < result.lastPage ? (
<Link href={href(result.page + 1)} className="btn">
{t("next")}
</Link>
) : (
<span />
)}
</nav>
</ContentCard>
)}
</section>
);
}
export default withPublicPagePerformance("/news", NewsPage);