Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
122 lines
3.3 KiB
TypeScript
122 lines
3.3 KiB
TypeScript
import { asc, count } from "drizzle-orm";
|
|
import type { Metadata } from "next";
|
|
import { getTranslations } from "next-intl/server";
|
|
import Link from "@/components/link";
|
|
import { ContentCard, EmptyState } from "@/components/public/ui";
|
|
import { db, WebsiteRareValueCategories, WebsiteRareValues } from "@/lib/db";
|
|
import { siteSettings } from "@/lib/services/site-settings";
|
|
|
|
export async function generateMetadata(): Promise<Metadata> {
|
|
const t = await getTranslations("pages.rares");
|
|
return {
|
|
title: t("title"),
|
|
description: t("subtitle"),
|
|
openGraph: {
|
|
title: t("title"),
|
|
description: t("subtitle"),
|
|
type: "website",
|
|
},
|
|
};
|
|
}
|
|
|
|
type CategoryRow = {
|
|
id: bigint;
|
|
name: string;
|
|
badge: string;
|
|
priority: number;
|
|
};
|
|
|
|
export default async function RareValuesPage() {
|
|
const t = await getTranslations("pages.rares");
|
|
|
|
// Categories, per-category rare counts and site settings are all
|
|
// independent — run them concurrently instead of sequentially.
|
|
const [categoryRows, grouped, badgesBase] = await Promise.all([
|
|
db
|
|
.select({
|
|
id: WebsiteRareValueCategories.id,
|
|
name: WebsiteRareValueCategories.name,
|
|
badge: WebsiteRareValueCategories.badge,
|
|
priority: WebsiteRareValueCategories.priority,
|
|
})
|
|
.from(WebsiteRareValueCategories)
|
|
.orderBy(
|
|
asc(WebsiteRareValueCategories.priority),
|
|
asc(WebsiteRareValueCategories.name),
|
|
)
|
|
.catch((): CategoryRow[] => []),
|
|
db
|
|
.select({
|
|
categoryId: WebsiteRareValues.categoryId,
|
|
value: count(),
|
|
})
|
|
.from(WebsiteRareValues)
|
|
.groupBy(WebsiteRareValues.categoryId)
|
|
.catch(() => []),
|
|
siteSettings.get("badges_path", ""),
|
|
]);
|
|
|
|
const categories = categoryRows;
|
|
|
|
// Per-category rare counts (grouped so we avoid N queries).
|
|
const counts = new Map<string, number>();
|
|
for (const g of grouped) {
|
|
counts.set(String(g.categoryId), Number(g.value));
|
|
}
|
|
|
|
return (
|
|
<section className="page-grid">
|
|
<ContentCard icon="💎" title={t("title")} subtitle={t("subtitle")} />
|
|
|
|
{categories.length === 0 ? (
|
|
<ContentCard padded={false}>
|
|
<EmptyState icon="💎">{t("empty")}</EmptyState>
|
|
</ContentCard>
|
|
) : (
|
|
<div className="card-grid sm-2 lg-3">
|
|
{categories.map((c) => {
|
|
const id = String(c.id);
|
|
const rareCount = counts.get(id) ?? 0;
|
|
const badgeSrc =
|
|
badgesBase && c.badge ? `${badgesBase}/${c.badge}.gif` : "";
|
|
return (
|
|
<Link
|
|
key={id}
|
|
href={`/rares/${id}`}
|
|
className="content-card hover-lift"
|
|
style={{ color: "inherit", textDecoration: "none" }}
|
|
>
|
|
<div className="content-card-head">
|
|
{badgeSrc ? (
|
|
// eslint-disable-next-line @next/next/no-img-element
|
|
<img
|
|
src={badgeSrc}
|
|
alt={`${c.name} badge`}
|
|
width={36}
|
|
height={36}
|
|
style={{ flexShrink: 0 }}
|
|
/>
|
|
) : (
|
|
<span className="content-card-icon" aria-hidden>
|
|
💎
|
|
</span>
|
|
)}
|
|
<div className="content-card-head-text">
|
|
<p className="content-card-title">{c.name}</p>
|
|
<p className="content-card-subtitle">
|
|
{t("rareCount", { count: rareCount })}
|
|
</p>
|
|
</div>
|
|
</div>
|
|
<div className="content-card-body">
|
|
<span className="btn btn-outline">{t("viewRares")}</span>
|
|
</div>
|
|
</Link>
|
|
);
|
|
})}
|
|
</div>
|
|
)}
|
|
</section>
|
|
);
|
|
}
|