Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
157 lines
4.4 KiB
TypeScript
157 lines
4.4 KiB
TypeScript
import { asc, desc, eq, gte } from "drizzle-orm";
|
|
import type { Metadata } from "next";
|
|
import { getTranslations } from "next-intl/server";
|
|
import Link from "@/components/link";
|
|
import { PublicLoadError } from "@/components/public/load-error";
|
|
import { ProfileImage } from "@/components/shared/profile-image";
|
|
import { SurfaceCard } from "@/components/surface-card";
|
|
import { db, User, WebsiteTeams } from "@/lib/db";
|
|
import { avatarImageUrl } from "@/lib/format";
|
|
import { publicReadFailure } from "@/lib/services/public-read";
|
|
import { siteSettings } from "@/lib/services/site-settings";
|
|
import styles from "./staff.module.css";
|
|
|
|
export async function generateMetadata(): Promise<Metadata> {
|
|
const t = await getTranslations("pages.staff");
|
|
return {
|
|
title: t("title"),
|
|
description: t("subtitle"),
|
|
openGraph: {
|
|
title: t("title"),
|
|
description: t("subtitle"),
|
|
type: "website",
|
|
},
|
|
};
|
|
}
|
|
|
|
export default async function StaffPage() {
|
|
const t = await getTranslations("pages.staff");
|
|
const minStaffRank =
|
|
Number(await siteSettings.get("min_staff_rank", "7")) || 7;
|
|
|
|
// Independent queries — staff members and teams load concurrently.
|
|
const [staff, teams] = await Promise.all([
|
|
db
|
|
.select({
|
|
username: User.username,
|
|
look: User.look,
|
|
rank: User.rank,
|
|
motto: User.motto,
|
|
})
|
|
.from(User)
|
|
.where(gte(User.rank, minStaffRank))
|
|
.orderBy(desc(User.rank), asc(User.username))
|
|
.limit(100)
|
|
.catch(publicReadFailure("staff.members")),
|
|
db
|
|
.select({
|
|
id: WebsiteTeams.id,
|
|
rankName: WebsiteTeams.rankName,
|
|
badge: WebsiteTeams.badge,
|
|
jobDescription: WebsiteTeams.jobDescription,
|
|
staffColor: WebsiteTeams.staffColor,
|
|
})
|
|
.from(WebsiteTeams)
|
|
.where(eq(WebsiteTeams.hiddenRank, false))
|
|
.orderBy(asc(WebsiteTeams.id))
|
|
.then((rows) => rows.map((row) => ({ ...row, id: String(row.id) })))
|
|
.catch(publicReadFailure("staff.teams")),
|
|
]);
|
|
|
|
return (
|
|
<section className={styles.page}>
|
|
<SurfaceCard className={styles.hero}>
|
|
<div>
|
|
<h1>{t("title")}</h1>
|
|
<p>{t("subtitle")}</p>
|
|
</div>
|
|
{staff && staff.length > 0 && (
|
|
<span className={styles.count}>
|
|
{t("membersSubtitle", { count: staff.length })}
|
|
</span>
|
|
)}
|
|
</SurfaceCard>
|
|
<section aria-labelledby="staff-members">
|
|
<h2 id="staff-members" className={styles.heading}>
|
|
{t("membersTitle")}
|
|
</h2>
|
|
{staff === null ? (
|
|
<SurfaceCard className={styles.notice}>
|
|
<p role="alert">{t("loadError")}</p>
|
|
<Link href="/staff" className="btn btn-outline">
|
|
{t("retry")}
|
|
</Link>
|
|
</SurfaceCard>
|
|
) : staff.length === 0 ? (
|
|
<SurfaceCard className={styles.notice}>
|
|
<p>{t("emptyState")}</p>
|
|
</SurfaceCard>
|
|
) : (
|
|
<ul className={styles.grid}>
|
|
{staff.map((member) => (
|
|
<li key={member.username}>
|
|
<Link
|
|
href={`/u/${encodeURIComponent(member.username)}`}
|
|
className={styles.member}
|
|
>
|
|
<ProfileImage
|
|
src={avatarImageUrl(member.look, {
|
|
size: "m",
|
|
direction: 2,
|
|
headDirection: 3,
|
|
})}
|
|
alt={member.username}
|
|
width={64}
|
|
height={110}
|
|
className={styles.avatar}
|
|
/>
|
|
<div className={styles.identity}>
|
|
<h3>{member.username}</h3>
|
|
<p>{member.motto || t("noMotto")}</p>
|
|
<span className={styles.profile}>
|
|
{t("viewProfile")} <span aria-hidden="true">→</span>
|
|
</span>
|
|
</div>
|
|
</Link>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
)}
|
|
</section>
|
|
{teams === null ? (
|
|
<SurfaceCard className={styles.notice}>
|
|
<PublicLoadError href="/staff" />
|
|
</SurfaceCard>
|
|
) : (
|
|
teams.length > 0 && (
|
|
<section aria-labelledby="staff-teams">
|
|
<h2 id="staff-teams" className={styles.heading}>
|
|
{t("ranksTitle")}
|
|
</h2>
|
|
<p className={styles.subtitle}>{t("ranksSubtitle")}</p>
|
|
<ul className={styles.grid}>
|
|
{teams.map((team) => (
|
|
<li key={team.id}>
|
|
<SurfaceCard className={styles.team}>
|
|
<span
|
|
className={styles.accent}
|
|
style={{
|
|
backgroundColor: /^#[0-9a-f]{6}$/i.test(team.staffColor)
|
|
? team.staffColor
|
|
: "var(--color-primary)",
|
|
}}
|
|
aria-hidden="true"
|
|
/>
|
|
<h3>{team.rankName}</h3>
|
|
{team.jobDescription && <p>{team.jobDescription}</p>}
|
|
</SurfaceCard>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</section>
|
|
)
|
|
)}
|
|
</section>
|
|
);
|
|
}
|