Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
138 lines
3.6 KiB
TypeScript
138 lines
3.6 KiB
TypeScript
import { eq } from "drizzle-orm";
|
|
import { notFound, redirect } from "next/navigation";
|
|
import { getTranslations } from "next-intl/server";
|
|
import type { CSSProperties } from "react";
|
|
import { postThread } from "@/actions/social";
|
|
import Link from "@/components/link";
|
|
import { ContentCard } from "@/components/public/ui";
|
|
import { auth } from "@/lib/auth";
|
|
import { db, Guilds } from "@/lib/db";
|
|
|
|
type SearchParams = Promise<{ error?: string }>;
|
|
|
|
function feedbackStyle(tone: "success" | "error"): CSSProperties {
|
|
const accent =
|
|
tone === "error" ? "var(--color-danger)" : "var(--color-primary)";
|
|
return {
|
|
margin: 0,
|
|
padding: "0.85rem 1rem",
|
|
borderRadius: "var(--radius-md)",
|
|
border: `1px solid ${accent}`,
|
|
color: "var(--color-text-readable, var(--color-text))",
|
|
fontSize: "0.9rem",
|
|
fontWeight: 600,
|
|
background: "var(--color-surface)",
|
|
borderLeft: `4px solid ${accent}`,
|
|
};
|
|
}
|
|
|
|
export default async function NewThreadPage({
|
|
params,
|
|
searchParams,
|
|
}: {
|
|
params: Promise<{ id: string }>;
|
|
searchParams: SearchParams;
|
|
}) {
|
|
const t = await getTranslations("pages.guildForumNew");
|
|
const { id } = await params;
|
|
const { error } = await searchParams;
|
|
const guildId = Number(id);
|
|
if (!Number.isInteger(guildId) || guildId <= 0) notFound();
|
|
|
|
// Auth gate: only logged-in users may open a thread.
|
|
const session = await auth();
|
|
if (!session?.user?.id) redirect("/login");
|
|
|
|
// Guild header (read-only). A DB hiccup degrades to notFound rather than 500.
|
|
let guild: { id: number; name: string } | null = null;
|
|
try {
|
|
const [row] = await db
|
|
.select({ id: Guilds.id, name: Guilds.name })
|
|
.from(Guilds)
|
|
.where(eq(Guilds.id, guildId))
|
|
.limit(1);
|
|
guild = row ?? null;
|
|
} catch {
|
|
guild = null;
|
|
}
|
|
|
|
if (!guild) notFound();
|
|
|
|
const errorMessage =
|
|
error === "invalid"
|
|
? t("errors.invalid")
|
|
: error === "not_found"
|
|
? t("errors.notFound")
|
|
: error === "ratelimit"
|
|
? t("errors.ratelimit")
|
|
: error
|
|
? t("errors.error")
|
|
: null;
|
|
|
|
return (
|
|
<section className="page-grid">
|
|
{errorMessage ? (
|
|
<div role="alert" style={feedbackStyle("error")}>
|
|
{errorMessage}
|
|
</div>
|
|
) : null}
|
|
|
|
<p style={{ margin: 0 }}>
|
|
<Link href={`/guilds/${guild.id}/forum`}>{t("backToForum")}</Link>
|
|
</p>
|
|
|
|
<ContentCard
|
|
icon="✍️"
|
|
title={t("title")}
|
|
subtitle={t("subtitle", { guild: guild.name || t("unnamedGuild") })}
|
|
>
|
|
<form action={postThread}>
|
|
{/* Guild target drives the write; the author is taken from the session
|
|
inside the action, never from this form. */}
|
|
<input type="hidden" name="guildId" value={String(guild.id)} />
|
|
|
|
<label htmlFor="thread-subject" className="muted">
|
|
{t("subjectLabel")}
|
|
</label>
|
|
<input
|
|
id="thread-subject"
|
|
name="subject"
|
|
required
|
|
maxLength={255}
|
|
placeholder={t("subjectPlaceholder")}
|
|
style={{ width: "100%", margin: "0.4rem 0 0.9rem" }}
|
|
/>
|
|
|
|
<label htmlFor="thread-message" className="muted">
|
|
{t("messageLabel")}
|
|
</label>
|
|
<textarea
|
|
id="thread-message"
|
|
name="message"
|
|
required
|
|
rows={8}
|
|
placeholder={t("messagePlaceholder")}
|
|
style={{
|
|
width: "100%",
|
|
margin: "0.4rem 0 1rem",
|
|
resize: "vertical",
|
|
}}
|
|
/>
|
|
|
|
<div style={{ display: "flex", gap: "0.5rem", alignItems: "center" }}>
|
|
<button type="submit" className="btn btn-primary">
|
|
{t("postThread")}
|
|
</button>
|
|
<Link
|
|
href={`/guilds/${guild.id}/forum`}
|
|
className="btn btn-outline"
|
|
>
|
|
{t("cancel")}
|
|
</Link>
|
|
</div>
|
|
</form>
|
|
</ContentCard>
|
|
</section>
|
|
);
|
|
}
|