Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
246 lines
6.7 KiB
TypeScript
246 lines
6.7 KiB
TypeScript
import { and, desc, eq, inArray } from "drizzle-orm";
|
|
import { notFound } from "next/navigation";
|
|
import { getTranslations } from "next-intl/server";
|
|
import type { CSSProperties } from "react";
|
|
import Link from "@/components/link";
|
|
import { PublicLoadError } from "@/components/public/load-error";
|
|
import { ContentCard, EmptyState } from "@/components/public/ui";
|
|
import { db, Guilds, GuildsForumsThreads, User } from "@/lib/db";
|
|
import { formatDate } from "@/lib/format-date";
|
|
import { publicReadFailure } from "@/lib/services/public-read";
|
|
|
|
type SearchParams = Promise<{ posted?: string }>;
|
|
|
|
function feedbackStyle(tone: "success" | "error"): CSSProperties {
|
|
const accent =
|
|
tone === "error" ? "var(--color-danger)" : "var(--color-primary)";
|
|
return {
|
|
margin: 0,
|
|
padding: "0.85rem 1rem",
|
|
borderRadius: "var(--radius-md)",
|
|
border: `1px solid ${accent}`,
|
|
color: "var(--color-text-readable, var(--color-text))",
|
|
fontSize: "0.9rem",
|
|
fontWeight: 600,
|
|
background: "var(--color-surface)",
|
|
borderLeft: `4px solid ${accent}`,
|
|
};
|
|
}
|
|
|
|
type ThreadRow = {
|
|
id: number;
|
|
openerId: number | null;
|
|
subject: string | null;
|
|
postsCount: number | null;
|
|
createdAt: number | null;
|
|
updatedAt: number | null;
|
|
pinned: number | null;
|
|
locked: number | null;
|
|
};
|
|
|
|
export default async function GuildForumPage({
|
|
params,
|
|
searchParams,
|
|
}: {
|
|
params: Promise<{ id: string }>;
|
|
searchParams: SearchParams;
|
|
}) {
|
|
const t = await getTranslations("pages.guildForum");
|
|
const { id } = await params;
|
|
const { posted } = await searchParams;
|
|
const guildId = Number(id);
|
|
if (!Number.isInteger(guildId) || guildId <= 0) notFound();
|
|
|
|
// Missing guilds and unavailable guild data have distinct outcomes.
|
|
let guild: { id: number; name: string; badge: string } | null = null;
|
|
try {
|
|
const [row] = await db
|
|
.select({
|
|
id: Guilds.id,
|
|
name: Guilds.name,
|
|
badge: Guilds.badge,
|
|
})
|
|
.from(Guilds)
|
|
.where(eq(Guilds.id, guildId))
|
|
.limit(1);
|
|
guild = row ?? null;
|
|
} catch (error) {
|
|
publicReadFailure("guild.forum")(error);
|
|
return (
|
|
<section className="page-grid">
|
|
<ContentCard>
|
|
<PublicLoadError href={`/guilds/${guildId}/forum`} />
|
|
</ContentCard>
|
|
</section>
|
|
);
|
|
}
|
|
|
|
if (!guild) notFound();
|
|
|
|
// Threads for this guild. Pinned first, then most-recently active.
|
|
let threadsFailed = false;
|
|
let authorsFailed = false;
|
|
let threads: ThreadRow[] = [];
|
|
try {
|
|
threads = await db
|
|
.select({
|
|
id: GuildsForumsThreads.id,
|
|
openerId: GuildsForumsThreads.openerId,
|
|
subject: GuildsForumsThreads.subject,
|
|
postsCount: GuildsForumsThreads.postsCount,
|
|
createdAt: GuildsForumsThreads.createdAt,
|
|
updatedAt: GuildsForumsThreads.updatedAt,
|
|
pinned: GuildsForumsThreads.pinned,
|
|
locked: GuildsForumsThreads.locked,
|
|
})
|
|
.from(GuildsForumsThreads)
|
|
.where(
|
|
and(
|
|
eq(GuildsForumsThreads.guildId, guild.id),
|
|
eq(GuildsForumsThreads.state, 0),
|
|
),
|
|
)
|
|
.orderBy(
|
|
desc(GuildsForumsThreads.pinned),
|
|
desc(GuildsForumsThreads.updatedAt),
|
|
desc(GuildsForumsThreads.id),
|
|
)
|
|
.limit(100);
|
|
} catch (error) {
|
|
publicReadFailure("guild.threads")(error);
|
|
threadsFailed = true;
|
|
threads = [];
|
|
}
|
|
|
|
// Resolve opener usernames in one query (no relation exists in the schema, so
|
|
// join the users table manually by id). Falls back to the raw author id.
|
|
const openerIds = Array.from(
|
|
new Set(threads.map((t2) => t2.openerId ?? 0).filter((v) => v > 0)),
|
|
);
|
|
|
|
let users: { id: number; username: string }[] = [];
|
|
try {
|
|
users = openerIds.length
|
|
? await db
|
|
.select({ id: User.id, username: User.username })
|
|
.from(User)
|
|
.where(inArray(User.id, openerIds))
|
|
: [];
|
|
} catch (error) {
|
|
publicReadFailure("guild.thread-authors")(error);
|
|
authorsFailed = true;
|
|
users = [];
|
|
}
|
|
|
|
const usernameById = new Map(users.map((u) => [u.id, u.username]));
|
|
|
|
return (
|
|
<section className="page-grid">
|
|
{posted === "1" ? (
|
|
<div role="status" style={feedbackStyle("success")}>
|
|
{t("success.posted")}
|
|
</div>
|
|
) : null}
|
|
|
|
<p style={{ margin: 0 }}>
|
|
<Link href={`/guilds/${guild.id}`}>{t("backToGuild")}</Link>
|
|
</p>
|
|
|
|
<ContentCard
|
|
icon="🗣️"
|
|
title={t("forumTitle", { guild: guild.name || t("unnamedGuild") })}
|
|
subtitle={
|
|
threadsFailed
|
|
? undefined
|
|
: `${threads.length} ${threads.length === 1 ? t("threadSingular") : t("threadPlural")}`
|
|
}
|
|
action={
|
|
<Link
|
|
href={`/guilds/${guild.id}/forum/new`}
|
|
className="btn btn-primary"
|
|
>
|
|
{t("newThread")}
|
|
</Link>
|
|
}
|
|
/>
|
|
|
|
<ContentCard padded={threads.length === 0 || authorsFailed}>
|
|
{authorsFailed && (
|
|
<PublicLoadError href={`/guilds/${guild.id}/forum`} />
|
|
)}
|
|
{threadsFailed ? (
|
|
<PublicLoadError href={`/guilds/${guild.id}/forum`} />
|
|
) : threads.length === 0 ? (
|
|
<EmptyState icon="🗣️">{t("empty")}</EmptyState>
|
|
) : (
|
|
<table>
|
|
<thead>
|
|
<tr>
|
|
<th style={{ padding: "0.6rem 0.75rem" }}>{t("colSubject")}</th>
|
|
<th style={{ padding: "0.6rem 0.75rem" }}>{t("colAuthor")}</th>
|
|
<th style={{ padding: "0.6rem 0.75rem" }}>{t("colPosts")}</th>
|
|
<th style={{ padding: "0.6rem 0.75rem" }}>{t("colDate")}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{threads.map((t2) => {
|
|
const opener = t2.openerId ?? 0;
|
|
const username =
|
|
opener > 0 ? usernameById.get(opener) : undefined;
|
|
return (
|
|
<tr key={t2.id}>
|
|
<td style={{ padding: "0.6rem 0.75rem" }}>
|
|
<Link
|
|
href={`/guilds/${guild.id}/forum/${t2.id}`}
|
|
style={{ fontWeight: 700 }}
|
|
>
|
|
{t2.subject?.trim() || t("noSubject")}
|
|
</Link>
|
|
{t2.pinned ? (
|
|
<span
|
|
className="online-badge online"
|
|
style={{ marginLeft: "0.5rem" }}
|
|
>
|
|
📌 {t("pinned")}
|
|
</span>
|
|
) : null}
|
|
{t2.locked ? (
|
|
<span
|
|
className="online-badge"
|
|
style={{ marginLeft: "0.5rem" }}
|
|
>
|
|
🔒 {t("locked")}
|
|
</span>
|
|
) : null}
|
|
</td>
|
|
<td style={{ padding: "0.6rem 0.75rem" }}>
|
|
{username ? (
|
|
<Link href={`/u/${username}`}>{username}</Link>
|
|
) : (
|
|
<span className="muted">
|
|
{opener > 0
|
|
? t("userNumber", { id: opener })
|
|
: t("unknown")}
|
|
</span>
|
|
)}
|
|
</td>
|
|
<td style={{ padding: "0.6rem 0.75rem" }}>
|
|
{t2.postsCount ?? 0}
|
|
</td>
|
|
<td className="muted" style={{ padding: "0.6rem 0.75rem" }}>
|
|
{formatDate(
|
|
t2.createdAt ? new Date(t2.createdAt * 1000) : null,
|
|
"date",
|
|
)}
|
|
</td>
|
|
</tr>
|
|
);
|
|
})}
|
|
</tbody>
|
|
</table>
|
|
)}
|
|
</ContentCard>
|
|
</section>
|
|
);
|
|
}
|