Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
168 lines
4.6 KiB
TypeScript
168 lines
4.6 KiB
TypeScript
import { asc, eq, ne } from "drizzle-orm";
|
|
import { notFound } from "next/navigation";
|
|
import { getTranslations } from "next-intl/server";
|
|
import Link from "@/components/link";
|
|
import { ContentCard } from "@/components/public/ui";
|
|
import { SanitizedHtml } from "@/components/shared/sanitized-html";
|
|
import { db, WebsiteHelpCenterCategories } from "@/lib/db";
|
|
import { resolveHotelName } from "@/lib/hotel-name";
|
|
import { sanitize } from "@/lib/sanitize";
|
|
|
|
// Asset path matches AtomCMS's Blade view: asset('/assets/images/help-center/<image_url>').
|
|
const HELP_IMAGE_BASE = "/assets/images/help-center";
|
|
|
|
type HelpCategory = {
|
|
id: bigint;
|
|
name: string;
|
|
content: string;
|
|
position: number;
|
|
imageUrl: string | null;
|
|
buttonText: string | null;
|
|
buttonUrl: string | null;
|
|
buttonColor: string;
|
|
buttonBorderColor: string;
|
|
smallBox: boolean;
|
|
};
|
|
|
|
type HelpCategoryLink = {
|
|
id: bigint;
|
|
name: string;
|
|
position: number;
|
|
};
|
|
|
|
// Faithful to AtomCMS: name / content / button_text carry a `:hotel` placeholder
|
|
// replaced with the configured hotel name before display.
|
|
function withHotel(text: string | null | undefined, hotelName: string): string {
|
|
return (text ?? "").split(":hotel").join(hotelName);
|
|
}
|
|
|
|
export default async function HelpCategoryPage({
|
|
params,
|
|
}: {
|
|
params: Promise<{ category: string }>;
|
|
}) {
|
|
const t = await getTranslations("pages.helpCategory");
|
|
const { category } = await params;
|
|
|
|
let categoryId: bigint;
|
|
try {
|
|
categoryId = BigInt(category);
|
|
} catch {
|
|
notFound();
|
|
}
|
|
|
|
let cat: HelpCategory | null = null;
|
|
try {
|
|
const [row] = await db
|
|
.select({
|
|
id: WebsiteHelpCenterCategories.id,
|
|
name: WebsiteHelpCenterCategories.name,
|
|
content: WebsiteHelpCenterCategories.content,
|
|
position: WebsiteHelpCenterCategories.position,
|
|
imageUrl: WebsiteHelpCenterCategories.imageUrl,
|
|
buttonText: WebsiteHelpCenterCategories.buttonText,
|
|
buttonUrl: WebsiteHelpCenterCategories.buttonUrl,
|
|
buttonColor: WebsiteHelpCenterCategories.buttonColor,
|
|
buttonBorderColor: WebsiteHelpCenterCategories.buttonBorderColor,
|
|
smallBox: WebsiteHelpCenterCategories.smallBox,
|
|
})
|
|
.from(WebsiteHelpCenterCategories)
|
|
.where(eq(WebsiteHelpCenterCategories.id, categoryId))
|
|
.limit(1);
|
|
cat = row ?? null;
|
|
} catch {
|
|
cat = null;
|
|
}
|
|
|
|
if (!cat) notFound();
|
|
|
|
const hotelName = await resolveHotelName();
|
|
|
|
// Sibling help topics, so the reader can jump between categories. Isolated
|
|
// query: a DB hiccup degrades this list to empty rather than 500-ing.
|
|
let siblings: HelpCategoryLink[] = [];
|
|
try {
|
|
siblings = await db
|
|
.select({
|
|
id: WebsiteHelpCenterCategories.id,
|
|
name: WebsiteHelpCenterCategories.name,
|
|
position: WebsiteHelpCenterCategories.position,
|
|
})
|
|
.from(WebsiteHelpCenterCategories)
|
|
.where(ne(WebsiteHelpCenterCategories.id, categoryId))
|
|
.orderBy(asc(WebsiteHelpCenterCategories.position))
|
|
.limit(50);
|
|
} catch {
|
|
siblings = [];
|
|
}
|
|
|
|
const title = withHotel(cat.name, hotelName);
|
|
const content = withHotel(cat.content, hotelName);
|
|
const buttonText = withHotel(cat.buttonText, hotelName);
|
|
const imageSrc = cat.imageUrl ? `${HELP_IMAGE_BASE}/${cat.imageUrl}` : "";
|
|
const hasButton = Boolean(cat.buttonText && cat.buttonText.trim() !== "");
|
|
|
|
return (
|
|
<section className="page-grid">
|
|
<p style={{ margin: 0 }}>
|
|
<Link href="/help">{t("back")}</Link>
|
|
</p>
|
|
|
|
<ContentCard icon="❓" title={title} subtitle={t("topicSubtitle")}>
|
|
{imageSrc ? (
|
|
// eslint-disable-next-line @next/next/no-img-element
|
|
<img
|
|
src={imageSrc}
|
|
alt=""
|
|
style={{
|
|
float: "right",
|
|
maxWidth: 160,
|
|
height: "auto",
|
|
margin: "0 0 0.75rem 1rem",
|
|
}}
|
|
/>
|
|
) : null}
|
|
|
|
{/* content is author-supplied HTML — sanitised server-side. */}
|
|
<SanitizedHtml html={sanitize(content)} style={{ lineHeight: 1.7 }} />
|
|
|
|
{hasButton ? (
|
|
<div style={{ clear: "both", marginTop: "1rem" }}>
|
|
<a
|
|
href={cat.buttonUrl ?? "#"}
|
|
className="btn"
|
|
style={{
|
|
backgroundColor: cat.buttonColor,
|
|
border: `2px solid ${cat.buttonBorderColor}`,
|
|
}}
|
|
>
|
|
{buttonText}
|
|
</a>
|
|
</div>
|
|
) : null}
|
|
</ContentCard>
|
|
|
|
{siblings.length > 0 ? (
|
|
<ContentCard
|
|
icon="🧭"
|
|
title={t("moreTitle")}
|
|
subtitle={t("moreSubtitle")}
|
|
>
|
|
<div className="card-grid sm-2 lg-3">
|
|
{siblings.map((s) => (
|
|
<Link
|
|
key={String(s.id)}
|
|
href={`/help/${String(s.id)}`}
|
|
className="card hover"
|
|
style={{ display: "block", color: "inherit" }}
|
|
>
|
|
<strong>{withHotel(s.name, hotelName)}</strong>
|
|
</Link>
|
|
))}
|
|
</div>
|
|
</ContentCard>
|
|
) : null}
|
|
</section>
|
|
);
|
|
}
|