fix(catalog): remove suggestions that substitute different furniture

src/lib/furni/source-assets.ts

@@ -14,27 +14,3 @@ export interface SourceAssetCheck {
 	revision: number;
 	alternatives: SourceAssetItem[];
 }
-export function relatedFurniture(
-	item: SourceAssetItem,
-	candidates: SourceAssetItem[],
-) {
-	const tail = (name: string) =>
-		name.toLowerCase().split("_").slice(-2).join("_");
-	const label = (name: string) => (name ?? "").trim().toLowerCase();
-	return candidates
-		.filter(
-			(candidate) =>
-				candidate.classname !== item.classname &&
-				candidate.type === item.type &&
-				((label(item.name) && label(candidate.name) === label(item.name)) ||
-					(item.classname.split("_").length >= 3 &&
-						tail(candidate.classname) === tail(item.classname))),
-		)
-		.sort(
-			(a, b) =>
-				Number(label(b.name) === label(item.name)) -
-					Number(label(a.name) === label(item.name)) ||
-				a.classname.localeCompare(b.classname),
-		)
-		.slice(0, 5);
-}

src/lib/services/furniture-source-assets.test.ts

@@ -1,9 +1,6 @@
 // @vitest-environment node
 import { afterEach, describe, expect, it, vi } from "vitest";
-import {
-	relatedFurniture,
-	type SourceAssetItem,
-} from "@/lib/furni/source-assets";
+import type { SourceAssetItem } from "@/lib/furni/source-assets";
 import { inspectSourceAssets, probeAsset } from "./furniture-source-assets";
 
 const source: SourceAssetItem = {
@@ -23,7 +20,7 @@ const alternative = {
 };
 afterEach(() => vi.unstubAllGlobals());
 describe("source asset preflight", () => {
-	it("suggests reachable alternatives for unavailable source files", async () => {
+	it("keeps missing furniture unchanged even when a similar asset is available", async () => {
 		const fetchMock = vi.fn(
 			async (url: string) =>
 				new Response(null, { status: url.includes("/73257/") ? 200 : 404 }),
@@ -31,7 +28,9 @@ describe("source asset preflight", () => {
 		vi.stubGlobal("fetch", fetchMock);
 		const result = await inspectSourceAssets(source, [source, alternative]);
 		expect(result.state).toBe("missing");
-		expect(result.alternatives).toEqual([alternative]);
+		expect(result.classname).toBe(source.classname);
+		expect(result.alternatives).toEqual([]);
+		expect(fetchMock).toHaveBeenCalledTimes(1);
 	});
 	it("does not describe blocked or unreachable servers as missing files", async () => {
 		vi.stubGlobal(
@@ -67,28 +66,6 @@ describe("source asset preflight", () => {
 		);
 		expect(result.state).toBe("available");
 	});
-	it("bounds suggestions and excludes different furniture types", () => {
-		expect(
-			relatedFurniture(source, [source, { ...alternative, type: "wallitem" }]),
-		).toEqual([]);
-		expect(
-			relatedFurniture(
-				source,
-				Array.from({ length: 20 }, (_, id) => ({
-					...alternative,
-					id,
-					classname: `f${id}_monkeybzn_pole`,
-				})),
-			),
-		).toHaveLength(5);
-	});
-	it("handles unnamed source entries while finding related assets", () => {
-		expect(
-			relatedFurniture(source, [
-				{ ...alternative, name: null as unknown as string },
-			]),
-		).toHaveLength(1);
-	});
 	it("caches a probe to avoid repeating CDN requests", async () => {
 		const fetchMock = vi.fn(async () => new Response(null, { status: 200 }));
 		vi.stubGlobal("fetch", fetchMock);

src/lib/services/furniture-source-assets.ts

@@ -3,7 +3,6 @@ import type {
 	SourceAssetCheck,
 	SourceAssetItem,
 } from "@/lib/furni/source-assets";
-import { relatedFurniture } from "@/lib/furni/source-assets";
 import type { CloneSource } from "./clone-sources";
 import { browserHeaders } from "./import/core/browser-headers";
 
@@ -78,21 +77,11 @@ export async function inspectSourceAssets(
 		revision: item.revision || canonical?.revision || 0,
 	};
 	const state = await available(effective, source);
-	const alternatives: SourceAssetItem[] = [];
-	if (state === "missing") {
-		for (const candidate of relatedFurniture(
-			{ ...effective, name: canonical?.name || item.name },
-			official,
-		)) {
-			if ((await available(candidate)) === "available")
-				alternatives.push(candidate);
-			if (alternatives.length === 3) break;
-		}
-	}
+
 	return {
 		classname: item.classname,
 		revision: effective.revision,
 		state,
-		alternatives,
+		alternatives: [],
 	};
 }