🆙 Fix more errors php stan 🆙

Updated_Cms/app/Http/Controllers/Miscellaneous/InstallationController.php

@@ -7,18 +7,20 @@ use App\Models\Miscellaneous\WebsiteInstallation;
 use App\Models\Miscellaneous\WebsiteSetting;
 use App\Rules\ValidateInstallationKeyRule;
 use Exception;
+use Illuminate\Contracts\View\View;
+use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Str;
 
 class InstallationController extends Controller
 {
-    public function index()
+    public function index(): View
     {
         return view('installation.index');
     }
 
-    public function storeInstallationKey(Request $request)
+    public function storeInstallationKey(Request $request): RedirectResponse
     {
         $request->validate([
             'installation_key' => ['required', 'string', 'max:255', new ValidateInstallationKeyRule],
@@ -32,16 +34,16 @@ class InstallationController extends Controller
         return to_route('installation.show-step', 1);
     }
 
-    public function showStep($currentStep)
+    public function showStep(int $currentStep): View
     {
-        $settings = $this->getSettingsForStep((int) $currentStep);
+        $settings = $this->getSettingsForStep($currentStep);
 
         return view('installation.step-' . $currentStep, [
             'settings' => $settings,
         ]);
     }
 
-    public function saveStepSettings(Request $request)
+    public function saveStepSettings(Request $request): RedirectResponse
     {
         $this->updateSettings($request);
 
@@ -50,14 +52,14 @@ class InstallationController extends Controller
         return to_route('installation.show-step', WebsiteInstallation::first()->step);
     }
 
-    public function previousStep()
+    public function previousStep(): RedirectResponse
     {
         WebsiteInstallation::decrement('step');
 
         return to_route('installation.show-step', WebsiteInstallation::first()->step);
     }
 
-    public function restartInstallation()
+    public function restartInstallation(): RedirectResponse
     {
         WebsiteInstallation::first()->update([
             'step' => 0,
@@ -72,7 +74,7 @@ class InstallationController extends Controller
         return to_route('installation.index');
     }
 
-    public function completeInstallation()
+    public function completeInstallation(): RedirectResponse
     {
         WebsiteInstallation::latest()->first()->update([
             'completed' => true,
@@ -89,7 +91,7 @@ class InstallationController extends Controller
         return to_route('welcome');
     }
 
-    private function updateSettings(Request $request)
+    private function updateSettings(Request $request): void
     {
         foreach ($request->except('_token') as $key => $value) {
             WebsiteSetting::where('key', '=', $key)->update([
@@ -98,7 +100,7 @@ class InstallationController extends Controller
         }
     }
 
-    private function getSettingsForStep(int $step)
+    private function getSettingsForStep(int $step): \Illuminate\Database\Eloquent\Collection
     {
         $settingsData = array_chunk(WebsiteSetting::all()->pluck('key')->toArray(), ceil(WebsiteSetting::count() / 4));
 
@@ -107,7 +109,7 @@ class InstallationController extends Controller
             2 => $settingsData[1] ?? [],
             3 => $settingsData[2] ?? [],
             4 => $settingsData[3] ?? [],
-            5 => [], // Completion step has no settings
+            5 => [],
             default => throw new Exception('Step does not exist'),
         };
 

Updated_Cms/app/Http/Controllers/Miscellaneous/LogoGeneratorController.php

@@ -4,11 +4,14 @@ namespace App\Http\Controllers\Miscellaneous;
 
 use App\Http\Controllers\Controller;
 use App\Models\Miscellaneous\WebsiteSetting;
+use Illuminate\Contracts\View\View;
+use Illuminate\Http\JsonResponse;
+use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 
 class LogoGeneratorController extends Controller
 {
-    public function index()
+    public function index(): View|RedirectResponse
     {
         if (hasPermission('generate_logo') === '' || hasPermission('generate_logo') === '0') {
             return to_route('me.show')->with([
@@ -19,7 +22,7 @@ class LogoGeneratorController extends Controller
         return view('logo-generator');
     }
 
-    public function store(Request $request)
+    public function store(Request $request): JsonResponse
     {
         $request->validate(['logo' => ['required', 'image']]);
         $file = $request->file('logo');
@@ -35,6 +38,5 @@ class LogoGeneratorController extends Controller
         ]);
 
         return response()->json(['success' => true, 'message' => 'Logo updated!']);
-
     }
 }