🆙 Fix code in somephp files an refactored and deleted deprecated code 🆙

Updated_Cms/app/Http/Controllers/Badge/BadgeController.php

@@ -18,7 +18,7 @@ class BadgeController extends Controller
 
     private const int MAX_BADGE_SIZE_BYTES = 40960;
 
-    public function show(SettingsService $settingsService)
+    public function show(SettingsService $settingsService): \Illuminate\Contracts\View\View
     {
         $cost = (int) $settingsService->getOrDefault('drawbadge_currency_value', 150);
         $currencyType = $settingsService->getOrDefault('drawbadge_currency_type', 'credits');
@@ -41,7 +41,7 @@ class BadgeController extends Controller
         return view('draw-badge', ['cost' => $cost, 'currencyType' => $currencyType, 'folderError' => $folderError, 'errorMessage' => $errorMessage]);
     }
 
-    public function buy(Request $request, SendCurrency $sendCurrency, SettingsService $settingsService)
+    public function buy(Request $request, SendCurrency $sendCurrency, SettingsService $settingsService): \Illuminate\Http\JsonResponse
     {
         $user = Auth::user();
         $cost = (int) $settingsService->getOrDefault('drawbadge_currency_value', 150);

Updated_Cms/app/Http/Controllers/User/ProfileController.php

@@ -6,10 +6,12 @@ use App\Http\Controllers\Controller;
 use App\Models\Game\Guild\GuildMember;
 use App\Models\Game\Player\MessengerFriendship;
 use App\Models\User;
+use Illuminate\Contracts\View\View;
+use Illuminate\Database\Eloquent\Collection;
 
 class ProfileController extends Controller
 {
-    public function __invoke(User $user)
+    public function __invoke(User $user): View
     {
         $user = $this->loadUserRelations($user);
 
@@ -41,7 +43,7 @@ class ProfileController extends Controller
         ]);
     }
 
-    private function getUserFriends(int $userId)
+    private function getUserFriends(int $userId): Collection
     {
         return MessengerFriendship::select('user_two_id')
             ->where('user_one_id', '=', $userId)
@@ -52,7 +54,7 @@ class ProfileController extends Controller
             ->get();
     }
 
-    private function getUserGroups(int $userId)
+    private function getUserGroups(int $userId): Collection
     {
         return GuildMember::query()
             ->select(['guilds_members.id', 'guilds_members.guild_id', 'guilds_members.user_id', 'guilds.name', 'guilds.badge'])