P1-P3 admin cleanup: rank guard, SSRF guard, count caching, dead code removal, pagination rewrite
- P1: new src/lib/admin/rank-guard.ts with tryGuardRank/guardRank + RankGuardTarget/Result; extracted from users.ts; applied to admin-bans (create/lift + rank redirect) and admin-badges (caps + rank guard + error surfacing); import-url-safety.ts SSRF guard wired into clone save+icon fetch; logAudit await in help-tickets; antiddos mutations SETTINGS_EDIT; markAllAlertsRead NOTIFICATIONS_EDIT; rankError/saveError in all 25 message files; tests rew/new for bans/badges/rank-guard/import-url-safety - P2: ticket-inbox merged pagination reworked to single UNION ALL SQL with LIMIT/OFFSET (avoids O(offset) materialization); getCachedAdminCount with cacheFiltered option applied to devops/errors/photos/items/guilds/help-tickets/moderation pages; admin-theme catches→?error=1+banner+25 locales; logger in silent catches (rare-values/writeable-boxes); catalog-items-loader CAST→plain equality; count caching helper extended with opt-in cacheFiltered - P3: removed dead modules is-staff/notice/recent-furni-resync/log-filters plus load-user-sanctions/user-sanction-timeline; removed orphaned CATALOG_PAGE_COLUMNS re-export; removed getFurniIconUrl from studio-furni-icons Build: lint 0, typecheck 0, 3480 tests pass, i18n:check exit 0, colors exit 0. Circular chunk warning (9452/10535/66463) is webpack code-splitting artifact; build succeeds.
This commit is contained in:
1 parent
57529fd1ea
commit
7b249a7222
71 files changed
+1031
-1078
No files matched your search
@@ -4,23 +4,27 @@ import { db } from "@/lib/db";
|
||||
import { redisCache } from "@/lib/redis-cache";
|
||||
|
||||
/**
|
||||
* Caches admin list totals when no filters are applied (no 'where' clause),
|
||||
* preventing heavy COUNT(*) table scans on every request for large tables.
|
||||
* Filtered queries bypass cache to ensure exact search result counts.
|
||||
* Caches admin list totals, preventing heavy COUNT(*) table scans on every
|
||||
* request for large tables.
|
||||
*
|
||||
* By default only the unfiltered (global) count is cached; filtered queries
|
||||
* hit the DB so search result counts stay exact. Callers that read a stable,
|
||||
* fixed-filter total (e.g. "open tickets") can opt into caching it too with
|
||||
* `{ cacheFiltered: true }` and a cacheKey unique to that filter.
|
||||
*/
|
||||
export async function getCachedAdminCount(
|
||||
table: MySqlTable,
|
||||
cacheKey: string,
|
||||
where?: SQL | undefined,
|
||||
options?: { cacheFiltered?: boolean },
|
||||
): Promise<number> {
|
||||
// Only cache the global count (where = undefined)
|
||||
if (where) {
|
||||
const run = async (): Promise<number> => {
|
||||
const [row] = await db.select({ total: count() }).from(table).where(where);
|
||||
return Number(row?.total ?? 0);
|
||||
}
|
||||
};
|
||||
|
||||
return await redisCache(`admin:count:${cacheKey}`, 60, async () => {
|
||||
const [row] = await db.select({ total: count() }).from(table);
|
||||
return Number(row?.total ?? 0);
|
||||
});
|
||||
if (!where || options?.cacheFiltered) {
|
||||
return await redisCache(`admin:count:${cacheKey}`, 60, run);
|
||||
}
|
||||
return await run();
|
||||
}
|
||||
Reference in new issue
Block a user