From a7ccc98f84508c96c618897c516e878d9d304068 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Mon, 31 Aug 2026 17:48:36 +0200
Subject: [PATCH] fix: resolve pre-existing lint warnings

- Remove unused siteSettings import in auth-precheck.test.ts
- Replace non-null assertions with proper null checks in furni-data-i18n.ts
- Replace non-null assertions with proper null checks in conversion-pool.ts
---
 src/actions/auth-precheck.test.ts       |  1 -
 src/lib/services/furni-data-i18n.ts     | 16 ++++++++++++----
 src/lib/services/swf/conversion-pool.ts |  5 +++--
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/actions/auth-precheck.test.ts b/src/actions/auth-precheck.test.ts
index da37a925d3..a8f2001068 100644
--- a/src/actions/auth-precheck.test.ts
+++ b/src/actions/auth-precheck.test.ts
@@ -2,7 +2,6 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import { clientIp, rateLimit } from "@/lib/rate-limit";
 import { captchaConfig, verifyCaptcha } from "@/lib/services/captcha";
-import { siteSettings } from "@/lib/services/site-settings";
 import { precheckLogin } from "./auth-precheck";
 
 const core = vi.hoisted(() => ({
diff --git a/src/lib/services/furni-data-i18n.ts b/src/lib/services/furni-data-i18n.ts
index 132d886a46..aad6f5b712 100644
--- a/src/lib/services/furni-data-i18n.ts
+++ b/src/lib/services/furni-data-i18n.ts
@@ -457,13 +457,17 @@ export async function buildLocalizedFurniDataFiles(
 					translatedWall = res.translatedWall;
 					total = res.total;
 				} else {
-					const r = localPrepared.get(preparedKey!)!;
+					const r = localPrepared.get(preparedKey ?? "");
+					if (!r)
+						throw new Error(
+							`Missing localPrepared entry for key ${String(preparedKey)}`,
+						);
 					const res = finalizeLangFile(r.cloned, r.pendingRefs, translations);
 					json = res.json;
 					translatedRoom = res.translatedRoom;
 					translatedWall = res.translatedWall;
 					total = res.total;
-					localPrepared.delete(preparedKey!);
+					if (preparedKey != null) localPrepared.delete(preparedKey);
 				}
 
 				const targets = await getLocalizedWritePaths(lang);
@@ -593,13 +597,17 @@ export async function patchLocalizedFurniDataEntries(
 					added = res.added;
 					total = res.total;
 				} else {
-					const r = localPrepared.get(localKey!)!;
+					const r = localPrepared.get(localKey ?? "");
+					if (!r)
+						throw new Error(
+							`Missing localPrepared entry for key ${String(localKey)}`,
+						);
 					const res = finalizePatch(r, translations);
 					json = res.json;
 					patched = res.patched;
 					added = res.added;
 					total = res.total;
-					localPrepared.delete(localKey!);
+					if (localKey != null) localPrepared.delete(localKey);
 				}
 
 				for (const target of targets) {
diff --git a/src/lib/services/swf/conversion-pool.ts b/src/lib/services/swf/conversion-pool.ts
index 64e3a03107..41476dfc51 100644
--- a/src/lib/services/swf/conversion-pool.ts
+++ b/src/lib/services/swf/conversion-pool.ts
@@ -79,8 +79,9 @@ function ensurePool(): boolean {
 
 function pump() {
 	while (idle.length > 0 && queue.length > 0) {
-		const w = idle.pop()!;
-		const job = queue.shift()!;
+		const w = idle.pop();
+		const job = queue.shift();
+		if (!w || !job) break;
 		pending.set(job.req.id, { worker: w, job });
 		w.postMessage(job.req);
 	}