🆙 More fixes 🆙

This commit is contained in:
Remco
2026-01-19 22:27:10 +01:00
parent e0f7021693
commit c23a8e2fd3
4 changed files with 19 additions and 10 deletions
@@ -20,7 +20,9 @@ class BannedMiddleware
->exists(); ->exists();
if ($request->is('logout')) { if ($request->is('logout')) {
return $next($request); $response = $next($request);
assert($response instanceof Response);
return $response;
} }
if (! $authenticated && ! $ipBan && $request->is('banned')) { if (! $authenticated && ! $ipBan && $request->is('banned')) {
@@ -43,6 +45,8 @@ class BannedMiddleware
} }
} }
return $next($request); $response = $next($request);
assert($response instanceof Response);
return $response;
} }
} }
@@ -18,6 +18,8 @@ class FindRetrosMiddleware
return redirect($findRetrosService->getRedirectUri()); return redirect($findRetrosService->getRedirectUri());
} }
return $next($request); $response = $next($request);
assert($response instanceof Response);
return $response;
} }
} }
@@ -12,7 +12,9 @@ class ForceStaffTwoFactorMiddleware
public function handle(Request $request, Closure $next): Response public function handle(Request $request, Closure $next): Response
{ {
if (! Auth::check() || ! setting('force_staff_2fa')) { if (! Auth::check() || ! setting('force_staff_2fa')) {
return $next($request); $response = $next($request);
assert($response instanceof Response);
return $response;
} }
$user = $request->user(); $user = $request->user();
@@ -21,10 +23,12 @@ class ForceStaffTwoFactorMiddleware
'user/settings/2fa-verify', 'user/settings/2fa-verify',
]; ];
if (($user->rank >= setting('min_staff_rank') && ! $user->two_factor_confirmed) && ! in_array(request()->path(), $urls)) { if ($user !== null && ($user->rank >= setting('min_staff_rank') && ! $user->two_factor_confirmed) && ! in_array(request()->path(), $urls)) {
return to_route('settings.two-factor'); return to_route('settings.two-factor');
} }
return $next($request); $response = $next($request);
assert($response instanceof Response);
return $response;
} }
} }
@@ -26,7 +26,7 @@ class InstallationMiddleware
$installation = $this->getInstallation(); $installation = $this->getInstallation();
if ($installation && $installation->completed && $request->is('installation*')) { if ($installation->completed && $request->is('installation*')) {
Cache::rememberForever('app_installed', fn () => true); Cache::rememberForever('app_installed', fn () => true);
return to_route('welcome'); return to_route('welcome');
@@ -133,9 +133,8 @@ class InstallationMiddleware
private function isValidStep(Request $request): bool private function isValidStep(Request $request): bool
{ {
$step = $this->getCurrentStep($request); $raw = \Illuminate\Support\Str::after($request->path(), 'step/');
return filter_var($raw, FILTER_VALIDATE_INT) !== false;
return filter_var($step, FILTER_VALIDATE_INT) !== false;
} }
private function isNonPostRequest(Request $request): bool private function isNonPostRequest(Request $request): bool