openhands
179484642f
Closes the four HIGH/MEDIUM items left open after the previous pass. Login lockout - The only login limits were keyed on the client IP, so a distributed attempt could grind on one account indefinitely. Added a per-account lockout with a budget of 8 failures per 15 minutes. - The bucket is keyed on the RESOLVED account id, not on the submitted string: users may sign in with either username or e-mail and neither the lookup nor the input normaliser folds case, so an input-keyed bucket would hand out a fresh budget per spelling of the same account. - precheckLogin and NextAuth's authorize share the bucket, so the pre-check cannot be used to buy extra attempts and a client that skips it entirely is still bounded. Both check the lockout BEFORE verifying the password: the success path clears the counter, which would otherwise walk a locked account straight back in on the right password. - A successful login clears the failures, which needs two new primitives in rate-limit.ts: peekRateLimit (read-only, does not consume a unit) and clearRateLimit. - Fixed a latent inconsistency while doing so: the in-process bucket capped its counter at the limit while Redis' INCR kept climbing, so the two backends disagreed about how far over the limit a key was. Both now track the true count. Mail lookup index - Added an index on users.mail (0035). Password reset, e-mail verification and the resend cooldown all resolve a single account from a submitted address and were full table scans of `users`. Deliberately non-unique: legacy rows can hold the same address more than once, so a unique index would fail to apply. Resend captcha - /verify's resend form triggers real outbound mail and was reachable with only a cooldown. It now runs the configured captcha before the account lookup and before any send. Client message payload - The root layout serialised the whole catalogue into every page. pages.admin and admin are ~177 KB of the ~235 KB and are unreachable from the public route group, so that layout now installs its own provider with the staff namespaces removed. Nested providers replace rather than merge, which is why this has to live in the segment layout. /admin, /mod, /client and /admin-next keep the full set; a guard test fails if a public page ever references a staff namespace.
54 lines
1.9 KiB
TypeScript
54 lines
1.9 KiB
TypeScript
import type { AbstractIntlMessages } from "next-intl";
|
|
|
|
/**
|
|
* Client-side message scoping.
|
|
*
|
|
* `getMessages()` hands back the whole catalogue, and the root layout feeds all
|
|
* of it to `NextIntlClientProvider`, which serialises every message into the RSC
|
|
* payload of every page. The catalogue is ~235 KB of which `pages.admin` and
|
|
* `admin` together are ~177 KB — and no public page ever reads either.
|
|
*
|
|
* Nested `NextIntlClientProvider`s REPLACE the parent's messages rather than
|
|
* merging them (see use-intl's IntlProvider: `messages ?? parent.messages`), so
|
|
* a segment cannot ask for "just my part". Instead the public layout installs a
|
|
* provider seeded with the public subset, which shrinks the payload for every
|
|
* public page while leaving /admin, /mod, /client and /admin-next on the full set.
|
|
*/
|
|
|
|
/** Top-level namespaces plus `pages.*` sub-namespaces reserved for staff tools. */
|
|
const ADMIN_ONLY_NAMESPACES = new Set(["admin"]);
|
|
const ADMIN_ONLY_PAGE_NAMESPACES = new Set(["admin"]);
|
|
|
|
/**
|
|
* Drop the staff-tool namespaces from a full catalogue.
|
|
*
|
|
* A denylist rather than an allowlist on purpose: a new public page should work
|
|
* immediately rather than silently 500 on a missing namespace, and the only
|
|
* namespaces that must never reach a public client are the two admin ones. A
|
|
* guard test asserts that no component under `app/(site)` references them.
|
|
*/
|
|
export function publicClientMessages(
|
|
messages: AbstractIntlMessages,
|
|
): AbstractIntlMessages {
|
|
const result: AbstractIntlMessages = {};
|
|
|
|
for (const [key, value] of Object.entries(messages)) {
|
|
if (ADMIN_ONLY_NAMESPACES.has(key)) continue;
|
|
if (key !== "pages") {
|
|
result[key] = value;
|
|
continue;
|
|
}
|
|
|
|
const pages: AbstractIntlMessages = {};
|
|
for (const [pageKey, pageValue] of Object.entries(
|
|
value as AbstractIntlMessages,
|
|
)) {
|
|
if (ADMIN_ONLY_PAGE_NAMESPACES.has(pageKey)) continue;
|
|
pages[pageKey] = pageValue;
|
|
}
|
|
result.pages = pages;
|
|
}
|
|
|
|
return result;
|
|
}
|