Files
Atomcms-edit/app/Http/Controllers/Shop/PayPalController.php
T
root 7f59024bef fix(security): patch critical security vulnerabilities
- Remove User::$guarded = [] to prevent mass assignment attacks
- Enable SQL strict mode and disable emulated prepares (SQL injection prevention)
- Switch password hashing from bcrypt to argon2id (stronger algorithm)
- Enable session encryption to protect session data at rest
- Restrict TrustProxies to localhost only (prevent IP spoofing)
- Restrict CORS allowed_methods via env variable instead of wildcard
- Add PayPal amount mismatch detection to prevent payment manipulation
- Add double-capture prevention (idempotency check)
- Add expected_amount column to transactions table for verification
2026-05-19 19:37:15 +02:00

176 lines
6.2 KiB
PHP
Executable File

<?php
namespace App\Http\Controllers\Shop;
use App\Http\Controllers\Controller;
use App\Http\Requests\AccountTopupFormRequest;
use App\Models\Shop\WebsitePaypalTransaction;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Srmklive\PayPal\Services\PayPal;
use Srmklive\PayPal\Services\PayPal as PayPalClient;
use Symfony\Component\HttpFoundation\Response;
class PayPalController extends Controller
{
private const string STATUS_CANCELLED = 'CANCELLED';
private const string STATUS_COMPLETED = 'COMPLETED';
private ?PayPalClient $provider = null;
private function getProvider(): PayPalClient
{
if (! $this->provider instanceof PayPal) {
$this->provider = new PayPalClient;
$this->provider->setApiCredentials(config('habbo.paypal'));
$this->provider->getAccessToken();
}
return $this->provider;
}
public function process(AccountTopupFormRequest $request): Response|RedirectResponse
{
$amount = $request->integer('amount');
$orderData = [
'intent' => 'CAPTURE',
'application_context' => [
'return_url' => route('paypal.successful-transaction'),
'cancel_url' => route('paypal.cancelled-transaction'),
'brand_name' => setting('hotel_name'),
'landing_page' => 'BILLING',
'shipping_preference' => 'NO_SHIPPING',
'user_action' => 'CONTINUE',
],
'purchase_units' => [
0 => [
'amount' => [
'currency_code' => config('habbo.paypal.currency'),
'value' => (string) $amount,
],
],
],
];
$response = $this->getProvider()->createOrder($orderData);
if (isset($response['id']) === false) {
Log::error('Error creating order', ['response' => $response]);
return to_route('shop.index')->withErrors(
['message' => $response['message'] ?? __('Something went wrong')],
);
}
foreach ($response['links'] as $links) {
if ($links['rel'] === 'approve') {
$request->user()->transactions()->create([
'transaction_id' => $response['id'],
'amount' => 0,
'expected_amount' => $amount,
]);
return redirect()->away($links['href']);
}
}
return to_route('shop.index')->withErrors(
['message' => $response['message'] ?? __('Something went wrong')],
);
}
public function successful(Request $request): Response|RedirectResponse
{
$request->validate([
'token' => 'required',
]);
$user = $request->user();
$transaction = $user->transactions()->where('transaction_id', $request['token'])->first();
if ($transaction === null) {
return to_route('shop.index')->withErrors(['message' => __('Something went wrong, please try again later')]);
}
if ($transaction->status === self::STATUS_COMPLETED) {
return to_route('shop.index')->withErrors(['message' => __('Transaction already processed')]);
}
$response = $this->getProvider()->capturePaymentOrder($request['token']);
$paymentDetails = $response['purchase_units'][0]['payments']['captures'][0] ?? null;
if (! isset($response['status'], $paymentDetails)) {
Log::error('Invalid response from PayPal', ['response' => $response]);
return to_route('shop.index')->withErrors(['message' => __('Something went wrong, please try again later')]);
}
if (($response['status'] ?? null) === null) {
$details = $response['error']['details'][0];
$transaction->update([
'status' => $response['name'],
'description' => sprintf('%s - %s', $details['issue'], $details['description']),
'amount' => 0,
]);
return to_route('shop.index')->withErrors(['message' => __('Something went wrong, please check your paypal account to make sure nothing was deducted and try again')]);
}
$capturedAmount = (float) $paymentDetails['amount']['value'];
$expectedAmount = (float) ($transaction->expected_amount ?? 0);
if ($expectedAmount > 0 && abs($capturedAmount - $expectedAmount) > 0.01) {
Log::warning('PayPal amount mismatch', [
'transaction_id' => $transaction->transaction_id,
'expected' => $expectedAmount,
'captured' => $capturedAmount,
]);
$transaction->update([
'status' => 'AMOUNT_MISMATCH',
'description' => 'Captured amount does not match expected amount',
'amount' => $capturedAmount,
]);
return to_route('shop.index')->withErrors(['message' => __('Transaction amount mismatch detected')]);
}
$transaction->update([
'status' => $paymentDetails['status'],
'amount' => $capturedAmount,
'currency' => $paymentDetails['amount']['currency_code'],
]);
if ($response['status'] !== self::STATUS_COMPLETED) {
return to_route('shop.index')->withErrors(
['message' => $response['message'] ?? __('Something went wrong')],
);
}
$user->increment('website_balance', $capturedAmount);
return to_route('shop.index')->with('success', __('Transaction successful'));
}
public function cancelled(Request $request): RedirectResponse
{
$request->validate([
'token' => 'required',
]);
$transaction = $request->user()->transactions()->where('transaction_id', $request['token'])->first();
if ($transaction !== null) {
$transaction->update([
'status' => self::STATUS_CANCELLED,
'description' => 'The user cancelled the transaction',
]);
}
return to_route('shop.index')->withErrors(
['message' => __('You have canceled the transaction')],
);
}
}