openhands
108c6ce03d
Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 36s
CI / tests-integration (push) Successful in 2m3s
CI / tests-unit (push) Successful in 2m18s
CI / tests-ui (push) Successful in 3m6s
CI / preflight (push) Skipped
CI / deploy (push) Failing after 3m14s
The CI lint step was `biome check . || true`, so it could never fail: 14 real
violations were passing unnoticed. Drop the `|| true` and fix what it found.
Lint fixes, none of which change behaviour:
- give list items their natural identity instead of the array index
(key={c} / key={char}, key={`skeleton-${i}`})
- document the two useEffect dependency lists that must keep their
function-declaration handlers, with the reasoning that dropping them broke
the tree and save-on-Ctrl+S once already (704e3363)
- scope the remaining noArrayIndexKey / useExhaustiveDependencies exemptions to
the three files that need them, in biome.json instead of scattered comments
Storage, on a host that had grown to 81% disk:
- byparr starts a Firefox per request and never removes the profile it leaves in
the container's writable layer. With no volume mounted, nothing else reclaimed
it: 716 profiles / 6.8 GB in two days, ~1.7 GB/day. docker-prune.sh now removes
orphaned profiles, identifying live ones by the open fd in /proc/<pid>/fd rather
than by age, because browsers stay warm for ~27 hours here — longer than the
leak window, so no age threshold can be both safe and useful.
- bound the build cache properly: buildx treats --max-used-space and --filter as
mutually exclusive, so passing both silently dropped the 4 GB cap and the cache
reached 49 GB.
- escalate to the emergency prune when / drops below 8 GB free, so the bound holds
even if the schedule stops.
- clear multi-GB tmp_pack files left behind by a gc that was OOM-killed
mid-repack; git only removes those on the next successful gc.
- make setup-cron.sh append instead of replacing the crontab (`crontab -`
overwrites the whole file, which had been dropping the other scheduled jobs),
and run the prune daily rather than weekly to match the leak rate.
Volumes are still never pruned: mariadb-turbo-data is a database.
36 lines
1.2 KiB
Bash
Executable File
36 lines
1.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Setup cron jobs for maintenance
|
|
#
|
|
# Appends to the existing crontab. `crontab -` replaces the whole file, so a
|
|
# script that pipes one job at a time silently drops every other scheduled job.
|
|
# Entries are matched by their command, so re-running this is idempotent.
|
|
set -Eeuo pipefail
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
|
|
# Adds one schedule line to the crontab unless its command is already present.
|
|
add_job() {
|
|
local schedule="$1" command
|
|
command="${schedule##* }"
|
|
local current
|
|
current="$(crontab -l 2>/dev/null || true)"
|
|
if grep -Fq "$command" <<<"$current"; then
|
|
echo "Already scheduled: $command"
|
|
return
|
|
fi
|
|
if [[ -z "$current" ]]; then
|
|
printf '%s\n' "$schedule" | crontab -
|
|
else
|
|
printf '%s\n%s\n' "$current" "$schedule" | crontab -
|
|
fi
|
|
echo "Scheduled: $schedule"
|
|
}
|
|
|
|
# Run backup every day at 03:00
|
|
add_job "0 3 * * * $SCRIPT_DIR/backup.sh"
|
|
# Run prune every day at 04:00. Daily rather than weekly: byparr leaks roughly
|
|
# 1.7 GB/day of orphaned browser profiles into its writable layer, so a weekly
|
|
# run would let ~12 GB accumulate before anything reclaimed it.
|
|
add_job "0 4 * * * $SCRIPT_DIR/docker-prune.sh"
|
|
|
|
echo "Cron jobs configured."
|