openhands
6cc45d7413
Gitea Actions Runner Test / test-job (push) Successful in 2s
CI / check (push) Successful in 30s
CI / tests-integration (push) Successful in 1m42s
CI / tests-unit (push) Failing after 1m49s
CI / tests-ui (push) Successful in 2m31s
CI / preflight (push) Skipped
CI / deploy (push) Skipped
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
76 lines
2.0 KiB
TypeScript
76 lines
2.0 KiB
TypeScript
import { redirect } from "next/navigation";
|
|
import { calcPagination, parseListParams } from "./admin-helpers";
|
|
import { canAccess, getAdminContext, type PermissionSet } from "./permissions";
|
|
|
|
interface AdminListConfig<TRow> {
|
|
/** Permission slug required to view this page */
|
|
permission: string;
|
|
/** Default items per page. Default: 20 */
|
|
defaultPerPage?: number;
|
|
/**
|
|
* Runs the actual data query (Drizzle). Receives parsed list params and
|
|
* returns the rows + total count for the current page.
|
|
*/
|
|
fetch: (args: {
|
|
search: string;
|
|
page: number;
|
|
perPage: number;
|
|
rawParams: Record<string, string>;
|
|
}) => Promise<{ rows: TRow[]; total: number }>;
|
|
}
|
|
|
|
interface AdminListResult<TRow> {
|
|
rows: TRow[];
|
|
total: number;
|
|
page: number;
|
|
perPage: number;
|
|
lastPage: number;
|
|
locale: string;
|
|
permissions: PermissionSet;
|
|
rank: number;
|
|
}
|
|
|
|
/**
|
|
* Generic admin list data fetcher.
|
|
* Centralizes the common pattern: auth check, param parsing, pagination and
|
|
* row mapping. The caller supplies a Drizzle query via `config.fetch`.
|
|
*/
|
|
export async function fetchAdminList<TRow>(
|
|
config: AdminListConfig<TRow>,
|
|
paramsPromise: Promise<{ locale: string }>,
|
|
searchParamsPromise: Promise<Record<string, string>>,
|
|
): Promise<AdminListResult<TRow>> {
|
|
const { locale } = await paramsPromise;
|
|
const { session, permissions } = await getAdminContext();
|
|
|
|
if (!canAccess(permissions, config.permission, session.user.rank)) {
|
|
redirect("/admin");
|
|
}
|
|
|
|
const rawParams = await searchParamsPromise;
|
|
const sp = new URLSearchParams(rawParams);
|
|
const parsed = parseListParams(sp);
|
|
// `parsed.perPage` is already clamped to 1..100; re-reading the raw value
|
|
// here let `?perPage=100000` pass straight into LIMIT.
|
|
const perPage = config.defaultPerPage
|
|
? parsed.perPage || config.defaultPerPage
|
|
: parsed.perPage;
|
|
|
|
const { rows, total } = await config.fetch({
|
|
search: parsed.search,
|
|
page: parsed.page,
|
|
perPage,
|
|
rawParams,
|
|
});
|
|
|
|
const pagination = calcPagination(total, parsed.page, perPage);
|
|
|
|
return {
|
|
rows,
|
|
...pagination,
|
|
locale,
|
|
permissions,
|
|
rank: session.user.rank,
|
|
};
|
|
}
|